Re: [PATCH] staging: rtl8192u: fix multiple memory leaks on error path

2019-09-30 Thread Navid Emamdoost 
Could you take a look at this patch and confirm it, please?

On Thu, Sep 19, 2019 at 9:51 PM Navid Emamdoost
 wrote:
>
> In rtl8192_tx on error handling path allocated urbs and also skb should
> be released.
>
> Signed-off-by: Navid Emamdoost 
> ---
>  drivers/staging/rtl8192u/r8192U_core.c | 17 -
>  1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c 
> b/drivers/staging/rtl8192u/r8192U_core.c
> index fe1f279ca368..b62b03802b1b 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1422,7 +1422,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff 
> *skb)
> (struct tx_fwinfo_819x_usb *)(skb->data + 
> USB_HWDESC_HEADER_LEN);
> struct usb_device *udev = priv->udev;
> int pend;
> -   int status;
> +   int status, rt = -1;
> struct urb *tx_urb = NULL, *tx_urb_zero = NULL;
> unsigned int idx_pipe;
>
> @@ -1566,8 +1566,10 @@ short rtl8192_tx(struct net_device *dev, struct 
> sk_buff *skb)
> }
> if (bSend0Byte) {
> tx_urb_zero = usb_alloc_urb(0, GFP_ATOMIC);
> -   if (!tx_urb_zero)
> -   return -ENOMEM;
> +   if (!tx_urb_zero) {
> +   rt = -ENOMEM;
> +   goto error;
> +   }
> usb_fill_bulk_urb(tx_urb_zero, udev,
>   usb_sndbulkpipe(udev, idx_pipe),
>   , 0, tx_zero_isr, dev);
> @@ -1577,7 +1579,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff 
> *skb)
>  "Error TX URB for zero byte %d, 
> error %d",
>  
> atomic_read(>tx_pending[tcb_desc->queue_index]),
>  status);
> -   return -1;
> +   goto error;
> }
> }
> netif_trans_update(dev);
> @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct 
> sk_buff *skb)
> RT_TRACE(COMP_ERR, "Error TX URB %d, error %d",
>  atomic_read(>tx_pending[tcb_desc->queue_index]),
>  status);
> -   return -1;
> +
> +error:
> +   dev_kfree_skb_any(skb);
> +   usb_free_urb(tx_urb);
> +   usb_free_urb(tx_urb_zero);
> +   return rt;
>  }
>
>  static short rtl8192_usb_initendpoints(struct net_device *dev)
> --
> 2.17.1
>


-- 
Navid.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8192u: fix multiple memory leaks on error path

2019-09-27 Thread Markus Elfring 
> In rtl8192_tx on error handling path allocated urbs and also skb should
> be released.

Can this change description be improved?


How do you think about to add the tag “Fixes” here?


> @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct 
> sk_buff *skb)
>   RT_TRACE(COMP_ERR, "Error TX URB %d, error %d",
>atomic_read(>tx_pending[tcb_desc->queue_index]),
>status);
> - return -1;
> +
> +error:
> + dev_kfree_skb_any(skb);
…

Would an other label be more appropriate according to the Linux coding style?

Regards,
Markus
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8192u: fix multiple memory leaks on error path

2019-09-20 Thread Greg Kroah-Hartman 
On Thu, Sep 19, 2019 at 09:51:33PM -0500, Navid Emamdoost wrote:
> In rtl8192_tx on error handling path allocated urbs and also skb should
> be released.
> 
> Signed-off-by: Navid Emamdoost 
> ---
>  drivers/staging/rtl8192u/r8192U_core.c | 17 -
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c 
> b/drivers/staging/rtl8192u/r8192U_core.c
> index fe1f279ca368..b62b03802b1b 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1422,7 +1422,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff 
> *skb)
>   (struct tx_fwinfo_819x_usb *)(skb->data + 
> USB_HWDESC_HEADER_LEN);
>   struct usb_device *udev = priv->udev;
>   int pend;
> - int status;
> + int status, rt = -1;
>   struct urb *tx_urb = NULL, *tx_urb_zero = NULL;
>   unsigned int idx_pipe;
>  
> @@ -1566,8 +1566,10 @@ short rtl8192_tx(struct net_device *dev, struct 
> sk_buff *skb)
>   }
>   if (bSend0Byte) {
>   tx_urb_zero = usb_alloc_urb(0, GFP_ATOMIC);
> - if (!tx_urb_zero)
> - return -ENOMEM;
> + if (!tx_urb_zero) {
> + rt = -ENOMEM;
> + goto error;
> + }
>   usb_fill_bulk_urb(tx_urb_zero, udev,
> usb_sndbulkpipe(udev, idx_pipe),
> , 0, tx_zero_isr, dev);
> @@ -1577,7 +1579,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff 
> *skb)
>"Error TX URB for zero byte %d, error 
> %d",
>
> atomic_read(>tx_pending[tcb_desc->queue_index]),
>status);
> - return -1;
> + goto error;
>   }
>   }
>   netif_trans_update(dev);
> @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct 
> sk_buff *skb)
>   RT_TRACE(COMP_ERR, "Error TX URB %d, error %d",
>atomic_read(>tx_pending[tcb_desc->queue_index]),
>status);
> - return -1;
> +
> +error:
> + dev_kfree_skb_any(skb);
> + usb_free_urb(tx_urb);
> + usb_free_urb(tx_urb_zero);
> + return rt;
>  }
>  
>  static short rtl8192_usb_initendpoints(struct net_device *dev)
> -- 
> 2.17.1
> 
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Hi,

This is the friendly semi-automated patch-bot of Greg Kroah-Hartman.
You have sent him a patch that has triggered this response.

Right now, the development tree you have sent a patch for is "closed"
due to the timing of the merge window.  Don't worry, the patch(es) you
have sent are not lost, and will be looked at after the merge window is
over (after the -rc1 kernel is released by Linus).

So thank you for your patience and your patches will be reviewed at this
later time, you do not have to do anything further, this is just a short
note to let you know the patch status and so you don't worry they didn't
make it through.

thanks,

greg k-h's patch email bot
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8192u: fix multiple memory leaks on error path

2019-09-19 Thread Navid Emamdoost 
In rtl8192_tx on error handling path allocated urbs and also skb should
be released.

Signed-off-by: Navid Emamdoost 
---
 drivers/staging/rtl8192u/r8192U_core.c | 17 -
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_core.c 
b/drivers/staging/rtl8192u/r8192U_core.c
index fe1f279ca368..b62b03802b1b 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -1422,7 +1422,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff 
*skb)
(struct tx_fwinfo_819x_usb *)(skb->data + 
USB_HWDESC_HEADER_LEN);
struct usb_device *udev = priv->udev;
int pend;
-   int status;
+   int status, rt = -1;
struct urb *tx_urb = NULL, *tx_urb_zero = NULL;
unsigned int idx_pipe;
 
@@ -1566,8 +1566,10 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff 
*skb)
}
if (bSend0Byte) {
tx_urb_zero = usb_alloc_urb(0, GFP_ATOMIC);
-   if (!tx_urb_zero)
-   return -ENOMEM;
+   if (!tx_urb_zero) {
+   rt = -ENOMEM;
+   goto error;
+   }
usb_fill_bulk_urb(tx_urb_zero, udev,
  usb_sndbulkpipe(udev, idx_pipe),
  , 0, tx_zero_isr, dev);
@@ -1577,7 +1579,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff 
*skb)
 "Error TX URB for zero byte %d, error 
%d",
 
atomic_read(>tx_pending[tcb_desc->queue_index]),
 status);
-   return -1;
+   goto error;
}
}
netif_trans_update(dev);
@@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff 
*skb)
RT_TRACE(COMP_ERR, "Error TX URB %d, error %d",
 atomic_read(>tx_pending[tcb_desc->queue_index]),
 status);
-   return -1;
+
+error:
+   dev_kfree_skb_any(skb);
+   usb_free_urb(tx_urb);
+   usb_free_urb(tx_urb_zero);
+   return rt;
 }
 
 static short rtl8192_usb_initendpoints(struct net_device *dev)
-- 
2.17.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel