Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

2016-06-08 Thread Luis de Bethencourt 
On 08/06/16 13:25, Parth Sane wrote:
> No mate, that aint just cutting it.
> I tried putting it, maybe i’m doing something wrong?
> Regards,
> Parth
>> On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt  
>> wrote:
>>
>> On 08/06/16 12:58, Parth Sane wrote:
>>> I’m trying to fix line 224 but its simply not happening. Can you help me 
>>> with this?
>>> Regards,
>>> Parth
 On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt  
 wrote:

 On 08/06/16 12:37, Parth Sane wrote:
>
>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt  
>> wrote:
>>
>> On 08/06/16 12:27, Parth Sane wrote:
>>> Multiple parenthesis alignment warnings were thrown by checkpatch in 
>>> ieee80211.c
>>> This patch effectively fixes that.
>>>
>>> Signed-off-by: Parth Sane 
>>>
>>> ---
>>> drivers/staging/rtl8712/ieee80211.c | 25 -
>>> 1 file changed, 12 insertions(+), 13 deletions(-)
>>
>> Some of the lines you change are over 80 characters. You could fix those 
>> as well in
>> a second patch :)
>>
>> Thanks,
>> Luis
>>
>
> You’re right on that regard. Maybe once this is accepted I can come back 
> to other warnings. I will submit other patches meanwhile.
> I seriously want to see this driver in the next release!
> Regards,
> Parth
>

 You can resend this patch and the one fixing the 80 char limit with the 
 subject
 prefix [RESEND PATCH v2 x/2].

 AFAIK this driver is already in the release, check menuconfig under
 "Device Drivers > Staging drivers > Realtek RTL8172"

 Thanks,
 Luis
>>>
>>
>> Sure.
>>
>> You want something like this:
>> -   if (memcmp((pbuf + 2), wpa_oui_type, 
>> sizeof(wpa_oui_type)))
>> +   if (memcmp((pbuf + 2), wpa_oui_type,
>> +  sizeof(wpa_oui_type)))
>>
>> You could check for references of how other parts of the code have solved it
>> by doing:
>> git grep memcpy * | grep -v ";"
>>
>> I hope that helps.
>> Luis
>>
>>
>>
>> Reviewed-by: Luis de Bethencourt 
> 

What is the output you get when it doesn't work. Without that it is hard for me
to be of help.

Luis
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

2016-06-08 Thread Parth Sane 
No mate, that aint just cutting it.
I tried putting it, maybe i’m doing something wrong?
Regards,
Parth
> On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt  
> wrote:
> 
> On 08/06/16 12:58, Parth Sane wrote:
>> I’m trying to fix line 224 but its simply not happening. Can you help me 
>> with this?
>> Regards,
>> Parth
>>> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt  
>>> wrote:
>>> 
>>> On 08/06/16 12:37, Parth Sane wrote:
 
> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt  
> wrote:
> 
> On 08/06/16 12:27, Parth Sane wrote:
>> Multiple parenthesis alignment warnings were thrown by checkpatch in 
>> ieee80211.c
>> This patch effectively fixes that.
>> 
>> Signed-off-by: Parth Sane 
>> 
>> ---
>> drivers/staging/rtl8712/ieee80211.c | 25 -
>> 1 file changed, 12 insertions(+), 13 deletions(-)
> 
> Some of the lines you change are over 80 characters. You could fix those 
> as well in
> a second patch :)
> 
> Thanks,
> Luis
> 
 
 You’re right on that regard. Maybe once this is accepted I can come back 
 to other warnings. I will submit other patches meanwhile.
 I seriously want to see this driver in the next release!
 Regards,
 Parth
 
>>> 
>>> You can resend this patch and the one fixing the 80 char limit with the 
>>> subject
>>> prefix [RESEND PATCH v2 x/2].
>>> 
>>> AFAIK this driver is already in the release, check menuconfig under
>>> "Device Drivers > Staging drivers > Realtek RTL8172"
>>> 
>>> Thanks,
>>> Luis
>> 
> 
> Sure.
> 
> You want something like this:
> -   if (memcmp((pbuf + 2), wpa_oui_type, 
> sizeof(wpa_oui_type)))
> +   if (memcmp((pbuf + 2), wpa_oui_type,
> +  sizeof(wpa_oui_type)))
> 
> You could check for references of how other parts of the code have solved it
> by doing:
> git grep memcpy * | grep -v ";"
> 
> I hope that helps.
> Luis
> 
> 
> 
> Reviewed-by: Luis de Bethencourt 



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

2016-06-08 Thread Luis de Bethencourt 
On 08/06/16 12:58, Parth Sane wrote:
> I’m trying to fix line 224 but its simply not happening. Can you help me with 
> this?
> Regards,
> Parth
>> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt  
>> wrote:
>>
>> On 08/06/16 12:37, Parth Sane wrote:
>>>
 On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt  
 wrote:

 On 08/06/16 12:27, Parth Sane wrote:
> Multiple parenthesis alignment warnings were thrown by checkpatch in 
> ieee80211.c
> This patch effectively fixes that.
>
> Signed-off-by: Parth Sane 
>
> ---
> drivers/staging/rtl8712/ieee80211.c | 25 -
> 1 file changed, 12 insertions(+), 13 deletions(-)

 Some of the lines you change are over 80 characters. You could fix those 
 as well in
 a second patch :)

 Thanks,
 Luis

>>>
>>> You’re right on that regard. Maybe once this is accepted I can come back to 
>>> other warnings. I will submit other patches meanwhile.
>>> I seriously want to see this driver in the next release!
>>> Regards,
>>> Parth
>>>
>>
>> You can resend this patch and the one fixing the 80 char limit with the 
>> subject
>> prefix [RESEND PATCH v2 x/2].
>>
>> AFAIK this driver is already in the release, check menuconfig under
>> "Device Drivers > Staging drivers > Realtek RTL8172"
>>
>> Thanks,
>> Luis
> 

Sure.

You want something like this:
-   if (memcmp((pbuf + 2), wpa_oui_type, 
sizeof(wpa_oui_type)))
+   if (memcmp((pbuf + 2), wpa_oui_type,
+  sizeof(wpa_oui_type)))

You could check for references of how other parts of the code have solved it
by doing:
git grep memcpy * | grep -v ";" 

I hope that helps.
Luis



Reviewed-by: Luis de Bethencourt 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

2016-06-08 Thread Parth Sane 
I’m trying to fix line 224 but its simply not happening. Can you help me with 
this?
Regards,
Parth
> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt  
> wrote:
> 
> On 08/06/16 12:37, Parth Sane wrote:
>> 
>>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt  
>>> wrote:
>>> 
>>> On 08/06/16 12:27, Parth Sane wrote:
 Multiple parenthesis alignment warnings were thrown by checkpatch in 
 ieee80211.c
 This patch effectively fixes that.
 
 Signed-off-by: Parth Sane 
 
 ---
 drivers/staging/rtl8712/ieee80211.c | 25 -
 1 file changed, 12 insertions(+), 13 deletions(-)
>>> 
>>> Some of the lines you change are over 80 characters. You could fix those as 
>>> well in
>>> a second patch :)
>>> 
>>> Thanks,
>>> Luis
>>> 
>> 
>> You’re right on that regard. Maybe once this is accepted I can come back to 
>> other warnings. I will submit other patches meanwhile.
>> I seriously want to see this driver in the next release!
>> Regards,
>> Parth
>> 
> 
> You can resend this patch and the one fixing the 80 char limit with the 
> subject
> prefix [RESEND PATCH v2 x/2].
> 
> AFAIK this driver is already in the release, check menuconfig under
> "Device Drivers > Staging drivers > Realtek RTL8172"
> 
> Thanks,
> Luis



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

2016-06-08 Thread Luis de Bethencourt 
On 08/06/16 12:37, Parth Sane wrote:
> 
>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt  
>> wrote:
>>
>> On 08/06/16 12:27, Parth Sane wrote:
>>> Multiple parenthesis alignment warnings were thrown by checkpatch in 
>>> ieee80211.c
>>> This patch effectively fixes that.
>>>
>>> Signed-off-by: Parth Sane 
>>>
>>> ---
>>> drivers/staging/rtl8712/ieee80211.c | 25 -
>>> 1 file changed, 12 insertions(+), 13 deletions(-)
>>
>> Some of the lines you change are over 80 characters. You could fix those as 
>> well in
>> a second patch :)
>>
>> Thanks,
>> Luis
>>
> 
> You’re right on that regard. Maybe once this is accepted I can come back to 
> other warnings. I will submit other patches meanwhile.
> I seriously want to see this driver in the next release!
> Regards,
> Parth
> 

You can resend this patch and the one fixing the 80 char limit with the subject
prefix [RESEND PATCH v2 x/2].

AFAIK this driver is already in the release, check menuconfig under
"Device Drivers > Staging drivers > Realtek RTL8172"

Thanks,
Luis
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

2016-06-08 Thread Parth Sane 

> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt  
> wrote:
> 
> On 08/06/16 12:27, Parth Sane wrote:
>> Multiple parenthesis alignment warnings were thrown by checkpatch in 
>> ieee80211.c
>> This patch effectively fixes that.
>> 
>> Signed-off-by: Parth Sane 
>> 
>> ---
>> drivers/staging/rtl8712/ieee80211.c | 25 -
>> 1 file changed, 12 insertions(+), 13 deletions(-)
> 
> Some of the lines you change are over 80 characters. You could fix those as 
> well in
> a second patch :)
> 
> Thanks,
> Luis
> 

You’re right on that regard. Maybe once this is accepted I can come back to 
other warnings. I will submit other patches meanwhile.
I seriously want to see this driver in the next release!
Regards,
Parth



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

2016-06-08 Thread Luis de Bethencourt 
On 08/06/16 12:27, Parth Sane wrote:
> Multiple parenthesis alignment warnings were thrown by checkpatch in 
> ieee80211.c
> This patch effectively fixes that.
> 
> Signed-off-by: Parth Sane 
> 
> ---
>  drivers/staging/rtl8712/ieee80211.c | 25 -
>  1 file changed, 12 insertions(+), 13 deletions(-)

Some of the lines you change are over 80 characters. You could fix those as 
well in
a second patch :)

Thanks,
Luis

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

2016-06-08 Thread Parth Sane 
Multiple parenthesis alignment warnings were thrown by checkpatch in ieee80211.c
This patch effectively fixes that.

Signed-off-by: Parth Sane 

---
 drivers/staging/rtl8712/ieee80211.c | 25 -
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/rtl8712/ieee80211.c 
b/drivers/staging/rtl8712/ieee80211.c
index 8918654..5dc3b5b 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -145,7 +145,7 @@ static void set_supported_rate(u8 *rates, uint mode)
case WIRELESS_11BG:
memcpy(rates, WIFI_CCKRATES, IEEE80211_CCK_RATE_LEN);
memcpy(rates + IEEE80211_CCK_RATE_LEN, WIFI_OFDMRATES,
-   IEEE80211_NUM_OFDM_RATESLEN);
+  IEEE80211_NUM_OFDM_RATESLEN);
break;
}
 }
@@ -188,24 +188,24 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
ie += 2;
/*SSID*/
ie = r8712_set_ie(ie, _SSID_IE_, pdev_network->Ssid.SsidLength,
-   pdev_network->Ssid.Ssid, );
+ pdev_network->Ssid.Ssid, );
/*supported rates*/
set_supported_rate(pdev_network->rates, pregistrypriv->wireless_mode);
rateLen = r8712_get_rateset_len(pdev_network->rates);
if (rateLen > 8) {
ie = r8712_set_ie(ie, _SUPPORTEDRATES_IE_, 8,
-   pdev_network->rates, );
+ pdev_network->rates, );
ie = r8712_set_ie(ie, _EXT_SUPPORTEDRATES_IE_, (rateLen - 8),
-   (pdev_network->rates + 8), );
+ (pdev_network->rates + 8), );
} else
ie = r8712_set_ie(ie, _SUPPORTEDRATES_IE_,
-   rateLen, pdev_network->rates, );
+ rateLen, pdev_network->rates, );
/*DS parameter set*/
ie = r8712_set_ie(ie, _DSSET_IE_, 1,
-   (u8 *)&(pdev_network->Configuration.DSConfig), );
+ (u8 *)&(pdev_network->Configuration.DSConfig), );
/*IBSS Parameter Set*/
ie = r8712_set_ie(ie, _IBSS_PARA_IE_, 2,
-   (u8 *)&(pdev_network->Configuration.ATIMWindow), );
+ (u8 *)&(pdev_network->Configuration.ATIMWindow), );
return sz;
 }
 
@@ -220,8 +220,7 @@ unsigned char *r8712_get_wpa_ie(unsigned char *pie, int 
*wpa_ie_len, int limit)
pbuf = r8712_get_ie(pbuf, _WPA_IE_ID_, , limit);
if (pbuf) {
/*check if oui matches...*/
-   if (memcmp((pbuf + 2), wpa_oui_type,
-   sizeof(wpa_oui_type)))
+   if (memcmp((pbuf + 2), wpa_oui_type, 
sizeof(wpa_oui_type)))
goto check_next_ie;
/*check version...*/
memcpy((u8 *), (pbuf + 6), sizeof(val16));
@@ -279,7 +278,7 @@ static int r8712_get_wpa2_cipher_suite(u8 *s)
 }
 
 int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
-int *pairwise_cipher)
+  int *pairwise_cipher)
 {
int i;
int left, count;
@@ -322,7 +321,7 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int 
*group_cipher,
 }
 
 int r8712_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int *group_cipher,
- int *pairwise_cipher)
+   int *pairwise_cipher)
 {
int i;
int left, count;
@@ -365,7 +364,7 @@ int r8712_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int 
*group_cipher,
 }
 
 int r8712_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len,
-  u8 *wpa_ie, u16 *wpa_len)
+u8 *wpa_ie, u16 *wpa_len)
 {
u8 authmode;
u8 wpa_oui[4] = {0x0, 0x50, 0xf2, 0x01};
@@ -383,7 +382,7 @@ int r8712_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, 
u16 *rsn_len,
} else {
if (authmode == _WPA2_IE_ID_) {
memcpy(rsn_ie, _ie[cnt],
-   in_ie[cnt + 1] + 2);
+  in_ie[cnt + 1] + 2);
*rsn_len = in_ie[cnt + 1] + 2;
cnt += in_ie[cnt + 1] + 2;  /*get next*/
} else {
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment

2016-03-20 Thread Parth Sane 

> On 20-Mar-2016, at 10:03 PM, Roger H Newell  wrote:
> 
> 
> On Mar 20, 2016 1:21 PM, "Parth Sane"  wrote:
> >
> >
> > > On 20-Mar-2016, at 9:18 PM, Joe Perches  wrote:
> > >
> > > On Sun, 2016-03-20 at 14:33 +, Parth Sane wrote:
> > >> Fixed multiple parenthesis alignment warnings.
> > >> Signed-off-by: Parth Sane 
> > >
> > > Please always add a blank line after your changelog and
> > > before your "Signed-off-by:" line
> > >
> > >> diff --git a/drivers/staging/rtl8712/hal_init.c 
> > >> b/drivers/staging/rtl8712/hal_init.c
> > > []
> > >> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
> > >> 0x);
> > >>  memcpy(ppayload, ptr, dump_imem_sz);
> > >>  r8712_write_mem(padapter, RTL8712_DMA_VOQ,
> > >> -  dump_imem_sz + TXDESC_SIZE,
> > >> +dump_imem_sz + TXDESC_SIZE,
> > >>(u8 *)ptx_desc);
> > >
> > > Please align all lines of multi-line statements.
> > >
> > > checkpatch is a stupid little script.
> > > You have to make sure your own patches are sensible.
> > >
> > > There are several things you should read and
> > > understand in the Documentation directory.
> > >
> > >   Documentation/CodingStyle
> > >   Documentation/SubmittingPatches
> > >   Documentation/SubmitChecklist
> > >
> > > Fixing checkpatch messages is sometimes a decent
> > > way to understand this process, but the patches
> > > that can be generated fixing these messages tend
> > > to have low overall value.
> > >
> > > After doing a few of these, please move on to
> > > some part of the kernel that interests you and
> > > submit new code or start to fix actual defects.
> > >
> > > Maybe if you are interested in wireless drivers,
> > > buy a NIC that isn't supported by the mac80211
> > > drivers and adapt the existing staging driver for
> > > that variant.
> > >
> > > Code, test, validate, submit, repeat...
> > >
> > Hi,
> > I’m first trying my hands at easy stuff before I actually move on to more 
> > difficult stuff. I will surely look in that direction. Thanks for your 
> > valuable inputs.
> > Regards,
> > Parth Sane
> >
> > ___
> > devel mailing list
> > de...@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> >
> 
> www.kernelnewbies.org is an excellent resource for getting started. Check out 
> the first patch tutorial, it walks you through all the basics of creating and 
> sending a properly formated patch. You're better off learning to do it right 
> the first  time, if its not right the patch simply won't be accepted and 
> you'll have to redo it anyway. Take some time to go through the tutorial I  
> mentioned. Good luck
> 
> Roger H. Newell
> 
Hi Roger,
Thanks for your comments. I’ve correctly submitted a patchset for the multiple 
FSF notices, maybe you can comment if its any good?. I’m through the rough 
patch and now understand the process now quite fairly.
I did checkout kernelnewbies.org before I submitted the patch, but alas I 
needed some practical XP.
Regards,
Parth Sane


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment

2016-03-20 Thread Parth Sane 

> On 20-Mar-2016, at 9:18 PM, Joe Perches  wrote:
> 
> On Sun, 2016-03-20 at 14:33 +, Parth Sane wrote:
>> Fixed multiple parenthesis alignment warnings.
>> Signed-off-by: Parth Sane 
> 
> Please always add a blank line after your changelog and
> before your "Signed-off-by:" line
> 
>> diff --git a/drivers/staging/rtl8712/hal_init.c 
>> b/drivers/staging/rtl8712/hal_init.c
> []
>> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
>> 0x);
>>  memcpy(ppayload, ptr, dump_imem_sz);
>>  r8712_write_mem(padapter, RTL8712_DMA_VOQ,
>> -  dump_imem_sz + TXDESC_SIZE,
>> +dump_imem_sz + TXDESC_SIZE,
>>(u8 *)ptx_desc);
> 
> Please align all lines of multi-line statements.
> 
> checkpatch is a stupid little script.
> You have to make sure your own patches are sensible.
> 
> There are several things you should read and
> understand in the Documentation directory.
> 
>   Documentation/CodingStyle
>   Documentation/SubmittingPatches
>   Documentation/SubmitChecklist
> 
> Fixing checkpatch messages is sometimes a decent
> way to understand this process, but the patches
> that can be generated fixing these messages tend
> to have low overall value.
> 
> After doing a few of these, please move on to
> some part of the kernel that interests you and
> submit new code or start to fix actual defects.
> 
> Maybe if you are interested in wireless drivers,
> buy a NIC that isn't supported by the mac80211
> drivers and adapt the existing staging driver for
> that variant.
> 
> Code, test, validate, submit, repeat...
> 
Hi,
I’m first trying my hands at easy stuff before I actually move on to more 
difficult stuff. I will surely look in that direction. Thanks for your valuable 
inputs.
Regards,
Parth Sane


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment

2016-03-20 Thread Joe Perches 
On Sun, 2016-03-20 at 14:33 +, Parth Sane wrote:
> Fixed multiple parenthesis alignment warnings.
> Signed-off-by: Parth Sane 

Please always add a blank line after your changelog and
before your "Signed-off-by:" line

> diff --git a/drivers/staging/rtl8712/hal_init.c 
> b/drivers/staging/rtl8712/hal_init.c
[]
> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
>      0x);
>   memcpy(ppayload, ptr, dump_imem_sz);
>   r8712_write_mem(padapter, RTL8712_DMA_VOQ,
> -   dump_imem_sz + TXDESC_SIZE,
> + dump_imem_sz + TXDESC_SIZE,
>     (u8 *)ptx_desc);

Please align all lines of multi-line statements.

checkpatch is a stupid little script.
You have to make sure your own patches are sensible.

There are several things you should read and
understand in the Documentation directory.

Documentation/CodingStyle
Documentation/SubmittingPatches
Documentation/SubmitChecklist

Fixing checkpatch messages is sometimes a decent
way to understand this process, but the patches
that can be generated fixing these messages tend
to have low overall value.

After doing a few of these, please move on to
some part of the kernel that interests you and
submit new code or start to fix actual defects.

Maybe if you are interested in wireless drivers,
buy a NIC that isn't supported by the mac80211
drivers and adapt the existing staging driver for
that variant.

Code, test, validate, submit, repeat...

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment

2016-03-20 Thread Parth Sane 
Fixed multiple parenthesis alignment warnings.
Signed-off-by: Parth Sane 
---
 drivers/staging/rtl8712/hal_init.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8712/hal_init.c 
b/drivers/staging/rtl8712/hal_init.c
index 225ef37..afa7fe78 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
   0x);
memcpy(ppayload, ptr, dump_imem_sz);
r8712_write_mem(padapter, RTL8712_DMA_VOQ,
- dump_imem_sz + TXDESC_SIZE,
+   dump_imem_sz + TXDESC_SIZE,
  (u8 *)ptx_desc);
ptr += dump_imem_sz;
imem_sz -= dump_imem_sz;
@@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
   0x);
memcpy(ppayload, ptr, dump_emem_sz);
r8712_write_mem(padapter, RTL8712_DMA_VOQ,
- dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc);
+   dump_emem_sz + TXDESC_SIZE,
+   (u8 *)ptx_desc);
ptr += dump_emem_sz;
emem_sz -= dump_emem_sz;
} while (emem_sz > 0);
@@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
ptx_desc->txdw0 |= cpu_to_le32(BIT(28));
memcpy(ppayload, , fwhdr.fw_priv_sz);
r8712_write_mem(padapter, RTL8712_DMA_VOQ,
- fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc);
+   fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc);
 
/* polling dmem code done */
i = 100;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel