Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

[Prasant Jalan]

On Mon, Apr 3, 2017 at 10:27 AM, Joe Perches  wrote:
> On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote:
>> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan  
>> wrote:
>> > Checkpatch emits WARNING: Avoid multiple line dereference.
>> >
>> > Trivial indentation improvement helps fix the checkpatch warning.
> []
>> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c 
>> > b/drivers/staging/rtl8712/rtl871x_xmit.c
> []
>> > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter 
>> > *padapter,
>> >[10], 6);
>> > }
>> > if (pqospriv->qos_option == 1)
>> > -   priority[0] = (u8)pxmitframe->
>> > - attrib.priority;
>> > +   priority[0] = 
>> > (u8)pxmitframe->attrib.priority;
>> > r8712_secmicappend(, [0], 4);
>> > payload = pframe;
>> > for (curfragnum = 0; curfragnum < 
>> > pattrib->nr_frags;
>> >  curfragnum++) {
>> > payload = (u8 *)RND4((addr_t)(payload));
>> > -   payload = payload + pattrib->
>> > - hdrlen + pattrib->iv_len;
>> > +   payload = payload + pattrib->hdrlen +
>> > + pattrib->iv_len;
>
> += would be shorter

Hi Joe,

Looks like back to school for me for overlooking such a trivial thing.

Thanks for the pointer, I will update the patch and resend.


Regards, Prasant
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

[Joe Perches]

On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote:
> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan  
> wrote:
> > Checkpatch emits WARNING: Avoid multiple line dereference.
> > 
> > Trivial indentation improvement helps fix the checkpatch warning.
[]
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c 
> > b/drivers/staging/rtl8712/rtl871x_xmit.c
[]
> > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter 
> > *padapter,
> >[10], 6);
> > }
> > if (pqospriv->qos_option == 1)
> > -   priority[0] = (u8)pxmitframe->
> > - attrib.priority;
> > +   priority[0] = 
> > (u8)pxmitframe->attrib.priority;
> > r8712_secmicappend(, [0], 4);
> > payload = pframe;
> > for (curfragnum = 0; curfragnum < pattrib->nr_frags;
> >  curfragnum++) {
> > payload = (u8 *)RND4((addr_t)(payload));
> > -   payload = payload + pattrib->
> > - hdrlen + pattrib->iv_len;
> > +   payload = payload + pattrib->hdrlen +
> > + pattrib->iv_len;

+= would be shorter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

[Prasant Jalan]

On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan  wrote:
> Checkpatch emits WARNING: Avoid multiple line dereference.
>
> Trivial indentation improvement helps fix the checkpatch warning.
>
> Signed-off-by: Prasant Jalan 
> ---
>  drivers/staging/rtl8712/rtl871x_xmit.c | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c 
> b/drivers/staging/rtl8712/rtl871x_xmit.c
> index de88819..10edf00 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> @@ -213,8 +213,9 @@ sint r8712_update_attrib(struct _adapter *padapter, _pkt 
> *pkt,
> if (padapter->pwrctrlpriv.pwr_mode !=
> padapter->registrypriv.power_mgnt) {
> del_timer_sync(>dhcp_timer);
> -   r8712_set_ps_mode(padapter, padapter->registrypriv.
> -   power_mgnt, padapter->registrypriv.smart_ps);
> +   r8712_set_ps_mode(padapter,
> + padapter->registrypriv.power_mgnt,
> + padapter->registrypriv.smart_ps);
> }
> }
>  }
> @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
>[10], 6);
> }
> if (pqospriv->qos_option == 1)
> -   priority[0] = (u8)pxmitframe->
> - attrib.priority;
> +   priority[0] = (u8)pxmitframe->attrib.priority;
> r8712_secmicappend(, [0], 4);
> payload = pframe;
> for (curfragnum = 0; curfragnum < pattrib->nr_frags;
>  curfragnum++) {
> payload = (u8 *)RND4((addr_t)(payload));
> -   payload = payload + pattrib->
> - hdrlen + pattrib->iv_len;
> +   payload = payload + pattrib->hdrlen +
> + pattrib->iv_len;
> if ((curfragnum + 1) == pattrib->nr_frags) {
> length = pattrib->last_txcmdsz -
>   pattrib->hdrlen -
> --
> 2.7.4
>


Hi all,


A gentle reminder for my small patch. Some comments will be most helpful.


Regards, Prasant Jalan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8712: fixed multiple line derefence issue

[Prasant Jalan]

Checkpatch emits WARNING: Avoid multiple line dereference.

Trivial indentation improvement helps fix the checkpatch warning.

Signed-off-by: Prasant Jalan 
---
 drivers/staging/rtl8712/rtl871x_xmit.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c 
b/drivers/staging/rtl8712/rtl871x_xmit.c
index de88819..10edf00 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -213,8 +213,9 @@ sint r8712_update_attrib(struct _adapter *padapter, _pkt 
*pkt,
if (padapter->pwrctrlpriv.pwr_mode !=
padapter->registrypriv.power_mgnt) {
del_timer_sync(>dhcp_timer);
-   r8712_set_ps_mode(padapter, padapter->registrypriv.
-   power_mgnt, padapter->registrypriv.smart_ps);
+   r8712_set_ps_mode(padapter,
+ padapter->registrypriv.power_mgnt,
+ padapter->registrypriv.smart_ps);
}
}
 }
@@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
   [10], 6);
}
if (pqospriv->qos_option == 1)
-   priority[0] = (u8)pxmitframe->
- attrib.priority;
+   priority[0] = (u8)pxmitframe->attrib.priority;
r8712_secmicappend(, [0], 4);
payload = pframe;
for (curfragnum = 0; curfragnum < pattrib->nr_frags;
 curfragnum++) {
payload = (u8 *)RND4((addr_t)(payload));
-   payload = payload + pattrib->
- hdrlen + pattrib->iv_len;
+   payload = payload + pattrib->hdrlen +
+ pattrib->iv_len;
if ((curfragnum + 1) == pattrib->nr_frags) {
length = pattrib->last_txcmdsz -
  pattrib->hdrlen -
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel