Re: [PATCH] staging: rtl8723au: remove unnecessary le32_to_cpu

[Jes Sorensen]

Michał Bartoszkiewicz  writes:
> The values passed to le32_to_cpu are already in the correct byte order.
> This fixes four "cast to restricted __le32" sparse warnings.
>
> Signed-off-by: Michał Bartoszkiewicz 
> ---
>  drivers/staging/rtl8723au/core/rtw_security.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)

Sounds OK to me - the fact we never hit problems with this is a good
indicator the hw crypt functions work.

Cheers,
Jes

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_security.c 
> b/drivers/staging/rtl8723au/core/rtw_security.c
> index 3d40bab..9d1cce1 100644
> --- a/drivers/staging/rtl8723au/core/rtw_security.c
> +++ b/drivers/staging/rtl8723au/core/rtw_security.c
> @@ -245,8 +245,8 @@ void rtw_wep_decrypt23a(struct rtw_adapter *padapter,
>   arcfour_encrypt(, payload, payload, length);
>  
>   /* calculate icv and compare the icv */
> - actual_crc = le32_to_cpu(getcrc32(payload, length - 4));
> - expected_crc = le32_to_cpu(get_unaligned_le32([length - 4]));
> + actual_crc = getcrc32(payload, length - 4);
> + expected_crc = get_unaligned_le32([length - 4]);
>  
>   if (actual_crc != expected_crc) {
>   RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
> @@ -773,8 +773,8 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
>   arcfour_init(, rc4key, 16);
>   arcfour_encrypt(, payload, payload, length);
>  
> - actual_crc = le32_to_cpu(getcrc32(payload, length - 4));
> - expected_crc = le32_to_cpu(get_unaligned_le32([length - 4]));
> + actual_crc = getcrc32(payload, length - 4);
> + expected_crc = get_unaligned_le32([length - 4]);
>  
>   if (actual_crc != expected_crc) {
>   RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8723au: remove unnecessary le32_to_cpu

[Michał Bartoszkiewicz]

The values passed to le32_to_cpu are already in the correct byte order.
This fixes four "cast to restricted __le32" sparse warnings.

Signed-off-by: Michał Bartoszkiewicz 
---
 drivers/staging/rtl8723au/core/rtw_security.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_security.c 
b/drivers/staging/rtl8723au/core/rtw_security.c
index 3d40bab..9d1cce1 100644
--- a/drivers/staging/rtl8723au/core/rtw_security.c
+++ b/drivers/staging/rtl8723au/core/rtw_security.c
@@ -245,8 +245,8 @@ void rtw_wep_decrypt23a(struct rtw_adapter *padapter,
arcfour_encrypt(, payload, payload, length);
 
/* calculate icv and compare the icv */
-   actual_crc = le32_to_cpu(getcrc32(payload, length - 4));
-   expected_crc = le32_to_cpu(get_unaligned_le32([length - 4]));
+   actual_crc = getcrc32(payload, length - 4);
+   expected_crc = get_unaligned_le32([length - 4]);
 
if (actual_crc != expected_crc) {
RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
@@ -773,8 +773,8 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
arcfour_init(, rc4key, 16);
arcfour_encrypt(, payload, payload, length);
 
-   actual_crc = le32_to_cpu(getcrc32(payload, length - 4));
-   expected_crc = le32_to_cpu(get_unaligned_le32([length - 4]));
+   actual_crc = getcrc32(payload, length - 4);
+   expected_crc = get_unaligned_le32([length - 4]);
 
if (actual_crc != expected_crc) {
RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
-- 
2.5.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel