Re: [PATCH] staging: rtl8723bs: hal: hal_btcoex: Remove variables pHalData and pU1Tmp

2019-06-20 Thread Dan Carpenter
Looks good.

Reviewed-by: Dan Carpenter 

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH] staging: rtl8723bs: hal: hal_btcoex: Remove variables pHalData and pU1Tmp

2019-06-19 Thread Hariprasad Kelam
Remove pHalData variable as it is set but unused in function.
Remove pU1Tmp and replace this with pu8

Signed-off-by: Hariprasad Kelam 
---
 drivers/staging/rtl8723bs/hal/hal_btcoex.c | 14 +-
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c 
b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index fd0be52..e673319 100644
--- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
+++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
@@ -560,18 +560,14 @@ static u8 halbtcoutsrc_Set(void *pBtcContext, u8 setType, 
void *pInBuf)
 {
PBTC_COEXIST pBtCoexist;
struct adapter *padapter;
-   struct hal_com_data *pHalData;
u8 *pu8;
-   u8 *pU1Tmp;
u32 *pU4Tmp;
u8 ret;
 
 
pBtCoexist = (PBTC_COEXIST)pBtcContext;
padapter = pBtCoexist->Adapter;
-   pHalData = GET_HAL_DATA(padapter);
pu8 = pInBuf;
-   pU1Tmp = pInBuf;
pU4Tmp = pInBuf;
ret = true;
 
@@ -614,11 +610,11 @@ static u8 halbtcoutsrc_Set(void *pBtcContext, u8 setType, 
void *pInBuf)
 
/*  set some u8 type variables. */
case BTC_SET_U1_RSSI_ADJ_VAL_FOR_AGC_TABLE_ON:
-   pBtCoexist->btInfo.rssiAdjustForAgcTableOn = *pU1Tmp;
+   pBtCoexist->btInfo.rssiAdjustForAgcTableOn = *pu8;
break;
 
case BTC_SET_U1_AGG_BUF_SIZE:
-   pBtCoexist->btInfo.aggBufSize = *pU1Tmp;
+   pBtCoexist->btInfo.aggBufSize = *pu8;
break;
 
/*  the following are some action which will be triggered */
@@ -633,15 +629,15 @@ static u8 halbtcoutsrc_Set(void *pBtcContext, u8 setType, 
void *pInBuf)
/* 1Ant === */
/*  set some u8 type variables. */
case BTC_SET_U1_RSSI_ADJ_VAL_FOR_1ANT_COEX_TYPE:
-   pBtCoexist->btInfo.rssiAdjustFor1AntCoexType = *pU1Tmp;
+   pBtCoexist->btInfo.rssiAdjustFor1AntCoexType = *pu8;
break;
 
case BTC_SET_U1_LPS_VAL:
-   pBtCoexist->btInfo.lpsVal = *pU1Tmp;
+   pBtCoexist->btInfo.lpsVal = *pu8;
break;
 
case BTC_SET_U1_RPWM_VAL:
-   pBtCoexist->btInfo.rpwmVal = *pU1Tmp;
+   pBtCoexist->btInfo.rpwmVal = *pu8;
break;
 
/*  the following are some action which will be triggered */
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel