Re: [PATCH] staging: rtl8723bs: os_dep: Remove unused variable

[Dan Carpenter]

On Sun, Sep 22, 2019 at 06:22:00PM +0530, Saurav Girepunje wrote:
> Remove unused variable ret from functions rtw_mp_ioctl_hdl,
> rtw_get_ap_info, rtw_mp_efuse_set, rtw_tdls, rtw_tdls_get .
> 
> Signed-off-by: Saurav Girepunje 
> ---
>  drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +--
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c 
> b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index 90c2997256b7..a51009963295 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -2433,8 +2433,7 @@ static  int rtw_drvext_hdl(struct net_device *dev, 
> struct iw_request_info *info,
>  static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info 
> *info,
>   union iwreq_data *wrqu, char 
> *extra)
>  {
> - int ret = 0;
> - return ret;
> + return 0;

Someone already sent a better patch which just deletes the whole
function.

https://marc.info/?l=linux-kernel&m=156879878226402&w=2

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8723bs: os_dep: Remove unused variable

[Saurav Girepunje]

Remove unused variable ret from functions rtw_mp_ioctl_hdl,
rtw_get_ap_info, rtw_mp_efuse_set, rtw_tdls, rtw_tdls_get .

Signed-off-by: Saurav Girepunje 
---
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +--
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c 
b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 90c2997256b7..a51009963295 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2433,8 +2433,7 @@ static  int rtw_drvext_hdl(struct net_device *dev, struct 
iw_request_info *info,
 static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info 
*info,
union iwreq_data *wrqu, char 
*extra)
 {
-   int ret = 0;
-   return ret;
+   return 0;
 }
 
 static int rtw_get_ap_info(struct net_device *dev,
@@ -4467,24 +4466,21 @@ static int rtw_mp_efuse_get(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wdata, char *extra)
 {
-   int err = 0;
-   return err;
+   return 0;
 }
 
 static int rtw_mp_efuse_set(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wdata, char *extra)
 {
-   int err = 0;
-   return err;
+   return 0;
 }
 
 static int rtw_tdls(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
 {
-   int ret = 0;
-   return ret;
+   return 0;
 }
 
 
@@ -4492,8 +4488,7 @@ static int rtw_tdls_get(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
 {
-   int ret = 0;
-   return ret;
+   return 0;
 }
 
 
-- 
2.20.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel