Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-14 Thread Greg KH 
On Fri, Mar 13, 2015 at 09:01:48AM -0700, Ragavendra wrote:
> BN is my initial, should it be expanded?

Yes.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-13 Thread Giedrius Statkevičius 
Hi Ragavendra,

On 2015.03.14 03:04, Ragavendra Nagraj wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the 
> code give no
> warnings by the checpath.pl. Please accept.

The "Please accept." part is unnecessary. We don't want that in a commit
log forever. Also, you fix a lot of coding style issues in one commit or
IOW more than one type of change in one commit.  What you could do
instead is fix one type of coding style issue in a commit for the whole
file and do that for each coding style issue. So that would result in 3
patches instead of this one. Could you do that and resend?

[...]

-- 
Thanks,
Giedrius
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-13 Thread Ragavendra Nagraj 
This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the 
code give no
warnings by the checpath.pl. Please accept.

Signed-off-by: Ragavendra Nagraj 
---
 drivers/staging/sm750fb/ddk750_chip.c |   22 --
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c 
b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
physicalID = devId750;//either 0x718 or 0x750
physicalRev = revId750;
 
-if (physicalID == 0x718)
-{
-chip = SM718;
-}
-else if (physicalID == 0x750)
-{
-chip = SM750;
+   if (physicalID == 0x718) {
+   chip = SM718;
+   } else if (physicalID == 0x750) {
+   chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
-   if (physicalRev == SM750LE_REVISION_ID){
+   if (physicalRev == SM750LE_REVISION_ID)
chip = SM750LE;
-   }
-}
-else
-{
-chip = SM_UNKNOWN;
-}
+   } else {
+   chip = SM_UNKNOWN;
+   }
 
return chip;
 }
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-13 Thread Dan Carpenter 
On Thu, Mar 12, 2015 at 11:11:27PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the 
> code give no
> warnings by the checpath.pl script check. Please accept.
^^
Don't put this in the changelog.

> 
> Signed-off-by: Ragavendra BN 

Is your name *really* BN?

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-12 Thread Ragavendra BN 
This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the 
code give no
warnings by the checpath.pl script check. Please accept.

Signed-off-by: Ragavendra BN 
---
 drivers/staging/sm750fb/ddk750_chip.c |   22 --
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c 
b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
physicalID = devId750;//either 0x718 or 0x750
physicalRev = revId750;
 
-if (physicalID == 0x718)
-{
-chip = SM718;
-}
-else if (physicalID == 0x750)
-{
-chip = SM750;
+   if (physicalID == 0x718) {
+   chip = SM718;
+   } else if (physicalID == 0x750) {
+   chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
-   if (physicalRev == SM750LE_REVISION_ID){
+   if (physicalRev == SM750LE_REVISION_ID)
chip = SM750LE;
-   }
-}
-else
-{
-chip = SM_UNKNOWN;
-}
+   } else {
+   chip = SM_UNKNOWN;
+   }
 
return chip;
 }
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-12 Thread Sudip Mukherjee 
On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the 
> code give no
> warnings by the checpath.pl script check.

your From: is still having [user] in your email address.
and you are doing too many things in a single patch. one patch should
do only one type of change.

> 
> 
> Signed-off-by: Ragavendra BN 
> 
this extra blank line is not necessary here.

regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-12 Thread Ragavendra BN 
This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the 
code give no
warnings by the checpath.pl script check.


Signed-off-by: Ragavendra BN 

---
 drivers/staging/sm750fb/ddk750_chip.c |   22 --
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c 
b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
physicalID = devId750;//either 0x718 or 0x750
physicalRev = revId750;
 
-if (physicalID == 0x718)
-{
-chip = SM718;
-}
-else if (physicalID == 0x750)
-{
-chip = SM750;
+   if (physicalID == 0x718) {
+   chip = SM718;
+   } else if (physicalID == 0x750) {
+   chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
-   if (physicalRev == SM750LE_REVISION_ID){
+   if (physicalRev == SM750LE_REVISION_ID)
chip = SM750LE;
-   }
-}
-else
-{
-chip = SM_UNKNOWN;
-}
+   } else {
+   chip = SM_UNKNOWN;
+   }
 
return chip;
 }
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-12 Thread Sudip Mukherjee 
On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN 
> 
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the 
> code give no
> warnings by the checkpath.pl script check.
> 
Signed-off-by line should come here before the ---

> ---

not at the top like you are giving.
Greg has told you once, I am telling now for the second time.

regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-12 Thread Ragavendra BN 
Signed-off-by: Ragavendra BN 

This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the 
code give no
warnings by the checkpath.pl script check.

---
 drivers/staging/sm750fb/ddk750_chip.c |   22 --
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c 
b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
physicalID = devId750;//either 0x718 or 0x750
physicalRev = revId750;
 
-if (physicalID == 0x718)
-{
-chip = SM718;
-}
-else if (physicalID == 0x750)
-{
-chip = SM750;
+   if (physicalID == 0x718) {
+   chip = SM718;
+   } else if (physicalID == 0x750) {
+   chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
-   if (physicalRev == SM750LE_REVISION_ID){
+   if (physicalRev == SM750LE_REVISION_ID)
chip = SM750LE;
-   }
-}
-else
-{
-chip = SM_UNKNOWN;
-}
+   } else {
+   chip = SM_UNKNOWN;
+   }
 
return chip;
 }
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel