Re: Re: [PATCH] staging: vc04_services: Fix checkpatch.pl warnings

[Sidong Yang]

Hi Stefan,

I'm really glad to review my commit!

I think that your suggestion that changes subject is good.

> i'm okay with the changes, but the subject is too general. We get fixes for 
> checkpach warning nearly once a week. Suggestion:
> 
> staging: vchiq_version: Use tabs for identation
> 
> In case there are more files in vc04_services affected by this particular 
> issue, you are invited to fix them, too.

It's okay to keep working about issue like this? or is there other way to work 
with others?

I'm newbie and don't know how to contribute to linux.

Thanks.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: vc04_services: Fix checkpatch.pl warnings

[Stefan Wahren]

Hi Sidong,

> Sidong Yang  hat am 14. Januar 2018 um 09:11 geschrieben:
> 
> 
> Replace spaces to tabs for indents in beginning of statements.
> 
> Signed-off-by: Sidong Yang 

i'm okay with the changes, but the subject is too general. We get fixes for 
checkpach warning nearly once a week. Suggestion:

staging: vchiq_version: Use tabs for identation

In case there are more files in vc04_services affected by this particular 
issue, you are invited to fix them, too.

Thanks
Stefan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: vc04_services: Fix checkpatch.pl warnings

[Sidong Yang]

Replace spaces to tabs for indents in beginning of statements.

Signed-off-by: Sidong Yang 
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
index 994b81798134..65b2b9966695 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
@@ -40,20 +40,20 @@ VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_date,__DATE__);
 
 const char *vchiq_get_build_hostname(void)
 {
-   return vchiq_build_hostname;
+   return vchiq_build_hostname;
 }
 
 const char *vchiq_get_build_version(void)
 {
-   return vchiq_build_version;
+   return vchiq_build_version;
 }
 
 const char *vchiq_get_build_date(void)
 {
-   return vchiq_build_date;
+   return vchiq_build_date;
 }
 
 const char *vchiq_get_build_time(void)
 {
-   return vchiq_build_time;
+   return vchiq_build_time;
 }
-- 
2.11.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel