Re: [PATCH] staging: vt6656: removed coding style errors

2017-03-23 Thread Greg KH 
On Thu, Mar 23, 2017 at 01:55:31PM +0530, Prasant Jalan wrote:
> On Thu, Mar 23, 2017 at 1:02 PM, Greg KH  wrote:
> >
> > On Wed, Mar 22, 2017 at 09:39:24PM +0530, Prasant Jalan wrote:
> > > The patch replaces spaces with tabs as required by kernel coding
> > > standards.
> > >
> > > Signed-off-by: Prasant Jalan 
> > > ---
> > >  drivers/staging/vt6656/rxtx.c | 40 
> > > ++--
> > >  1 file changed, 22 insertions(+), 18 deletions(-)
> >
> > As this seems to be identical to the previous patch you sent, and I
> > don't see a difference in the changelog comments, I'm dropping it from
> > my queue.  Please note that all pending patches from you have been
> > dropped, please resend all of them that still apply.
> >
> 
> Hi Greg,
> 
> I'm sorry that I sent a bad patch again and thanks so much for your comments.
> 
> Should I be sending the patch with more verbose commit message?

That's not what I asked for at all, please go read my prior emails to
you :(

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: vt6656: removed coding style errors

2017-03-23 Thread Prasant Jalan 
On Thu, Mar 23, 2017 at 1:02 PM, Greg KH  wrote:
>
> On Wed, Mar 22, 2017 at 09:39:24PM +0530, Prasant Jalan wrote:
> > The patch replaces spaces with tabs as required by kernel coding
> > standards.
> >
> > Signed-off-by: Prasant Jalan 
> > ---
> >  drivers/staging/vt6656/rxtx.c | 40 ++--
> >  1 file changed, 22 insertions(+), 18 deletions(-)
>
> As this seems to be identical to the previous patch you sent, and I
> don't see a difference in the changelog comments, I'm dropping it from
> my queue.  Please note that all pending patches from you have been
> dropped, please resend all of them that still apply.
>

Hi Greg,

I'm sorry that I sent a bad patch again and thanks so much for your comments.

Should I be sending the patch with more verbose commit message?


Regards, Prasant
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: vt6656: removed coding style errors

2017-03-23 Thread Greg KH 
On Wed, Mar 22, 2017 at 09:39:24PM +0530, Prasant Jalan wrote:
> The patch replaces spaces with tabs as required by kernel coding
> standards.
> 
> Signed-off-by: Prasant Jalan 
> ---
>  drivers/staging/vt6656/rxtx.c | 40 ++--
>  1 file changed, 22 insertions(+), 18 deletions(-)

As this seems to be identical to the previous patch you sent, and I
don't see a difference in the changelog comments, I'm dropping it from
my queue.  Please note that all pending patches from you have been
dropped, please resend all of them that still apply.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: vt6656: removed coding style errors

2017-03-22 Thread Prasant Jalan 
The patch replaces spaces with tabs as required by kernel coding
standards.

Signed-off-by: Prasant Jalan 
---
 drivers/staging/vt6656/rxtx.c | 40 ++--
 1 file changed, 22 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 1835cd1..0f89d4f 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, 
u16 rate)
 }
 
 static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
-   u32 frame_length, u16 rate, int need_ack)
+   u32 frame_length, u16 rate, int need_ack)
 {
u32 data_time, ack_time;
 
@@ -123,10 +123,12 @@ static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 
pkt_type,
 
if (pkt_type == PK_TYPE_11B)
ack_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
- 14, 
(u16)priv->top_cck_basic_rate);
+   14,
+   (u16)priv->top_cck_basic_rate);
else
ack_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
- 14, 
(u16)priv->top_ofdm_basic_rate);
+   14,
+   (u16)priv->top_ofdm_basic_rate);
 
if (need_ack)
return data_time + priv->sifs + ack_time;
@@ -135,14 +137,15 @@ static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 
pkt_type,
 }
 
 static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type,
-u32 frame_length, u16 rate, int need_ack)
+   u32 frame_length, u16 rate, int need_ack)
 {
return cpu_to_le16((u16)vnt_get_rsvtime(priv, pkt_type,
frame_length, rate, need_ack));
 }
 
 static __le16 vnt_get_rtscts_rsvtime_le(struct vnt_private *priv,
-u8 rsv_type, u8 pkt_type, u32 
frame_length, u16 current_rate)
+   u8 rsv_type, u8 pkt_type,
+   u32 frame_length, u16 current_rate)
 {
u32 rrv_time, rts_time, cts_time, ack_time, data_time;
 
@@ -160,19 +163,19 @@ static __le16 vnt_get_rtscts_rsvtime_le(struct 
vnt_private *priv,
rts_time = vnt_get_frame_time(priv->preamble_type,
pkt_type, 20, priv->top_cck_basic_rate);
cts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
- 14, priv->top_cck_basic_rate);
+   14, priv->top_cck_basic_rate);
ack_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
- 14, priv->top_ofdm_basic_rate);
+   14, priv->top_ofdm_basic_rate);
} else if (rsv_type == 2) {
rts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
- 20, priv->top_ofdm_basic_rate);
+   20, priv->top_ofdm_basic_rate);
cts_time = ack_time = vnt_get_frame_time(priv->preamble_type,
pkt_type, 14, priv->top_ofdm_basic_rate);
} else if (rsv_type == 3) {
cts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
- 14, priv->top_cck_basic_rate);
+   14, priv->top_cck_basic_rate);
ack_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
- 14, priv->top_ofdm_basic_rate);
+   14, priv->top_ofdm_basic_rate);
 
rrv_time = cts_time + ack_time + data_time + 2 * priv->sifs;
 
@@ -227,7 +230,8 @@ static __le16 vnt_get_rtscts_duration_le(struct 
vnt_usb_send_context *context,
case RTSDUR_AA_F0:
case RTSDUR_AA_F1:
cts_time = vnt_get_frame_time(priv->preamble_type,
- pkt_type, 14, 
priv->top_ofdm_basic_rate);
+   pkt_type, 14,
+   priv->top_ofdm_basic_rate);
dur_time = cts_time + 2 * priv->sifs +
vnt_get_rsvtime(priv, pkt_type,
frame_length, rate, need_ack);
@@ -410,7 +414,7 @@ static u16 vnt_rxtx_rts_g_head(struct vnt_usb_send_context 
*tx_context,
u16 current_rate = tx_context->tx_rate;
 
vnt_get_phy_field(priv, rts_frame_len, priv->top_cck_basic_rate,
- PK_TYPE_11B, &buf->b);
+