Re: [PATCH] staging:rtl8188eu:core Fix Avoid CamelCase

2017-08-24 Thread Dan Carpenter
On Thu, Aug 24, 2017 at 02:58:06PM +0530, Janani Sankara Babu wrote:
> This patch is created to solve the CamelCase issue. The members 'IEs' and
> 'IELength' of struct wlan_bssid_ex are being modified to 'ies' and 
> 'ie_length' to solve the issue. And all the places where these variables
> are referenced inside the rtl8188eu driver are also changed.
> 
> Signed-off-by: Janani Sankara Babu 
> ---
>  drivers/staging/rtl8188eu/core/rtw_ap.c |  89 +++--
>  drivers/staging/rtl8188eu/core/rtw_cmd.c|  26 +++---
>  drivers/staging/rtl8188eu/core/rtw_ieee80211.c  |  20 ++---
>  drivers/staging/rtl8188eu/core/rtw_ioctl_set.c  |   2 +-
>  drivers/staging/rtl8188eu/core/rtw_mlme.c   |  66 
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c   | 100 
> 
>  drivers/staging/rtl8188eu/core/rtw_wlan_util.c  |  34 
>  drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c|  16 ++--
>  drivers/staging/rtl8188eu/include/wlan_bssdef.h |  10 +--
>  drivers/staging/rtl8188eu/os_dep/ioctl_linux.c  |  12 +--
>  10 files changed, 189 insertions(+), 186 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c 
> b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index 647a922..2cd20f1 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -69,19 +69,22 @@ static void update_BCNTIM(struct adapter *padapter)
>   struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
>   struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
>   struct wlan_bssid_ex *pnetwork_mlmeext = &pmlmeinfo->network;
> - unsigned char *pie = pnetwork_mlmeext->IEs;
> + //unsigned char *pie = pnetwork_mlmeext->ies;
> + unsigned char *pie = pnetwork_mlmeext->ies;

Why did you comment this out?  Really "ie" is a better name that "ies".
The "s" was supposed to make it plural but that's not obvious in the
new code.

regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH] staging:rtl8188eu:core Fix Avoid CamelCase

2017-08-24 Thread Janani Sankara Babu
This patch is created to solve the CamelCase issue. The members 'IEs' and
'IELength' of struct wlan_bssid_ex are being modified to 'ies' and 
'ie_length' to solve the issue. And all the places where these variables
are referenced inside the rtl8188eu driver are also changed.

Signed-off-by: Janani Sankara Babu 
---
 drivers/staging/rtl8188eu/core/rtw_ap.c |  89 +++--
 drivers/staging/rtl8188eu/core/rtw_cmd.c|  26 +++---
 drivers/staging/rtl8188eu/core/rtw_ieee80211.c  |  20 ++---
 drivers/staging/rtl8188eu/core/rtw_ioctl_set.c  |   2 +-
 drivers/staging/rtl8188eu/core/rtw_mlme.c   |  66 
 drivers/staging/rtl8188eu/core/rtw_mlme_ext.c   | 100 
 drivers/staging/rtl8188eu/core/rtw_wlan_util.c  |  34 
 drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c|  16 ++--
 drivers/staging/rtl8188eu/include/wlan_bssdef.h |  10 +--
 drivers/staging/rtl8188eu/os_dep/ioctl_linux.c  |  12 +--
 10 files changed, 189 insertions(+), 186 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c 
b/drivers/staging/rtl8188eu/core/rtw_ap.c
index 647a922..2cd20f1 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -69,19 +69,22 @@ static void update_BCNTIM(struct adapter *padapter)
struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
struct wlan_bssid_ex *pnetwork_mlmeext = &pmlmeinfo->network;
-   unsigned char *pie = pnetwork_mlmeext->IEs;
+   //unsigned char *pie = pnetwork_mlmeext->ies;
+   unsigned char *pie = pnetwork_mlmeext->ies;
u8 *p, *dst_ie, *premainder_ie = NULL;
u8 *pbackup_remainder_ie = NULL;
uint offset, tmp_len, tim_ielen, tim_ie_offset, remainder_ielen;
 
/* update TIM IE */
+   //p = rtw_get_ie(pie + _FIXED_IE_LENGTH_, _TIM_IE_, &tim_ielen,
+   //pnetwork_mlmeext->ie_length - _FIXED_IE_LENGTH_);
p = rtw_get_ie(pie + _FIXED_IE_LENGTH_, _TIM_IE_, &tim_ielen,
-   pnetwork_mlmeext->IELength - _FIXED_IE_LENGTH_);
+   pnetwork_mlmeext->ie_length - _FIXED_IE_LENGTH_);
if (p && tim_ielen > 0) {
tim_ielen += 2;
premainder_ie = p + tim_ielen;
tim_ie_offset = (int)(p - pie);
-   remainder_ielen = pnetwork_mlmeext->IELength -
+   remainder_ielen = pnetwork_mlmeext->ie_length -
tim_ie_offset - tim_ielen;
/* append TIM IE from dst_ie offset */
dst_ie = p;
@@ -94,7 +97,7 @@ static void update_BCNTIM(struct adapter *padapter)
 
/*  get supported rates len */
p = rtw_get_ie(pie + _BEACON_IE_OFFSET_, _SUPPORTEDRATES_IE_,
-  &tmp_len, (pnetwork_mlmeext->IELength -
+  &tmp_len, (pnetwork_mlmeext->ie_length -
  _BEACON_IE_OFFSET_));
if (p)
offset += tmp_len+2;
@@ -104,7 +107,7 @@ static void update_BCNTIM(struct adapter *padapter)
 
premainder_ie = pie + offset;
 
-   remainder_ielen = pnetwork_mlmeext->IELength -
+   remainder_ielen = pnetwork_mlmeext->ie_length -
offset - tim_ielen;
 
/* append TIM IE from offset */
@@ -119,7 +122,7 @@ static void update_BCNTIM(struct adapter *padapter)
}
*dst_ie++ = _TIM_IE_;
 
-   if ((pstapriv->tim_bitmap&0xff00) && (pstapriv->tim_bitmap&0x00fc))
+   if ((pstapriv->tim_bitmap & 0xff00) && (pstapriv->tim_bitmap & 0x00fc))
tim_ielen = 5;
else
tim_ielen = 4;
@@ -129,7 +132,7 @@ static void update_BCNTIM(struct adapter *padapter)
*dst_ie++ = 0;/* DTIM count */
*dst_ie++ = 1;/* DTIM period */
 
-   if (pstapriv->tim_bitmap&BIT(0))/* for bc/mc frames */
+   if (pstapriv->tim_bitmap & BIT(0))/* for bc/mc frames */
*dst_ie++ = BIT(0);/* bitmap ctrl */
else
*dst_ie++ = 0;
@@ -148,7 +151,7 @@ static void update_BCNTIM(struct adapter *padapter)
kfree(pbackup_remainder_ie);
}
offset =  (uint)(dst_ie - pie);
-   pnetwork_mlmeext->IELength = offset + remainder_ielen;
+   pnetwork_mlmeext->ie_length = offset + remainder_ielen;
 
set_tx_beacon_cmd(padapter);
 }
@@ -158,13 +161,13 @@ void rtw_add_bcn_ie(struct adapter *padapter, struct 
wlan_bssid_ex *pnetwork,
 {
struct ndis_802_11_var_ie *pIE;
u8 bmatch = false;
-   u8 *pie = pnetwork->IEs;
+   u8 *pie = pnetwork->ies;
u8 *p = NULL, *dst_ie = NULL, *premainder_ie = NULL;
u8 *pbackup_remainder_ie = NULL;
u32 i, offset, ielen = 0, ie_offset, remainder_ielen = 0;
 
-   for (i = sizeof(struct ndi