Re: [PATCH] staging:wlan-ng Fix Multiple line dereference

2017-08-20 Thread Greg KH 
On Fri, Aug 18, 2017 at 06:16:39PM +0530, Janani S wrote:
> This patch fixes multiple line dereference warning reported
> by checkpatch script.
> 
> Signed-off-by: Janani S 
> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 12 
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c 
> b/drivers/staging/wlan-ng/hfa384x_usb.c
> index ee5fa86..2746e13 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct 
> hfa384x *hw,
>   kfree(ctlx);
>   } else if (mode == DOWAIT) {
>   struct usbctlx_cmd_completor completor;
> + struct usbctlx_completor *cmplt;
>  
> - result =
> - hfa384x_usbctlx_complete_sync(hw, ctlx,
> -   init_cmd_completor(,
> -  >
> -  inbuf.
> -  cmdresp,
> -  >
> -  result));
> + cmplt = init_cmd_completor(, >inbuf.cmdresp,
> +>result);
> + result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
>   }
>  
>  done:

Someone else sent this same patch right before you did, sorry.

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging:wlan-ng Fix Multiple line dereference

2017-08-18 Thread Janani S 
This patch fixes multiple line dereference warning reported
by checkpatch script.

Signed-off-by: Janani S 
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c 
b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2746e13 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x 
*hw,
kfree(ctlx);
} else if (mode == DOWAIT) {
struct usbctlx_cmd_completor completor;
+   struct usbctlx_completor *cmplt;
 
-   result =
-   hfa384x_usbctlx_complete_sync(hw, ctlx,
- init_cmd_completor(,
->
-inbuf.
-cmdresp,
->
-result));
+   cmplt = init_cmd_completor(, >inbuf.cmdresp,
+  >result);
+   result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
}
 
 done:
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] [PATCH] staging:wlan-ng Fix Multiple line dereference

2017-08-18 Thread Janani S 
This patch fixes multiple line dereference warning reported
by checkpatch script.

Signed-off-by: Janani S 
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c 
b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2746e13 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x 
*hw,
kfree(ctlx);
} else if (mode == DOWAIT) {
struct usbctlx_cmd_completor completor;
+   struct usbctlx_completor *cmplt;
 
-   result =
-   hfa384x_usbctlx_complete_sync(hw, ctlx,
- init_cmd_completor(,
->
-inbuf.
-cmdresp,
->
-result));
+   cmplt = init_cmd_completor(, >inbuf.cmdresp,
+  >result);
+   result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
}
 
 done:
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging:wlan-ng Fix multiple line dereference

2017-08-17 Thread Greg KH 
On Wed, Aug 02, 2017 at 05:54:49PM +0530, janani-sankarababu wrote:
> This patch fixes multiple line dereference Warning
> reported by checkpatch script. This is done to
> simplify the code and make it more readable.
> 
> Signed-off-by: Janani Sankara Babu 

Same "From:" line problem again :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging:wlan-ng Fix multiple line dereference

2017-08-02 Thread janani-sankarababu 
This patch fixes multiple line dereference Warning
reported by checkpatch script. This is done to
simplify the code and make it more readable.

Signed-off-by: Janani Sankara Babu 
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c 
b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2746e13 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x 
*hw,
kfree(ctlx);
} else if (mode == DOWAIT) {
struct usbctlx_cmd_completor completor;
+   struct usbctlx_completor *cmplt;
 
-   result =
-   hfa384x_usbctlx_complete_sync(hw, ctlx,
- init_cmd_completor(,
->
-inbuf.
-cmdresp,
->
-result));
+   cmplt = init_cmd_completor(, >inbuf.cmdresp,
+  >result);
+   result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
}
 
 done:
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel