Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes
On Fri, Sep 04, 2015 at 09:58:10AM -0400, Ben Romer wrote: > On 09/04/2015 09:41 AM, Sudip Mukherjee wrote: > >Any new developments can only go in rc1 release. 4.3 merge window is > >already open so new developments cannot be added to 4.3-rc1. New codes > >has to go to 4.4-rc1. > >4.3-rc2 - 4.3-rc7 (or 8) can only have fixes. > I don't think any of the patches in this set specifically were > adding new features, though I suppose the patches to remove > list_all, devnum_pool, and devnum could be seen as not being *bug* > fixes. It depends on if eliminating redundant code counts or not. Eliminating redundant codes is considered as development and not bug fix and should go to 4.4-rc1. The fixes like the one 0 day bot pointed out should be for 4.3. regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes
On Fri, Sep 04, 2015 at 09:58:10AM -0400, Ben Romer wrote: > On 09/04/2015 09:41 AM, Sudip Mukherjee wrote: > >Any new developments can only go in rc1 release. 4.3 merge window is > >already open so new developments cannot be added to 4.3-rc1. New codes > >has to go to 4.4-rc1. > >4.3-rc2 - 4.3-rc7 (or 8) can only have fixes. > I don't think any of the patches in this set specifically were adding new > features, though I suppose the patches to remove list_all, devnum_pool, and > devnum could be seen as not being *bug* fixes. It depends on if eliminating > redundant code counts or not. It does not. That's not a "bug" or "regression" that is needing to be fixed as it is causing a problem for people. It's a "cleanup" and that type of patch can only be added in -rc1. hope this helps, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes
On 09/04/2015 09:41 AM, Sudip Mukherjee wrote: Any new developments can only go in rc1 release. 4.3 merge window is already open so new developments cannot be added to 4.3-rc1. New codes has to go to 4.4-rc1. 4.3-rc2 - 4.3-rc7 (or 8) can only have fixes. I don't think any of the patches in this set specifically were adding new features, though I suppose the patches to remove list_all, devnum_pool, and devnum could be seen as not being *bug* fixes. It depends on if eliminating redundant code counts or not. -- Ben ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes
On Fri, Sep 04, 2015 at 09:20:23AM -0400, Ben Romer wrote: > On 09/02/2015 08:40 PM, Greg KH wrote: > >These aren't all "fixes" so I can't just add them to the 4.3-final > >release, but some look like they should go there. So please split this > >into two different series and resend, one for 4.3-final and one for > >4.4-rc1. > > Greg, > > We've been running and testing with all of these patches for a week > or two now, and my team and I all feel that the entire set is safe > to include in the new release. I'm not sure what your criteria are > for inclusion in 4.3, so if you could let me know what those are, > I'd be happy to split them up and send two sets, of course with the > per-patch comments addressed. :) Any new developments can only go in rc1 release. 4.3 merge window is already open so new developments cannot be added to 4.3-rc1. New codes has to go to 4.4-rc1. 4.3-rc2 - 4.3-rc7 (or 8) can only have fixes. Greg please correct me if I am wrong. I should not have replied here but this is a good opportunity to test my understanding of the release cycle. :) regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes
On 09/02/2015 08:40 PM, Greg KH wrote: These aren't all "fixes" so I can't just add them to the 4.3-final release, but some look like they should go there. So please split this into two different series and resend, one for 4.3-final and one for 4.4-rc1. Greg, We've been running and testing with all of these patches for a week or two now, and my team and I all feel that the entire set is safe to include in the new release. I'm not sure what your criteria are for inclusion in 4.3, so if you could let me know what those are, I'd be happy to split them up and send two sets, of course with the per-patch comments addressed. :) Thanks! -- Ben ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes
On Tue, Aug 18, 2015 at 03:13:55PM -0400, Benjamin Romer wrote: > This patch series addresses several issues found during review, > testing, and by the kernel test bot. These aren't all "fixes" so I can't just add them to the 4.3-final release, but some look like they should go there. So please split this into two different series and resend, one for 4.3-final and one for 4.4-rc1. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/8] staging: unisys: visornic/visorbus fixes
This patch series addresses several issues found during review, testing, and by the kernel test bot. Benjamin Romer (2): staging: unisys: stop device registration before visorbus registration staging: unisys: visornic: handle error return from device registration David Kershner (6): staging: unisys: unregister netdev when create debugfs fails staging: unisys: remove devdata->name use netdev->name staging: unisys: get rid of devnum pool and dev num staging: unisys: git rid of list of devices staging: unisys: visornic: Fix receive bytes statistics staging: unisys: visorbus: Unregister driver on error drivers/staging/unisys/visorbus/visorbus_main.c | 5 +++ drivers/staging/unisys/visornic/visornic_main.c | 60 + 2 files changed, 16 insertions(+), 49 deletions(-) -- 2.1.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
