Re: [PATCH 00/10] Fix alignment issues in staging/ccree
On Sun, Jul 16, 2017 at 12:33:16PM +0200, Simon Sandström wrote: > Hi > > On Tue, Jul 11, 2017 at 07:00:33PM +0200, Greg KH wrote: > > Not all of these applied, some did, if you could rebase the remaining > > against my staging-testing branch at the moment, and resend, that would > > be great. > > I'm not sure about the preferred procedure. Is it OK to send the > rebased patches in this mail thread, or should I send them as a > new patchset in a new mail thread? A whole new patchset would be fine, as I already took some of these. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/10] Fix alignment issues in staging/ccree
Hi On Tue, Jul 11, 2017 at 07:00:33PM +0200, Greg KH wrote: > Not all of these applied, some did, if you could rebase the remaining > against my staging-testing branch at the moment, and resend, that would > be great. I'm not sure about the preferred procedure. Is it OK to send the rebased patches in this mail thread, or should I send them as a new patchset in a new mail thread? - Simon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/10] Fix alignment issues in staging/ccree
On Sun, Jul 02, 2017 at 01:25:45AM +0200, Simon Sandström wrote: > Fixes a total of 195 alignment issues in staging/ccree reported by > checkpatch.pl. Adds a few "line over 80 characters" warnings as a > result of the realignments, but I could try to get rid of them in the > same patchset if needed. Not all of these applied, some did, if you could rebase the remaining against my staging-testing branch at the moment, and resend, that would be great. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/10] Fix alignment issues in staging/ccree
On Mon, Jul 3, 2017 at 3:28 PM, Simon Sandström wrote: > On Mon, Jul 03, 2017 at 10:19:31AM +0300, Gilad Ben-Yossef wrote: >> but for the few cases where its a complex expression that can be >> broken down like this one: >> >> WARNING: line over 80 characters >> #93: FILE: drivers/staging/ccree/ssi_buffer_mgr.c:437: >> + (AES_BLOCK_SIZE + areq_ctx->ccm_hdr_size), >> >> It would be great if you fix those. > > Do you mean to fix them by just breaking the line after the ternary > operator? Is that OK according to the code style rules? Yes, it is. > > If not, then the two warnings in ssi_aead_handle_config_buf can be > fixed by simply having a local variable: > > const unsigned int buflen = AES_BLOCK_SIZE + areq_ctx->ccm_hdr_size; > > but I'm not sure if the same can be done in > ssi_buffer_mgr_map_hash_request_update for (update_data_len - *curr_buf_cnt) > as it's not always the case that update_data_len is greater than > *curr_buf_cnt. Even if it's safe to always calculate it I'm not > entierly sure what to call the variable. No need not. I simply meant to break this: (update_data_len - *curr_buf_cnt) To this: (update_data_len - *curr_buf_cnt) Assuming it made sense. > Other then those two functions I don't think that there are any more > lines that can be fixed without renaming functions / variables or > by rewriting them to decrease the indentation depth, as you wrote. No, not in this patch. Thanks! Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/10] Fix alignment issues in staging/ccree
On Mon, Jul 03, 2017 at 10:19:31AM +0300, Gilad Ben-Yossef wrote: > but for the few cases where its a complex expression that can be > broken down like this one: > > WARNING: line over 80 characters > #93: FILE: drivers/staging/ccree/ssi_buffer_mgr.c:437: > + (AES_BLOCK_SIZE + areq_ctx->ccm_hdr_size), > > It would be great if you fix those. Do you mean to fix them by just breaking the line after the ternary operator? Is that OK according to the code style rules? If not, then the two warnings in ssi_aead_handle_config_buf can be fixed by simply having a local variable: const unsigned int buflen = AES_BLOCK_SIZE + areq_ctx->ccm_hdr_size; but I'm not sure if the same can be done in ssi_buffer_mgr_map_hash_request_update for (update_data_len - *curr_buf_cnt) as it's not always the case that update_data_len is greater than *curr_buf_cnt. Even if it's safe to always calculate it I'm not entierly sure what to call the variable. Other then those two functions I don't think that there are any more lines that can be fixed without renaming functions / variables or by rewriting them to decrease the indentation depth, as you wrote. -- Simon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/10] Fix alignment issues in staging/ccree
Hi, On Sun, Jul 2, 2017 at 2:25 AM, Simon Sandström wrote: > Fixes a total of 195 alignment issues in staging/ccree reported by > checkpatch.pl. Adds a few "line over 80 characters" warnings as a > result of the realignments, but I could try to get rid of them in the > same patchset if needed. For the large majority of warnings there is nothing you can due ti the indentation depth, but for the few cases where its a complex expression that can be broken down like this one: WARNING: line over 80 characters #93: FILE: drivers/staging/ccree/ssi_buffer_mgr.c:437: + (AES_BLOCK_SIZE + areq_ctx->ccm_hdr_size), It would be great if you fix those. Otherwise it looks good to me. Thanks for doing it! Gilad > > -- Simon > > --- > > Simon Sandström (10): > staging: ccree: Fix alignment issues in ssi_aead.c > staging: ccree: Fix alignment issues in ssi_buffer_mgr.c > staging: ccree: Fix alignment issues in ssi_cipher.c > staging: ccree: Fix alignment issues in ssi_driver.c > staging: ccree: Fix alignment issues in ssi_fips_local.c > staging: ccree: Fix alignment issues in ssi_hash.c > staging: ccree: Fix alignment issues in ssi_ivgen.c > staging: ccree: Fix alignment issues in ssi_request_mgr.c > staging: ccree: Fix alignment issues in ssi_sram_mgr.c > staging: ccree: Fix alignment issues in ssi_sysfs.c > > drivers/staging/ccree/ssi_aead.c| 67 > drivers/staging/ccree/ssi_buffer_mgr.c | 295 > ++-- > drivers/staging/ccree/ssi_cipher.c | 75 > drivers/staging/ccree/ssi_driver.c | 40 ++--- > drivers/staging/ccree/ssi_fips_local.c | 3 +- > drivers/staging/ccree/ssi_hash.c| 116 +++-- > drivers/staging/ccree/ssi_ivgen.c | 3 +- > drivers/staging/ccree/ssi_request_mgr.c | 42 +++-- > drivers/staging/ccree/ssi_sram_mgr.c| 6 +- > drivers/staging/ccree/ssi_sysfs.c | 59 --- > 10 files changed, 372 insertions(+), 334 deletions(-) > > -- > 2.11.0 > -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 00/10] Fix alignment issues in staging/ccree
Fixes a total of 195 alignment issues in staging/ccree reported by checkpatch.pl. Adds a few "line over 80 characters" warnings as a result of the realignments, but I could try to get rid of them in the same patchset if needed. -- Simon --- Simon Sandström (10): staging: ccree: Fix alignment issues in ssi_aead.c staging: ccree: Fix alignment issues in ssi_buffer_mgr.c staging: ccree: Fix alignment issues in ssi_cipher.c staging: ccree: Fix alignment issues in ssi_driver.c staging: ccree: Fix alignment issues in ssi_fips_local.c staging: ccree: Fix alignment issues in ssi_hash.c staging: ccree: Fix alignment issues in ssi_ivgen.c staging: ccree: Fix alignment issues in ssi_request_mgr.c staging: ccree: Fix alignment issues in ssi_sram_mgr.c staging: ccree: Fix alignment issues in ssi_sysfs.c drivers/staging/ccree/ssi_aead.c| 67 drivers/staging/ccree/ssi_buffer_mgr.c | 295 ++-- drivers/staging/ccree/ssi_cipher.c | 75 drivers/staging/ccree/ssi_driver.c | 40 ++--- drivers/staging/ccree/ssi_fips_local.c | 3 +- drivers/staging/ccree/ssi_hash.c| 116 +++-- drivers/staging/ccree/ssi_ivgen.c | 3 +- drivers/staging/ccree/ssi_request_mgr.c | 42 +++-- drivers/staging/ccree/ssi_sram_mgr.c| 6 +- drivers/staging/ccree/ssi_sysfs.c | 59 --- 10 files changed, 372 insertions(+), 334 deletions(-) -- 2.11.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
