Re: [PATCH 02/13] staging: r8188eu: Remove pointless alignment entry in recv_frame

2014-02-16 Thread Dan Carpenter 
On Sun, Feb 16, 2014 at 11:02:52AM +0800, Zhao, Gang wrote:
 On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote:
  This alignment entry in union recv_frame does nothing. It certainly
  dues not ensure alignment.
^
typo here.
 
I accidently sent this as a private mail before, better to resend to
the list.
 

This was already applied.  You can still understand the meaning so it's
fine.  No need to redo.  Typos in the code are more important.

It's hard to run spell checkers on patches since so much of the words
are code and not English.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 02/13] staging: r8188eu: Remove pointless alignment entry in recv_frame

2014-02-15 Thread Zhao, Gang 
On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote:
 This alignment entry in union recv_frame does nothing. It certainly
 dues not ensure alignment.
   ^
   typo here.

   I accidently sent this as a private mail before, better to resend to
   the list.


 Suggested-by: jes.soren...@redhat.com
 Signed-off-by: Larry Finger larry.fin...@lwfinger.net
 Cc: jes.soren...@redhat.com
 ---
  drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
  1 file changed, 1 deletion(-)

 diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
 b/drivers/staging/rtl8188eu/include/rtw_recv.h
 index 866c9e4..c6d7a65 100644
 --- a/drivers/staging/rtl8188eu/include/rtw_recv.h
 +++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
 @@ -292,7 +292,6 @@ struct recv_frame_hdr {
  union recv_frame {
   union {
   struct recv_frame_hdr hdr;
 - uint mem[RECVFRAME_HDR_ALIGN2];
   } u;
  };
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 02/13] staging: r8188eu: Remove pointless alignment entry in recv_frame

2014-02-14 Thread Larry Finger 
This alignment entry in union recv_frame does nothing. It certainly
dues not ensure alignment.

Suggested-by: jes.soren...@redhat.com
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
Cc: jes.soren...@redhat.com
---
 drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 866c9e4..c6d7a65 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -292,7 +292,6 @@ struct recv_frame_hdr {
 union recv_frame {
union {
struct recv_frame_hdr hdr;
-   uint mem[RECVFRAME_HDR_ALIGN2];
} u;
 };
 
-- 
1.8.4.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel