Re: [PATCH 02/16] staging: gasket: core: remove debug log that could crash

2018-08-10 Thread Rob Springer
Reviewed-by: Rob Springer 

On Fri, Aug 10, 2018 at 9:56 AM Rob Springer  wrote:
>
> Revewed-by: Rob Springer 
>
> On Thu, Aug 9, 2018 at 8:21 PM Todd Poynor  wrote:
>>
>> From: Todd Poynor 
>>
>> A debug log in gasket_alloc_dev() is issued regardless of whether the
>> device pointer used returned success or error.  The log isn't that
>> useful anyway, remove it.
>>
>> Signed-off-by: Todd Poynor 
>> ---
>>  drivers/staging/gasket/gasket_core.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/gasket/gasket_core.c 
>> b/drivers/staging/gasket/gasket_core.c
>> index d12ab560411f7..37d14e30ffa21 100644
>> --- a/drivers/staging/gasket/gasket_core.c
>> +++ b/drivers/staging/gasket/gasket_core.c
>> @@ -234,8 +234,6 @@ static int gasket_alloc_dev(struct gasket_internal_desc 
>> *internal_desc,
>> dev_info->device = device_create(internal_desc->class, parent,
>> dev_info->devt, gasket_dev, dev_info->name);
>>
>> -   dev_dbg(dev_info->device, "Gasket device allocated.\n");
>> -
>> /* cdev has not yet been added; cdev_added is 0 */
>> dev_info->gasket_dev_ptr = gasket_dev;
>> /* ownership is all 0, indicating no owner or opens. */
>> --
>> 2.18.0.597.ga71716f1ad-goog
>>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH 02/16] staging: gasket: core: remove debug log that could crash

2018-08-09 Thread Todd Poynor
From: Todd Poynor 

A debug log in gasket_alloc_dev() is issued regardless of whether the
device pointer used returned success or error.  The log isn't that
useful anyway, remove it.

Signed-off-by: Todd Poynor 
---
 drivers/staging/gasket/gasket_core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/gasket/gasket_core.c 
b/drivers/staging/gasket/gasket_core.c
index d12ab560411f7..37d14e30ffa21 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -234,8 +234,6 @@ static int gasket_alloc_dev(struct gasket_internal_desc 
*internal_desc,
dev_info->device = device_create(internal_desc->class, parent,
dev_info->devt, gasket_dev, dev_info->name);
 
-   dev_dbg(dev_info->device, "Gasket device allocated.\n");
-
/* cdev has not yet been added; cdev_added is 0 */
dev_info->gasket_dev_ptr = gasket_dev;
/* ownership is all 0, indicating no owner or opens. */
-- 
2.18.0.597.ga71716f1ad-goog

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel