[PATCH 06/15] staging: unisys: fix spacing in visorchipset.c

2015-11-30 Thread Benjamin Romer 
From: Erik Arfvidson 

This patch fixes the following checkpatch warning:
spaces preferred around that ‘*’ or ‘|’

Signed-off-by: Erik Arfvidson 
Signed-off-by: Benjamin Romer 
---
 drivers/staging/unisys/visorbus/visorchipset.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c 
b/drivers/staging/unisys/visorbus/visorchipset.c
index fb56258..8347ccd 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -43,11 +43,10 @@
 #define POLLJIFFIES_CONTROLVMCHANNEL_FAST   1
 #define POLLJIFFIES_CONTROLVMCHANNEL_SLOW 100
 
-#define MAX_CONTROLVM_PAYLOAD_BYTES (1024*128)
+#define MAX_CONTROLVM_PAYLOAD_BYTES (1024 * 128)
 
 #define VISORCHIPSET_MMAP_CONTROLCHANOFFSET0x
 
-
 #define UNISYS_SPAR_LEAF_ID 0x4000
 
 /* The s-Par leaf ID returns "UnisysSpar64" encoded across ebx, ecx, edx */
@@ -379,7 +378,7 @@ parser_init_byte_stream(u64 addr, u32 bytes, bool local, 
bool *retry)
rc = NULL;
goto cleanup;
}
-   ctx = kzalloc(allocbytes, GFP_KERNEL|__GFP_NORETRY);
+   ctx = kzalloc(allocbytes, GFP_KERNEL | __GFP_NORETRY);
if (!ctx) {
if (retry)
*retry = true;
@@ -522,8 +521,8 @@ parser_string_get(struct parser_context *ctx)
}
if (value_length < 0)   /* '\0' was not included in the length */
value_length = nscan;
-   value = kmalloc(value_length + 1, GFP_KERNEL|__GFP_NORETRY);
-   if (value == NULL)
+   value = kmalloc(value_length + 1, GFP_KERNEL | __GFP_NORETRY);
+   if (!value)
return NULL;
if (value_length > 0)
memcpy(value, pscan, value_length);
-- 
2.5.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 06/15] staging: unisys: fix spacing in visorchipset.c

2015-11-30 Thread Sudip Mukherjee 
On Mon, Nov 30, 2015 at 02:46:06PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson 
> 
> This patch fixes the following checkpatch warning:
> spaces preferred around that ‘*’ or ‘|’
> 
> Signed-off-by: Erik Arfvidson 
> Signed-off-by: Benjamin Romer 
> ---
>  drivers/staging/unisys/visorbus/visorchipset.c | 9 -
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 

> @@ -522,8 +521,8 @@ parser_string_get(struct parser_context *ctx)
>   }
>   if (value_length < 0)   /* '\0' was not included in the length */
>   value_length = nscan;
> - value = kmalloc(value_length + 1, GFP_KERNEL|__GFP_NORETRY);
> - if (value == NULL)
> + value = kmalloc(value_length + 1, GFP_KERNEL | __GFP_NORETRY);
> + if (!value)

This should have been there in your 7/15 patch.

regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel