Re: [PATCH 07/13] staging:rtl8192u: Remove DelayBA, PSMP and Rsvd1 - Style

2018-09-28 Thread Dan Carpenter
Yeah...  :(  All the remaining patches are similar and risky.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH 07/13] staging:rtl8192u: Remove DelayBA, PSMP and Rsvd1 - Style

2018-09-26 Thread John Whitmore
Remove the unused member variables DelayBA, PSMP and Rsvd1.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore 
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 3 ---
 drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 --
 2 files changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h 
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
index 52cce0dcf9a5..09596a7a6814 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
@@ -43,11 +43,8 @@ struct ht_capability_ele {
u8  MimoPwrSave:2;
u8  ShortGI20Mhz:1;
u8  ShortGI40Mhz:1;
-   u8  DelayBA:1;
u8  MaxAMSDUSize:1;
u8  DssCCk:1;
-   u8  PSMP:1;
-   u8  Rsvd1:1;
u8  LSigTxopProtect:1;
 
//MAC HT parameters info
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c 
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index b4220df1f833..94cedf5f1163 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
@@ -503,10 +503,8 @@ void HTConstructCapabilityElement(struct ieee80211_device 
*ieee, u8 *posHTCap, u
pCapELE->ShortGI40Mhz   = 1; // We can receive Short GI!!
//DbgPrint("TX HT cap/info ele BW=%d SG20=%d SG40=%d\n\r",
//pCapELE->ChlWidth, pCapELE->ShortGI20Mhz, pCapELE->ShortGI40Mhz);
-   pCapELE->DelayBA= 0;// Do not support now!!
pCapELE->MaxAMSDUSize   = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 
: 0;
pCapELE->DssCCk = ((pHT->bRegBW40MHz) ? 
(pHT->bRegSuppCCK ? 1 : 0) : 0);
-   pCapELE->PSMP   = 0; // Do not support now!!
pCapELE->LSigTxopProtect= 0; // Do not support now!!
 
/*
-- 
2.18.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel