[PATCH 07/14] staging: unisys: Fix guestlinuxdebug.h comments

2015-11-17 Thread Benjamin Romer
From: Erik Arfvidson 

This patch simply cleans up all checkpatch warnings and fixes
styling

Signed-off-by: Erik Arfvidson 
Signed-off-by: Benjamin Romer 
---
 drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++--
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/unisys/include/guestlinuxdebug.h 
b/drivers/staging/unisys/include/guestlinuxdebug.h
index 82ee565..c1d515f 100644
--- a/drivers/staging/unisys/include/guestlinuxdebug.h
+++ b/drivers/staging/unisys/include/guestlinuxdebug.h
@@ -17,9 +17,10 @@
 #define __GUESTLINUXDEBUG_H__
 
 /*
-* This file contains supporting interface for "vmcallinterface.h", particularly
-* regarding adding additional structure and functionality to linux
-* ISSUE_IO_VMCALL_POSTCODE_SEVERITY */
+ * This file contains supporting interface for "vmcallinterface.h", 
particularly
+ * regarding adding additional structure and functionality to linux
+ * ISSUE_IO_VMCALL_POSTCODE_SEVERITY
+ */
 
 /*** INFO ON ISSUE_POSTCODE_LINUX() BELOW ***/
 enum driver_pc {   /* POSTCODE driver identifier tuples */
@@ -133,9 +134,9 @@ enum event_pc { /* POSTCODE event 
identifier tuples */
 
 #define POSTCODE_SEVERITY_ERR DIAG_SEVERITY_ERR
 #define POSTCODE_SEVERITY_WARNING DIAG_SEVERITY_WARNING
-#define POSTCODE_SEVERITY_INFO DIAG_SEVERITY_PRINT /* TODO-> Info currently
-* doesn't show, so we
-* set info=warning */
+#define POSTCODE_SEVERITY_INFO DIAG_SEVERITY_PRINT
+/* TODO-> Info currently doesn't show, so we set info=warning */
+
 /* example call of POSTCODE_LINUX_2(VISOR_CHIPSET_PC, POSTCODE_SEVERITY_ERR);
  * Please also note that the resulting postcode is in hex, so if you are
  * searching for the __LINE__ number, convert it first to decimal.  The line
-- 
2.5.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH 07/14] staging: unisys: Fix guestlinuxdebug.h comments

2015-11-17 Thread Greg KH
On Tue, Nov 17, 2015 at 01:34:54PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson 
> 
> This patch simply cleans up all checkpatch warnings and fixes
> styling
> 
> Signed-off-by: Erik Arfvidson 
> Signed-off-by: Benjamin Romer 
> ---
>  drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++--
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/unisys/include/guestlinuxdebug.h 
> b/drivers/staging/unisys/include/guestlinuxdebug.h
> index 82ee565..c1d515f 100644
> --- a/drivers/staging/unisys/include/guestlinuxdebug.h
> +++ b/drivers/staging/unisys/include/guestlinuxdebug.h
> @@ -17,9 +17,10 @@
>  #define __GUESTLINUXDEBUG_H__
>  
>  /*
> -* This file contains supporting interface for "vmcallinterface.h", 
> particularly
> -* regarding adding additional structure and functionality to linux
> -* ISSUE_IO_VMCALL_POSTCODE_SEVERITY */
> + * This file contains supporting interface for "vmcallinterface.h", 
> particularly
> + * regarding adding additional structure and functionality to linux
> + * ISSUE_IO_VMCALL_POSTCODE_SEVERITY
> + */
>  
>  /*** INFO ON ISSUE_POSTCODE_LINUX() BELOW ***/
>  enum driver_pc { /* POSTCODE driver identifier tuples */
> @@ -133,9 +134,9 @@ enum event_pc {   /* POSTCODE event 
> identifier tuples */
>  
>  #define POSTCODE_SEVERITY_ERR DIAG_SEVERITY_ERR
>  #define POSTCODE_SEVERITY_WARNING DIAG_SEVERITY_WARNING
> -#define POSTCODE_SEVERITY_INFO DIAG_SEVERITY_PRINT   /* TODO-> Info currently
> -  * doesn't show, so we
> -  * set info=warning */
> +#define POSTCODE_SEVERITY_INFO DIAG_SEVERITY_PRINT
> +/* TODO-> Info currently doesn't show, so we set info=warning */

Comment should go on top of the #define, not below it.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel