Re: [PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

2014-05-26 Thread Dan Carpenter 
On Mon, May 26, 2014 at 11:47:51AM +0200, Matthias Beyer wrote:
> On 26-05-2014 11:38:25, Dan Carpenter wrote:
> > On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote:
> > > Signed-off-by: Matthias Beyer 
> > > ---
> > >  drivers/staging/bcm/CmHost.c | 14 ++
> > >  1 file changed, 10 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
> > > index 3f29dea..9fea9a8 100644
> > > --- a/drivers/staging/bcm/CmHost.c
> > > +++ b/drivers/staging/bcm/CmHost.c
> > > @@ -1531,12 +1531,14 @@ ULONG SetUpTargetDsxBuffers(struct 
> > > bcm_mini_adapter *Adapter)
> > >   return 1;
> > >  }
> > >  
> > > -static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter 
> > > *Adapter, B_UINT16 tid)
> > > +static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter 
> > > *Adapter,
> > > + B_UINT16 tid)
> > >  {
> > >   ULONG dsx_buf;
> > >   ULONG idx, max_try;
> > >  
> > > - if ((Adapter->ulTotalTargetBuffersAvailable == 0) || 
> > > (Adapter->ulFreeTargetBufferCnt == 0)) {
> > > + if ((Adapter->ulTotalTargetBuffersAvailable == 0)
> > > + || (Adapter->ulFreeTargetBufferCnt == 0)) {
> > 
> > Haven't we had this discussion?  The "||" goes on the first line and the
> > indenting needs to be lined up.
> 
> I think no, we had not.

Sorry, about that then.

I'm done reviewing the patchset and it looks good to me.  Thanks for
your work on this.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

2014-05-26 Thread Matthias Beyer 
On 26-05-2014 11:38:25, Dan Carpenter wrote:
> On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote:
> > Signed-off-by: Matthias Beyer 
> > ---
> >  drivers/staging/bcm/CmHost.c | 14 ++
> >  1 file changed, 10 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
> > index 3f29dea..9fea9a8 100644
> > --- a/drivers/staging/bcm/CmHost.c
> > +++ b/drivers/staging/bcm/CmHost.c
> > @@ -1531,12 +1531,14 @@ ULONG SetUpTargetDsxBuffers(struct bcm_mini_adapter 
> > *Adapter)
> > return 1;
> >  }
> >  
> > -static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter *Adapter, 
> > B_UINT16 tid)
> > +static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter *Adapter,
> > +   B_UINT16 tid)
> >  {
> > ULONG dsx_buf;
> > ULONG idx, max_try;
> >  
> > -   if ((Adapter->ulTotalTargetBuffersAvailable == 0) || 
> > (Adapter->ulFreeTargetBufferCnt == 0)) {
> > +   if ((Adapter->ulTotalTargetBuffersAvailable == 0)
> > +   || (Adapter->ulFreeTargetBufferCnt == 0)) {
> 
> Haven't we had this discussion?  The "||" goes on the first line and the
> indenting needs to be lined up.

I think no, we had not. But thanks, I will fix stuff like this in my
next iterations and will remember your notes for the next few
patchsets I want to send!

-- 
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer

Proudly sent with mutt.
Happily signed with gnupg.


pgpgb9pWoxZiV.pgp
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

2014-05-26 Thread Dan Carpenter 
On Fri, May 23, 2014 at 10:23:45PM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer 
> ---
>  drivers/staging/bcm/CmHost.c | 14 ++
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
> index 3f29dea..9fea9a8 100644
> --- a/drivers/staging/bcm/CmHost.c
> +++ b/drivers/staging/bcm/CmHost.c
> @@ -1531,12 +1531,14 @@ ULONG SetUpTargetDsxBuffers(struct bcm_mini_adapter 
> *Adapter)
>   return 1;
>  }
>  
> -static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter *Adapter, 
> B_UINT16 tid)
> +static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter *Adapter,
> + B_UINT16 tid)
>  {
>   ULONG dsx_buf;
>   ULONG idx, max_try;
>  
> - if ((Adapter->ulTotalTargetBuffersAvailable == 0) || 
> (Adapter->ulFreeTargetBufferCnt == 0)) {
> + if ((Adapter->ulTotalTargetBuffersAvailable == 0)
> + || (Adapter->ulFreeTargetBufferCnt == 0)) {

Haven't we had this discussion?  The "||" goes on the first line and the
indenting needs to be lined up.

if ((Adapter->ulTotalTargetBuffersAvailable == 0) ||
(Adapter->ulFreeTargetBufferCnt == 0)) {


>   ClearTargetDSXBuffer(Adapter, tid, false);
>   return 0;
>   }

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 07/27] Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()

2014-05-23 Thread Matthias Beyer 
Signed-off-by: Matthias Beyer 
---
 drivers/staging/bcm/CmHost.c | 14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
index 3f29dea..9fea9a8 100644
--- a/drivers/staging/bcm/CmHost.c
+++ b/drivers/staging/bcm/CmHost.c
@@ -1531,12 +1531,14 @@ ULONG SetUpTargetDsxBuffers(struct bcm_mini_adapter 
*Adapter)
return 1;
 }
 
-static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter *Adapter, 
B_UINT16 tid)
+static ULONG GetNextTargetBufferLocation(struct bcm_mini_adapter *Adapter,
+   B_UINT16 tid)
 {
ULONG dsx_buf;
ULONG idx, max_try;
 
-   if ((Adapter->ulTotalTargetBuffersAvailable == 0) || 
(Adapter->ulFreeTargetBufferCnt == 0)) {
+   if ((Adapter->ulTotalTargetBuffersAvailable == 0)
+   || (Adapter->ulFreeTargetBufferCnt == 0)) {
ClearTargetDSXBuffer(Adapter, tid, false);
return 0;
}
@@ -1549,7 +1551,9 @@ static ULONG GetNextTargetBufferLocation(struct 
bcm_mini_adapter *Adapter, B_UIN
}
 
if (max_try == 0) {
-   BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0, "\n 
GetNextTargetBufferLocation : Error No Free Target DSX Buffers FreeCnt : %lx ", 
Adapter->ulFreeTargetBufferCnt);
+   BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
+   "\n GetNextTargetBufferLocation : Error No Free 
Target DSX Buffers FreeCnt : %lx ",
+   Adapter->ulFreeTargetBufferCnt);
ClearTargetDSXBuffer(Adapter, tid, false);
return 0;
}
@@ -1560,7 +1564,9 @@ static ULONG GetNextTargetBufferLocation(struct 
bcm_mini_adapter *Adapter, B_UIN
Adapter->ulFreeTargetBufferCnt--;
idx = (idx+1)%Adapter->ulTotalTargetBuffersAvailable;
Adapter->ulCurrentTargetBuffer = idx;
-   BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0, 
"GetNextTargetBufferLocation :Returning address %lx tid %d\n", dsx_buf, tid);
+   BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
+   "GetNextTargetBufferLocation :Returning address %lx tid 
%d\n",
+   dsx_buf, tid);
 
return dsx_buf;
 }
-- 
1.9.3

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel