Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

2014-04-23 Thread Dan Carpenter 
On Wed, Apr 23, 2014 at 09:01:24AM +0530, navin patidar wrote:
 dan, It is ok to rearrange and remove members of  enum LED_STATE_871x
 and  enum LED_CTL_MODE.
 these enum are not related to firmware .

Ok.  Cool.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

2014-04-22 Thread Dan Carpenter 
It's ok to renumber all of these?  It's not something the firmware will
care about?  Have you tested this?  Same for patch 10/10.

(These questions are just questions.  I don't ask rhetorical questions
on email.  I don't know the answers).

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

2014-04-20 Thread navin patidar 
Signed-off-by: navin patidar navin.pati...@gmail.com
---
 drivers/staging/rtl8188eu/include/rtw_led.h |   30 +--
 1 file changed, 10 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h 
b/drivers/staging/rtl8188eu/include/rtw_led.h
index 2f81fab..2ad7e4a 100644
--- a/drivers/staging/rtl8188eu/include/rtw_led.h
+++ b/drivers/staging/rtl8188eu/include/rtw_led.h
@@ -47,26 +47,16 @@ enum LED_CTL_MODE {
 };
 
 enum LED_STATE_871x {
-   LED_UNKNOWN = 0,
-   RTW_LED_ON = 1,
-   RTW_LED_OFF = 2,
-   LED_BLINK_NORMAL = 3,
-   LED_BLINK_SLOWLY = 4,
-   LED_BLINK_POWER_ON = 5,
-   LED_BLINK_SCAN = 6, /*  LED is blinking during scanning period,
-* the # of times to blink is depend on time
-* for scanning. */
-   LED_BLINK_NO_LINK = 7, /*  LED is blinking during no link state. */
-   LED_BLINK_StartToBlink = 8,/*  Customzied for Sercomm Printer
-   * Server case */
-   LED_BLINK_TXRX = 9,
-   LED_BLINK_WPS = 10, /*  LED is blinkg during WPS communication */
-   LED_BLINK_WPS_STOP = 11,/* for ALPHA */
-   LED_BLINK_WPS_STOP_OVERLAP = 12,/* for BELKIN */
-   LED_BLINK_RUNTOP = 13, /*  Customized for RunTop */
-   LED_BLINK_CAMEO = 14,
-   LED_BLINK_XAVI = 15,
-   LED_BLINK_ALWAYS_ON = 16,
+   LED_UNKNOWN,
+   RTW_LED_ON,
+   RTW_LED_OFF,
+   LED_BLINK_NORMAL,
+   LED_BLINK_SLOWLY,
+   LED_BLINK_POWER_ON,
+   LED_BLINK_SCAN,
+   LED_BLINK_TXRX,
+   LED_BLINK_WPS,
+   LED_BLINK_WPS_STOP
 };
 
 struct LED_871x {
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel