Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

[Greg KH]

On Wed, Sep 28, 2016 at 03:55:32PM +0530, shyam saini wrote:
> Remove the explicit NULL comparison and rewrite in a compact form and
> fixed switch case indentation issue.

If you need "and" in a subject: line for a patch, that's a huge hint
that this needs to be at least 2 patches.

Please only ever do "one type of thing" in a single patch.  And no, that
one thing can not be "fix all coding style issues" :)

Please break this up into multiple patches and resend it.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

[shyam saini]

Remove the explicit NULL comparison and rewrite in a compact form and
fixed switch case indentation issue.

Signed-off-by: shyam saini 
---
 drivers/staging/android/ion/ion_of.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/android/ion/ion_of.c 
b/drivers/staging/android/ion/ion_of.c
index de0899a..0b7bb30 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node,
break;
}
 
-   if (compatible[i].name == NULL)
+   if (!compatible[i].name)
return -ENODEV;
 
heap->id = compatible[i].heap_id;
@@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent,
int ret = 0;
 
switch (heap->type) {
-   case ION_HEAP_TYPE_CARVEOUT:
-   case ION_HEAP_TYPE_CHUNK:
-   if (heap->base && heap->size)
-   return 0;
-
-   ret = of_reserved_mem_device_init(heap->priv);
-   break;
-   default:
-   break;
+   case ION_HEAP_TYPE_CARVEOUT:
+   case ION_HEAP_TYPE_CHUNK:
+   if (heap->base && heap->size)
+   return 0;
+
+   ret = of_reserved_mem_device_init(heap->priv);
+   break;
+   default:
+   break;
}
 
return ret;
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel