[PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.

2014-08-19 Thread Yannis Damigos 
This is a patch to the ipuv3-crtc.c file that fixes up two lines
over 80 characters warnings found by the checkpatch.pl tool.

Signed-off-by: Yannis Damigos giannis.dami...@gmail.com
---
 drivers/staging/imx-drm/ipuv3-crtc.c | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c 
b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..c4c6455 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b/drivers/staging/imx-drm/ipuv3-crtc.c
@@ -201,9 +201,9 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
return ret;
}
 
-   return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode, 
crtc-primary-fb,
- 0, 0, mode-hdisplay, mode-vdisplay,
- x, y, mode-hdisplay, mode-vdisplay);
+   return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode,
+   crtc-primary-fb, 0, 0, mode-hdisplay, mode-vdisplay,
+   x, y, mode-hdisplay, mode-vdisplay);
 }
 
 static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
@@ -227,7 +227,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
 
if (ipu_crtc-newfb) {
ipu_crtc-newfb = NULL;
-   ipu_plane_set_base(ipu_crtc-plane[0], 
ipu_crtc-base.primary-fb,
+   ipu_plane_set_base(ipu_crtc-plane[0],
+   ipu_crtc-base.primary-fb,
ipu_crtc-plane[0]-x, ipu_crtc-plane[0]-y);
ipu_crtc_handle_pageflip(ipu_crtc);
}
-- 
2.0.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.

2014-08-19 Thread Philipp Zabel 
Am Dienstag, den 19.08.2014, 16:59 +0300 schrieb Yannis Damigos:
 This is a patch to the ipuv3-crtc.c file that fixes up two lines
 over 80 characters warnings found by the checkpatch.pl tool.
 
 Signed-off-by: Yannis Damigos giannis.dami...@gmail.com
 ---
  drivers/staging/imx-drm/ipuv3-crtc.c | 9 +
  1 file changed, 5 insertions(+), 4 deletions(-)
 
 diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c 
 b/drivers/staging/imx-drm/ipuv3-crtc.c
 index 720868b..c4c6455 100644
 --- a/drivers/staging/imx-drm/ipuv3-crtc.c
 +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
 @@ -201,9 +201,9 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
   return ret;
   }
  
 - return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode, 
 crtc-primary-fb,
 -   0, 0, mode-hdisplay, mode-vdisplay,
 -   x, y, mode-hdisplay, mode-vdisplay);
 + return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode,
 + crtc-primary-fb, 0, 0, mode-hdisplay, mode-vdisplay,
 + x, y, mode-hdisplay, mode-vdisplay);
  }
  
  static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)

This doesn't improve readability, though. Can we keep the alignment of
the x/y/width/height parameters?

 @@ -227,7 +227,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
  
   if (ipu_crtc-newfb) {
   ipu_crtc-newfb = NULL;
 - ipu_plane_set_base(ipu_crtc-plane[0], 
 ipu_crtc-base.primary-fb,
 + ipu_plane_set_base(ipu_crtc-plane[0],
 + ipu_crtc-base.primary-fb,
   ipu_crtc-plane[0]-x, ipu_crtc-plane[0]-y);
   ipu_crtc_handle_pageflip(ipu_crtc);
   }

regards
Philipp

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.

2014-08-19 Thread Yannis Damigos 
This is a patch to the ipuv3-crtc.c file that fixes up two lines
over 80 characters warnings found by the checkpatch.pl tool,
keeping the alignment of the x/y/width/height parameters for
readability.

Signed-off-by: Yannis Damigos giannis.dami...@gmail.com
---
 drivers/staging/imx-drm/ipuv3-crtc.c | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c 
b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..d6657a0 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b/drivers/staging/imx-drm/ipuv3-crtc.c
@@ -201,9 +201,10 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
return ret;
}
 
-   return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode, 
crtc-primary-fb,
- 0, 0, mode-hdisplay, mode-vdisplay,
- x, y, mode-hdisplay, mode-vdisplay);
+   return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode,
+   crtc-primary-fb,
+   0, 0, mode-hdisplay, mode-vdisplay,
+   x, y, mode-hdisplay, mode-vdisplay);
 }
 
 static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
@@ -227,7 +228,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
 
if (ipu_crtc-newfb) {
ipu_crtc-newfb = NULL;
-   ipu_plane_set_base(ipu_crtc-plane[0], 
ipu_crtc-base.primary-fb,
+   ipu_plane_set_base(ipu_crtc-plane[0],
+   ipu_crtc-base.primary-fb,
ipu_crtc-plane[0]-x, ipu_crtc-plane[0]-y);
ipu_crtc_handle_pageflip(ipu_crtc);
}
-- 
2.0.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.

2014-08-19 Thread Russell King - ARM Linux 
On Tue, Aug 19, 2014 at 05:36:10PM +0300, Yannis Damigos wrote:
 diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c 
 b/drivers/staging/imx-drm/ipuv3-crtc.c
 index 720868b..d6657a0 100644
 --- a/drivers/staging/imx-drm/ipuv3-crtc.c
 +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
 @@ -201,9 +201,10 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
   return ret;
   }
  
 - return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode, 
 crtc-primary-fb,
 -   0, 0, mode-hdisplay, mode-vdisplay,
 -   x, y, mode-hdisplay, mode-vdisplay);
 + return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode,
 + crtc-primary-fb,
 + 0, 0, mode-hdisplay, mode-vdisplay,
 + x, y, mode-hdisplay, mode-vdisplay);

Why change the indentation like this?  There is a wisdom which suggests
that it's better to align the arguments with the function call's first
argument, unless there is a strong reason not to.  In this case, I can't
see a strong reason to change the indentation to some different style
here.

  }
  
  static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
 @@ -227,7 +228,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
  
   if (ipu_crtc-newfb) {
   ipu_crtc-newfb = NULL;
 - ipu_plane_set_base(ipu_crtc-plane[0], 
 ipu_crtc-base.primary-fb,
 + ipu_plane_set_base(ipu_crtc-plane[0],
 + ipu_crtc-base.primary-fb,
   ipu_crtc-plane[0]-x, ipu_crtc-plane[0]-y);

What may make better sense here is:
struct ipu_plane *plane = ipu_crtc-plane[0];

ipu_crtc-newfb = NULL;
ipu_plane_set_base(plane, ipu_crtc-base.primary-fb,
   plane-x, plane-y);

which to me looks loads nicer.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.

2014-08-19 Thread Yannis Damigos 
This is a patch to the ipuv3-crtc.c file that fixes up two lines
over 80 characters warnings found by the checkpatch.pl tool,
keeping the alignment of the x/y/width/height parameters for
readability.

Signed-off-by: Yannis Damigos giannis.dami...@gmail.com
---
 drivers/staging/imx-drm/ipuv3-crtc.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c 
b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..11e84a2 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b/drivers/staging/imx-drm/ipuv3-crtc.c
@@ -201,7 +201,8 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
return ret;
}
 
-   return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode, 
crtc-primary-fb,
+   return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode,
+ crtc-primary-fb,
  0, 0, mode-hdisplay, mode-vdisplay,
  x, y, mode-hdisplay, mode-vdisplay);
 }
@@ -226,9 +227,11 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
imx_drm_handle_vblank(ipu_crtc-imx_crtc);
 
if (ipu_crtc-newfb) {
+   struct ipu_plane *plane = ipu_crtc-plane[0];
+
ipu_crtc-newfb = NULL;
-   ipu_plane_set_base(ipu_crtc-plane[0], 
ipu_crtc-base.primary-fb,
-   ipu_crtc-plane[0]-x, ipu_crtc-plane[0]-y);
+   ipu_plane_set_base(plane, ipu_crtc-base.primary-fb,
+  plane-x, plane-y);
ipu_crtc_handle_pageflip(ipu_crtc);
}
 
-- 
2.0.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.

2014-08-19 Thread Philipp Zabel 
Am Dienstag, den 19.08.2014, 18:26 +0300 schrieb Yannis Damigos:
 This is a patch to the ipuv3-crtc.c file that fixes up two lines
 over 80 characters warnings found by the checkpatch.pl tool,
 keeping the alignment of the x/y/width/height parameters for
 readability.
 
 Signed-off-by: Yannis Damigos giannis.dami...@gmail.com
 ---
  drivers/staging/imx-drm/ipuv3-crtc.c | 9 ++---
  1 file changed, 6 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c 
 b/drivers/staging/imx-drm/ipuv3-crtc.c
 index 720868b..11e84a2 100644
 --- a/drivers/staging/imx-drm/ipuv3-crtc.c
 +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
 @@ -201,7 +201,8 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
   return ret;
   }
  
 - return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode, 
 crtc-primary-fb,
 + return ipu_plane_mode_set(ipu_crtc-plane[0], crtc, mode,
 +   crtc-primary-fb,
 0, 0, mode-hdisplay, mode-vdisplay,
 x, y, mode-hdisplay, mode-vdisplay);
  }
 @@ -226,9 +227,11 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
   imx_drm_handle_vblank(ipu_crtc-imx_crtc);
  
   if (ipu_crtc-newfb) {
 + struct ipu_plane *plane = ipu_crtc-plane[0];
 +
   ipu_crtc-newfb = NULL;
 - ipu_plane_set_base(ipu_crtc-plane[0], 
 ipu_crtc-base.primary-fb,
 - ipu_crtc-plane[0]-x, ipu_crtc-plane[0]-y);
 + ipu_plane_set_base(plane, ipu_crtc-base.primary-fb,
 +plane-x, plane-y);
   ipu_crtc_handle_pageflip(ipu_crtc);
   }

Yes, that does look better.

Acked-by: Philipp Zabel p.za...@pengutronix.de

regards
Philipp

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel