Re: [PATCH 1/1] staging: rtl8188eu: Macros with complex values should be enclosed in parentheses

2017-03-29 Thread Greg KH 
On Tue, Mar 28, 2017 at 09:56:19PM +0100, Alfonso Lima Astor wrote:
> Fix coding style issue
> 
> Signed-off-by: Alfonso Lima Astor 
> ---
>  drivers/staging/rtl8188eu/include/rtw_ioctl.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/rtw_ioctl.h 
> b/drivers/staging/rtl8188eu/include/rtw_ioctl.h
> index a6b1c85..0c022a5 100644
> --- a/drivers/staging/rtl8188eu/include/rtw_ioctl.h
> +++ b/drivers/staging/rtl8188eu/include/rtw_ioctl.h
> @@ -59,10 +59,10 @@
>  #define OID_MP_SEG4  0xFF011100
>  
>  #define DEBUG_OID(dbg, str)  \
> - if ((!dbg)) {   \
> + (if ((!dbg)) {  \
>   RT_TRACE(_module_rtl871x_ioctl_c_, _drv_info_,  \
>("%s(%d): %s", __func__, __line__, str));  \
> - }
> + })

Your change doesn't do what you think it does :(

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] staging: rtl8188eu: Macros with complex values should be enclosed in parentheses

2017-03-28 Thread Ivan Safonov 

On 03/28/2017 11:56 PM, Alfonso Lima Astor wrote:

Fix coding style issue

Signed-off-by: Alfonso Lima Astor 
---
 drivers/staging/rtl8188eu/include/rtw_ioctl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_ioctl.h 
b/drivers/staging/rtl8188eu/include/rtw_ioctl.h
index a6b1c85..0c022a5 100644
--- a/drivers/staging/rtl8188eu/include/rtw_ioctl.h
+++ b/drivers/staging/rtl8188eu/include/rtw_ioctl.h
@@ -59,10 +59,10 @@
 #define OID_MP_SEG40xFF011100

 #define DEBUG_OID(dbg, str)\
-   if ((!dbg)) {   \
+   (if ((!dbg)) {  \
RT_TRACE(_module_rtl871x_ioctl_c_, _drv_info_,  \
 ("%s(%d): %s", __func__, __line__, str));\
-   }
+   })

 enum oid_type {
QUERY_OID,



Probably, DEBUG_OID macro does not used, so you can remove it.

Ivan Safonov.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] staging: rtl8188eu: Macros with complex values should be enclosed in parentheses

2017-03-28 Thread Tobin C. Harding 
On Tue, Mar 28, 2017 at 09:56:19PM +0100, Alfonso Lima Astor wrote:
> Fix coding style issue
> 
> Signed-off-by: Alfonso Lima Astor 
> ---

Hi Alfonso,

You don't need to put 1/1 in the subject of a single patch. You may
like to limit your git log summary to 50 characters (and the main body
to about 72 characters). 

Also you may like to add a little more detail to your git log message, for
example how you found this issue, why it needs fixing etc

Good luck,
Tobin.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/1] staging: rtl8188eu: Macros with complex values should be enclosed in parentheses

2017-03-28 Thread Alfonso Lima Astor 
Fix coding style issue

Signed-off-by: Alfonso Lima Astor 
---
 drivers/staging/rtl8188eu/include/rtw_ioctl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_ioctl.h 
b/drivers/staging/rtl8188eu/include/rtw_ioctl.h
index a6b1c85..0c022a5 100644
--- a/drivers/staging/rtl8188eu/include/rtw_ioctl.h
+++ b/drivers/staging/rtl8188eu/include/rtw_ioctl.h
@@ -59,10 +59,10 @@
 #define OID_MP_SEG40xFF011100
 
 #define DEBUG_OID(dbg, str)\
-   if ((!dbg)) {   \
+   (if ((!dbg)) {  \
RT_TRACE(_module_rtl871x_ioctl_c_, _drv_info_,  \
 ("%s(%d): %s", __func__, __line__, str));  \
-   }
+   })
 
 enum oid_type {
QUERY_OID,
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel