[PATCH 1/2] drivers: bcm: Mark functions as static in Qos.c

2013-12-21 Thread Rashika Kheria 
Mark functions MatchSrcIpAddress(), MatchDestIpAddress() and MatchTos()
as static in Qos.c because they are not used outside this file.

This eliminates the following warnings in Qos.c:
drivers/staging/bcm/Qos.c:27:6: warning: no previous prototype for 
‘MatchSrcIpAddress’ [-Wmissing-prototypes]
drivers/staging/bcm/Qos.c:61:6: warning: no previous prototype for 
‘MatchDestIpAddress’ [-Wmissing-prototypes]
drivers/staging/bcm/Qos.c:94:6: warning: no previous prototype for ‘MatchTos’ 
[-Wmissing-prototypes]

Signed-off-by: Rashika Kheria rashika.khe...@gmail.com
---
 drivers/staging/bcm/Qos.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 1609a2b..0727599 100644
--- a/drivers/staging/bcm/Qos.c
+++ b/drivers/staging/bcm/Qos.c
@@ -24,7 +24,7 @@ static VOID PruneQueue(struct bcm_mini_adapter *Adapter, INT 
iIndex);
 *
 * Returns - TRUE(If address matches) else FAIL .
 */
-bool MatchSrcIpAddress(struct bcm_classifier_rule *pstClassifierRule, ULONG 
ulSrcIP)
+static bool MatchSrcIpAddress(struct bcm_classifier_rule *pstClassifierRule, 
ULONG ulSrcIP)
 {
UCHAR ucLoopIndex = 0;
 
@@ -58,7 +58,7 @@ bool MatchSrcIpAddress(struct bcm_classifier_rule 
*pstClassifierRule, ULONG ulSr
 *
 * Returns - TRUE(If address matches) else FAIL .
 */
-bool MatchDestIpAddress(struct bcm_classifier_rule *pstClassifierRule, ULONG 
ulDestIP)
+static bool MatchDestIpAddress(struct bcm_classifier_rule *pstClassifierRule, 
ULONG ulDestIP)
 {
UCHAR ucLoopIndex = 0;
struct bcm_mini_adapter *Adapter = GET_BCM_ADAPTER(gblpnetdev);
@@ -91,7 +91,7 @@ bool MatchDestIpAddress(struct bcm_classifier_rule 
*pstClassifierRule, ULONG ulD
 *
 * Returns - TRUE(If address matches) else FAIL.
 **/
-bool MatchTos(struct bcm_classifier_rule *pstClassifierRule, UCHAR 
ucTypeOfService)
+static bool MatchTos(struct bcm_classifier_rule *pstClassifierRule, UCHAR 
ucTypeOfService)
 {
 
struct bcm_mini_adapter *Adapter = GET_BCM_ADAPTER(gblpnetdev);
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] drivers: bcm: Mark functions as static in Qos.c

2013-12-21 Thread Josh Triplett 
On Sat, Dec 21, 2013 at 04:01:16PM +0530, Rashika Kheria wrote:
 Mark functions MatchSrcIpAddress(), MatchDestIpAddress() and MatchTos()
 as static in Qos.c because they are not used outside this file.
 
 This eliminates the following warnings in Qos.c:
 drivers/staging/bcm/Qos.c:27:6: warning: no previous prototype for 
 ‘MatchSrcIpAddress’ [-Wmissing-prototypes]
 drivers/staging/bcm/Qos.c:61:6: warning: no previous prototype for 
 ‘MatchDestIpAddress’ [-Wmissing-prototypes]
 drivers/staging/bcm/Qos.c:94:6: warning: no previous prototype for ‘MatchTos’ 
 [-Wmissing-prototypes]
 
 Signed-off-by: Rashika Kheria rashika.khe...@gmail.com

Reviewed-by: Josh Triplett j...@joshtriplett.org

  drivers/staging/bcm/Qos.c |6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
 index 1609a2b..0727599 100644
 --- a/drivers/staging/bcm/Qos.c
 +++ b/drivers/staging/bcm/Qos.c
 @@ -24,7 +24,7 @@ static VOID PruneQueue(struct bcm_mini_adapter *Adapter, 
 INT iIndex);
  *
  * Returns - TRUE(If address matches) else FAIL .
  */
 -bool MatchSrcIpAddress(struct bcm_classifier_rule *pstClassifierRule, ULONG 
 ulSrcIP)
 +static bool MatchSrcIpAddress(struct bcm_classifier_rule *pstClassifierRule, 
 ULONG ulSrcIP)
  {
   UCHAR ucLoopIndex = 0;
  
 @@ -58,7 +58,7 @@ bool MatchSrcIpAddress(struct bcm_classifier_rule 
 *pstClassifierRule, ULONG ulSr
  *
  * Returns - TRUE(If address matches) else FAIL .
  */
 -bool MatchDestIpAddress(struct bcm_classifier_rule *pstClassifierRule, ULONG 
 ulDestIP)
 +static bool MatchDestIpAddress(struct bcm_classifier_rule 
 *pstClassifierRule, ULONG ulDestIP)
  {
   UCHAR ucLoopIndex = 0;
   struct bcm_mini_adapter *Adapter = GET_BCM_ADAPTER(gblpnetdev);
 @@ -91,7 +91,7 @@ bool MatchDestIpAddress(struct bcm_classifier_rule 
 *pstClassifierRule, ULONG ulD
  *
  * Returns - TRUE(If address matches) else FAIL.
  **/
 -bool MatchTos(struct bcm_classifier_rule *pstClassifierRule, UCHAR 
 ucTypeOfService)
 +static bool MatchTos(struct bcm_classifier_rule *pstClassifierRule, UCHAR 
 ucTypeOfService)
  {
  
   struct bcm_mini_adapter *Adapter = GET_BCM_ADAPTER(gblpnetdev);
 -- 
 1.7.9.5
 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel