Re: [PATCH 1/2] staging: goldfish: fix whitespace in goldfish_audio

[Roman Kiryanov]

> > Linux kernel coding style: spaces are never used for
> > indentation.
> >
...
> >  struct goldfish_audio {
> >   char __iomem *reg_base;
> >   int irq;
> > +
>
> That's not a space/tab issue?

Thank you for looking. I separated the new line change into a separate patch.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: goldfish: fix whitespace in goldfish_audio

[Greg KH]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Jul 11, 2018 at 04:39:37PM -0700, Roman Kiryanov wrote:
> Thank you for looking. I separated the new line change into a separate patch.

I have no idea what you are referring to here.  Please properly quote
emails so that people have a chance.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: goldfish: fix whitespace in goldfish_audio

[Greg KH]

On Thu, Jun 28, 2018 at 06:19:13PM -0700, r...@google.com wrote:
> From: Roman Kiryanov 
> 
> Linux kernel coding style: spaces are never used for
> indentation.
> 
> Signed-off-by: Roman Kiryanov 
> ---
>  drivers/staging/goldfish/goldfish_audio.c | 15 ---
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/goldfish/goldfish_audio.c 
> b/drivers/staging/goldfish/goldfish_audio.c
> index b7004edd3ce2..3a75df1d2a0a 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -38,18 +38,19 @@ MODULE_VERSION("1.0");
>  struct goldfish_audio {
>   char __iomem *reg_base;
>   int irq;
> +

That's not a space/tab issue?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel