Re: [PATCH 1/2] staging: unisys: remove unused variables

2015-03-17 Thread Sudip Mukherjee 
On Mon, Mar 16, 2015 at 04:34:58PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 12, 2015 at 07:44:20PM +0530, Sudip Mukherjee wrote:
> > these variable were being assigned some values but never reused.
> > 
> > Signed-off-by: Sudip Mukherjee 
> > ---
> >  drivers/staging/unisys/virthba/virthba.c | 18 ++
> >  drivers/staging/unisys/virtpci/virtpci.c | 22 +++---
> >  2 files changed, 13 insertions(+), 27 deletions(-)
> > 
> > diff --git a/drivers/staging/unisys/virthba/virthba.c 
> > b/drivers/staging/unisys/virthba/virthba.c
> > index e5b0dd8..655db2f 100644
> > --- a/drivers/staging/unisys/virthba/virthba.c
> > +++ b/drivers/staging/unisys/virthba/virthba.c
> > @@ -333,16 +333,14 @@ static inline void
> >  send_disk_add_remove(struct diskaddremove *dar)
> >  {
> > struct scsi_device *sdev;
> > -   int error;
> >  
> > sdev = scsi_device_lookup(dar->shost, dar->channel, dar->id, dar->lun);
> > if (sdev) {
> > if (!(dar->add))
> > scsi_remove_device(sdev);
> > } else if (dar->add) {
> > -   error =
> > -   scsi_add_device(dar->shost, dar->channel, dar->id,
> > -   dar->lun);
> > +   scsi_add_device(dar->shost, dar->channel, dar->id,
> > +   dar->lun);
> 
> This should be properly checked, not ignored.
i have a total newbie question on this one and I am hoping to get
some pointer or some advise on it.
this send_disk_add_remove() is being called from
do_disk_add_remove() which is a function called from a workqueue.
so how do i return error codes fom here?

regards
sudip 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: unisys: remove unused variables

2015-03-16 Thread Greg Kroah-Hartman 
On Thu, Mar 12, 2015 at 07:44:20PM +0530, Sudip Mukherjee wrote:
> these variable were being assigned some values but never reused.
> 
> Signed-off-by: Sudip Mukherjee 
> ---
>  drivers/staging/unisys/virthba/virthba.c | 18 ++
>  drivers/staging/unisys/virtpci/virtpci.c | 22 +++---
>  2 files changed, 13 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/unisys/virthba/virthba.c 
> b/drivers/staging/unisys/virthba/virthba.c
> index e5b0dd8..655db2f 100644
> --- a/drivers/staging/unisys/virthba/virthba.c
> +++ b/drivers/staging/unisys/virthba/virthba.c
> @@ -333,16 +333,14 @@ static inline void
>  send_disk_add_remove(struct diskaddremove *dar)
>  {
>   struct scsi_device *sdev;
> - int error;
>  
>   sdev = scsi_device_lookup(dar->shost, dar->channel, dar->id, dar->lun);
>   if (sdev) {
>   if (!(dar->add))
>   scsi_remove_device(sdev);
>   } else if (dar->add) {
> - error =
> - scsi_add_device(dar->shost, dar->channel, dar->id,
> - dar->lun);
> + scsi_add_device(dar->shost, dar->channel, dar->id,
> + dar->lun);

This should be properly checked, not ignored.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/2] staging: unisys: remove unused variables

2015-03-12 Thread Sudip Mukherjee 
these variable were being assigned some values but never reused.

Signed-off-by: Sudip Mukherjee 
---
 drivers/staging/unisys/virthba/virthba.c | 18 ++
 drivers/staging/unisys/virtpci/virtpci.c | 22 +++---
 2 files changed, 13 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/unisys/virthba/virthba.c 
b/drivers/staging/unisys/virthba/virthba.c
index e5b0dd8..655db2f 100644
--- a/drivers/staging/unisys/virthba/virthba.c
+++ b/drivers/staging/unisys/virthba/virthba.c
@@ -333,16 +333,14 @@ static inline void
 send_disk_add_remove(struct diskaddremove *dar)
 {
struct scsi_device *sdev;
-   int error;
 
sdev = scsi_device_lookup(dar->shost, dar->channel, dar->id, dar->lun);
if (sdev) {
if (!(dar->add))
scsi_remove_device(sdev);
} else if (dar->add) {
-   error =
-   scsi_add_device(dar->shost, dar->channel, dar->id,
-   dar->lun);
+   scsi_add_device(dar->shost, dar->channel, dar->id,
+   dar->lun);
}
kfree(dar);
 }
@@ -401,7 +399,6 @@ virthba_isr(int irq, void *dev_id)
struct channel_header __iomem *channel_header;
struct signal_queue_header __iomem *pqhdr;
u64 mask;
-   unsigned long long rc1;
 
if (virthbainfo == NULL)
return IRQ_NONE;
@@ -414,7 +411,8 @@ virthba_isr(int irq, void *dev_id)
0)) {
virthbainfo->interrupts_disabled++;
mask = ~ULTRA_CHANNEL_ENABLE_INTS;
-   rc1 = uisqueue_interlocked_and(virthbainfo->flags_addr, mask);
+   uisqueue_interlocked_and(virthbainfo->flags_addr,
+mask);
}
if (spar_signalqueue_empty(channel_header, IOCHAN_FROM_IOPART)) {
virthbainfo->interrupts_notme++;
@@ -807,7 +805,6 @@ virthba_queue_command_lck(struct scsi_cmnd *scsicmd,
 {
struct scsi_device *scsidev = scsicmd->device;
int insert_location;
-   unsigned char op;
unsigned char *cdb = scsicmd->cmnd;
struct Scsi_Host *scsihost = scsidev->host;
struct uiscmdrsp *cmdrsp;
@@ -890,7 +887,6 @@ virthba_queue_command_lck(struct scsi_cmnd *scsicmd,
cmdrsp->scsi.guest_phys_entries = scsi_sg_count(scsicmd);
}
 
-   op = cdb[0];
i = uisqueue_put_cmdrsp_with_lock_client(virthbainfo->chinfo.queueinfo,
 cmdrsp, IOCHAN_TO_IOPART,
 &virthbainfo->chinfo.
@@ -984,11 +980,9 @@ do_scsi_linuxstat(struct uiscmdrsp *cmdrsp, struct 
scsi_cmnd *scsicmd)
 {
struct virtdisk_info *vdisk;
struct scsi_device *scsidev;
-   struct sense_data *sd;
 
scsidev = scsicmd->device;
memcpy(scsicmd->sense_buffer, cmdrsp->scsi.sensebuf, MAX_SENSE_SIZE);
-   sd = (struct sense_data *)scsicmd->sense_buffer;
 
/* Do not log errors for disk-not-present inquiries */
if ((cmdrsp->scsi.cmnd[0] == INQUIRY) &&
@@ -1178,7 +1172,6 @@ process_incoming_rsps(void *v)
struct uiscmdrsp *cmdrsp = NULL;
const int SZ = sizeof(struct uiscmdrsp);
u64 mask;
-   unsigned long long rc1;
 
UIS_DAEMONIZE("vhba_incoming");
/* alloc once and reuse */
@@ -1197,7 +1190,8 @@ process_incoming_rsps(void *v)
atomic_set(&virthbainfo->interrupt_rcvd, 0);
/* drain queue */
drain_queue(virthbainfo, dc, cmdrsp);
-   rc1 = uisqueue_interlocked_or(virthbainfo->flags_addr, mask);
+   uisqueue_interlocked_or(virthbainfo->flags_addr,
+   mask);
}
 
kfree(cmdrsp);
diff --git a/drivers/staging/unisys/virtpci/virtpci.c 
b/drivers/staging/unisys/virtpci/virtpci.c
index 43b5736..e0d38d5 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -546,7 +546,6 @@ static void delete_all(void)
 static int delete_all_virt(enum virtpci_dev_type devtype,
   struct del_vbus_guestpart *delparams)
 {
-   int i;
unsigned char busid[BUS_ID_SIZE];
struct device *vbus;
 
@@ -561,7 +560,7 @@ static int delete_all_virt(enum virtpci_dev_type devtype,
return 0;
 
/* delete all vhbas/vnics */
-   i = virtpci_device_del(vbus, devtype, NULL, NULL);
+   virtpci_device_del(vbus, devtype, NULL, NULL);
return 1;
 }
 
@@ -797,7 +796,6 @@ static int virtpci_device_add(struct device *parentbus, int 
devtype,
struct virtpci_dev *tmpvpcidev = NULL, *prev;
unsigned long flags;
int ret;
-   struct spar_io_channel_protocol __iomem *io_chan = NULL;
struct device *dev;
 
POSTCODE_LINUX_2(VPCI_CREATE_ENTRY_PC, POSTCODE_SEVERITY_INFO);
@@ -831,10 +829,6 @@ stat