Re: [PATCH 1/8] staging: lustre: Enclose complex macros in parantheses
On Thu, Dec 21, 2017 at 04:43:27PM +0100, Christoph Volkert wrote: > This is a duplicate patch. We fixed a typo and this was still left as a > temporary file. (emacs…) Sorry. The patch with Message-Id > <1513869932-27407-3-git-send-email-fabian_hue...@web.de> is the right one. > > We can provide a new patch series without the fix, if needed. Please do, as I have no idea what to do otherwise. Consider this patch series dropped. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/8] staging: lustre: Enclose complex macros in parantheses
This is a duplicate patch. We fixed a typo and this was still left as a temporary file. (emacs…) Sorry. The patch with Message-Id <1513869932-27407-3-git-send-email-fabian_hue...@web.de> is the right one. We can provide a new patch series without the fix, if needed. Thanks Christoph Checkpatch wants complex macros to be enclosed in parantheses, so we put parantheses around these four macros. Signed-off-by: Fabian Huegel Signed-off-by: Christoph Volkert --- drivers/staging/lustre/lustre/include/obd_class.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h index 67c535c..5c8cf30 100644 --- a/drivers/staging/lustre/lustre/include/obd_class.h +++ b/drivers/staging/lustre/lustre/include/obd_class.h @@ -294,10 +294,10 @@ struct obdo; void obdo_to_ioobj(const struct obdo *oa, struct obd_ioobj *ioobj); -#define OBT(dev) (dev)->obd_type -#define OBP(dev, op)(dev)->obd_type->typ_dt_ops->op -#define MDP(dev, op)(dev)->obd_type->typ_md_ops->op -#define CTXTP(ctxt, op) (ctxt)->loc_logops->lop_##op +#define OBT(dev) ((dev)->obd_type) +#define OBP(dev, op)((dev)->obd_type->typ_dt_ops->op) +#define MDP(dev, op)((dev)->obd_type->typ_md_ops->op) +#define CTXTP(ctxt, op) ((ctxt)->loc_logops->lop_##op) /* Ensure obd_setup: used for cleanup which must be called * while obd is stopping ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/8] staging: lustre: Enclose complex macros in parantheses
Checkpatch wants complex macros to be enclosed in parantheses, so we put parantheses around these four macros. Signed-off-by: Fabian Huegel Signed-off-by: Christoph Volkert --- drivers/staging/lustre/lustre/include/obd_class.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h index 67c535c..5c8cf30 100644 --- a/drivers/staging/lustre/lustre/include/obd_class.h +++ b/drivers/staging/lustre/lustre/include/obd_class.h @@ -294,10 +294,10 @@ struct obdo; void obdo_to_ioobj(const struct obdo *oa, struct obd_ioobj *ioobj); -#define OBT(dev) (dev)->obd_type -#define OBP(dev, op)(dev)->obd_type->typ_dt_ops->op -#define MDP(dev, op)(dev)->obd_type->typ_md_ops->op -#define CTXTP(ctxt, op) (ctxt)->loc_logops->lop_##op +#define OBT(dev) ((dev)->obd_type) +#define OBP(dev, op)((dev)->obd_type->typ_dt_ops->op) +#define MDP(dev, op)((dev)->obd_type->typ_md_ops->op) +#define CTXTP(ctxt, op) ((ctxt)->loc_logops->lop_##op) /* Ensure obd_setup: used for cleanup which must be called * while obd is stopping -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
