Re: [PATCH 14/15] staging: unisys: fix alignment in visornic_main.c

2015-12-03 Thread Arfvidson, Erik 
On 12/2/15 8:22 AM, Dan Carpenter wrote:
> On Mon, Nov 30, 2015 at 02:46:14PM -0500, Benjamin Romer wrote:
>> @@ -1651,7 +1651,7 @@ service_resp_queue(struct uiscmdrsp *cmdrsp, struct 
>> visornic_devdata *devdata,
>>   * netif_wake_queue()
>>   */
>>  if (vnic_hit_low_watermark(devdata,
>> -devdata->lower_threshold_net_xmits)) {
>> +devdata->lower_threshold_net_xmits)) {
> The original was best.  It is suggesting:
>
>   if (vnic_hit_low_watermark(devdata,
>  
> devdata->lower_threshold_net_xmits)) {
>
> But that is over 80 chars.
>
> regards,
> dan carpenter
>
>
Thanks,
Must have missed it.

Cheers,
Erik A
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 14/15] staging: unisys: fix alignment in visornic_main.c

2015-12-02 Thread Dan Carpenter 
On Mon, Nov 30, 2015 at 02:46:14PM -0500, Benjamin Romer wrote:
> @@ -1651,7 +1651,7 @@ service_resp_queue(struct uiscmdrsp *cmdrsp, struct 
> visornic_devdata *devdata,
>* netif_wake_queue()
>*/
>   if (vnic_hit_low_watermark(devdata,
> - devdata->lower_threshold_net_xmits)) {
> + devdata->lower_threshold_net_xmits)) {

The original was best.  It is suggesting:

if (vnic_hit_low_watermark(devdata,
   
devdata->lower_threshold_net_xmits)) {

But that is over 80 chars.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 14/15] staging: unisys: fix alignment in visornic_main.c

2015-11-30 Thread Benjamin Romer 
From: Erik Arfvidson 

This patch fixes the following types of check patch warnings:
Alignment should match open parenthesis

Signed-off-by: Erik Arfvidson 
Signed-off-by: Benjamin Romer 
---
 drivers/staging/unisys/visornic/visornic_main.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/unisys/visornic/visornic_main.c 
b/drivers/staging/unisys/visornic/visornic_main.c
index 0b305e5..bf1fd93 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -437,8 +437,8 @@ post_skb(struct uiscmdrsp *cmdrsp,
cmdrsp->net.type = NET_RCV_POST;
cmdrsp->cmdtype = CMD_NET_TYPE;
if (visorchannel_signalinsert(devdata->dev->visorchannel,
- IOCHAN_TO_IOPART,
- cmdrsp)) {
+ IOCHAN_TO_IOPART,
+ cmdrsp)) {
atomic_inc(>num_rcvbuf_in_iovm);
devdata->chstat.sent_post++;
} else {
@@ -466,8 +466,8 @@ send_enbdis(struct net_device *netdev, int state,
devdata->cmdrsp_rcv->net.type = NET_RCV_ENBDIS;
devdata->cmdrsp_rcv->cmdtype = CMD_NET_TYPE;
if (visorchannel_signalinsert(devdata->dev->visorchannel,
- IOCHAN_TO_IOPART,
- devdata->cmdrsp_rcv))
+ IOCHAN_TO_IOPART,
+ devdata->cmdrsp_rcv))
devdata->chstat.sent_enbdis++;
 }
 
@@ -1651,7 +1651,7 @@ service_resp_queue(struct uiscmdrsp *cmdrsp, struct 
visornic_devdata *devdata,
 * netif_wake_queue()
 */
if (vnic_hit_low_watermark(devdata,
-   devdata->lower_threshold_net_xmits)) {
+   devdata->lower_threshold_net_xmits)) {
/* enough NET_XMITs completed
 * so can restart netif queue
 */
-- 
2.5.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel