Re: [PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c

2013-12-21 Thread Josh Triplett
On Sat, Dec 21, 2013 at 03:58:25PM +0530, Rashika Kheria wrote:
> Include appropriate header file dgap/dgap_trace.h in dgap_trace.c
> because function dgap_tracer_free() have its prototype declaration in
> the header file.
> 
> This eliminates the following warning in dgap_trace.c:
> drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for 
> ‘dgap_tracer_free’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria 

Reviewed-by: Josh Triplett 

>  drivers/staging/dgap/dgap_trace.c |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/dgap/dgap_trace.c 
> b/drivers/staging/dgap/dgap_trace.c
> index 0f9a956..6c8b510 100644
> --- a/drivers/staging/dgap/dgap_trace.c
> +++ b/drivers/staging/dgap/dgap_trace.c
> @@ -37,6 +37,7 @@
>  #include 
>  
>  #include "dgap_driver.h"
> +#include "dgap_trace.h"
>  
>  #define TRC_TO_CONSOLE 1
>  
> -- 
> 1.7.9.5
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c

2013-12-21 Thread Rashika Kheria
Include appropriate header file dgap/dgap_trace.h in dgap_trace.c
because function dgap_tracer_free() have its prototype declaration in
the header file.

This eliminates the following warning in dgap_trace.c:
drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for 
‘dgap_tracer_free’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria 
---
 drivers/staging/dgap/dgap_trace.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/dgap/dgap_trace.c 
b/drivers/staging/dgap/dgap_trace.c
index 0f9a956..6c8b510 100644
--- a/drivers/staging/dgap/dgap_trace.c
+++ b/drivers/staging/dgap/dgap_trace.c
@@ -37,6 +37,7 @@
 #include 
 
 #include "dgap_driver.h"
+#include "dgap_trace.h"
 
 #define TRC_TO_CONSOLE 1
 
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel