Re: [PATCH 2/5] staging/pi433/pi433_if.c:Removed Coding style issues from pi433_if.h and other dependencies arising from it.
The subject is too vague. The patch prefix isn't right. Do `git log --oneline drivers/staging/pi433/` to see what other people are doing: 99859541a92d staging: pi433: use div_u64 for 64-bit division 056eeda2f9e6 staging: pi433: Style fix - align block comments 775f6ab013d3 staging: pi433: Make functions rf69_set_bandwidth_intern static c7d42f37087d Staging: pi433: check error after kthread_run() 7de77a3917e3 Staging: pi433: declare functions static 0119a48b69fe staging: pi433: depends on SPI So the subject should be something like: [PATCH] staging: pi433: rename camel case variables Also there was no patch description and that's required. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/5] staging/pi433/pi433_if.c:Removed Coding style issues from pi433_if.h and other dependencies arising from it.
Reviewed-by: Marcus Wolf Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas: > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/pi433_if.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c > b/drivers/staging/pi433/pi433_if.c > index ed737f4..11c042b 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -192,7 +192,7 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct > pi433_rx_cfg *rx_cfg) > SET_CHECKED(rf69_set_modulation (dev->spi, rx_cfg->modulation)); > SET_CHECKED(rf69_set_antenna_impedance (dev->spi, > rx_cfg->antenna_impedance)); > SET_CHECKED(rf69_set_rssi_threshold (dev->spi, > rx_cfg->rssi_threshold)); > - SET_CHECKED(rf69_set_ook_threshold_dec (dev->spi, > rx_cfg->thresholdDecrement)); > + SET_CHECKED(rf69_set_ook_threshold_dec (dev->spi, > rx_cfg->threshold_decrement)); > SET_CHECKED(rf69_set_bandwidth (dev->spi, > rx_cfg->bw_mantisse, rx_cfg->bw_exponent)); > SET_CHECKED(rf69_set_bandwidth_during_afc(dev->spi, > rx_cfg->bw_mantisse, rx_cfg->bw_exponent)); > SET_CHECKED(rf69_set_dagc(dev->spi, rx_cfg->dagc)); > @@ -254,5 +254,5 @@ rf69_set_tx_cfg(struct pi433_device *dev, struct > pi433_tx_cfg *tx_cfg) > SET_CHECKED(rf69_set_modulation (dev->spi, tx_cfg->modulation)); > SET_CHECKED(rf69_set_deviation (dev->spi, tx_cfg->dev_frequency)); > SET_CHECKED(rf69_set_pa_ramp(dev->spi, tx_cfg->pa_ramp)); > - SET_CHECKED(rf69_set_modulation_shaping(dev->spi, tx_cfg->modShaping)); > + SET_CHECKED(rf69_set_modulation_shaping(dev->spi, tx_cfg->mod_shaping)); > SET_CHECKED(rf69_set_tx_start_condition(dev->spi, > tx_cfg->tx_start_condition)); > > /* packet format enable */ > -- > 2.7.4 > > > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/5] staging/pi433/pi433_if.c:Removed Coding style issues from pi433_if.h and other dependencies arising from it.
Signed-off-by: Rishabh Hardas --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index ed737f4..11c042b 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -192,7 +192,7 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct pi433_rx_cfg *rx_cfg) SET_CHECKED(rf69_set_modulation (dev->spi, rx_cfg->modulation)); SET_CHECKED(rf69_set_antenna_impedance (dev->spi, rx_cfg->antenna_impedance)); SET_CHECKED(rf69_set_rssi_threshold (dev->spi, rx_cfg->rssi_threshold)); - SET_CHECKED(rf69_set_ook_threshold_dec (dev->spi, rx_cfg->thresholdDecrement)); + SET_CHECKED(rf69_set_ook_threshold_dec (dev->spi, rx_cfg->threshold_decrement)); SET_CHECKED(rf69_set_bandwidth (dev->spi, rx_cfg->bw_mantisse, rx_cfg->bw_exponent)); SET_CHECKED(rf69_set_bandwidth_during_afc(dev->spi, rx_cfg->bw_mantisse, rx_cfg->bw_exponent)); SET_CHECKED(rf69_set_dagc(dev->spi, rx_cfg->dagc)); @@ -254,5 +254,5 @@ rf69_set_tx_cfg(struct pi433_device *dev, struct pi433_tx_cfg *tx_cfg) SET_CHECKED(rf69_set_modulation (dev->spi, tx_cfg->modulation)); SET_CHECKED(rf69_set_deviation (dev->spi, tx_cfg->dev_frequency)); SET_CHECKED(rf69_set_pa_ramp(dev->spi, tx_cfg->pa_ramp)); - SET_CHECKED(rf69_set_modulation_shaping(dev->spi, tx_cfg->modShaping)); + SET_CHECKED(rf69_set_modulation_shaping(dev->spi, tx_cfg->mod_shaping)); SET_CHECKED(rf69_set_tx_start_condition(dev->spi, tx_cfg->tx_start_condition)); /* packet format enable */ -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
