[PATCH 3/3] Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

2014-01-09 Thread me
From: Anmol Sarma m...@anmolsarma.in

Fixes the following sparse warnings:
50:14: warning: symbol 'ieee80211_MFIE_rate_len' was not declared. Should it be
static?
68:6: warning: symbol 'ieee80211_MFIE_Brate' was not declared. Should it be
static?
85:6: warning: symbol 'ieee80211_MFIE_Grate' was not declared. Should it be
static?
109:6: warning: symbol 'ieee80211_WMM_Info' was not declared. Should it be
static?
132:6: warning: symbol 'ieee80211_TURBO_Info' was not declared. Should it be
static?
148:6: warning: symbol 'enqueue_mgmt' was not declared. Should it be static?
166:16: warning: symbol 'dequeue_mgmt' was not declared. Should it be static?
181:6: warning: symbol 'init_mgmt_queue' was not declared. Should it be static?
377:6: warning: symbol 'ieee80211_send_beacon' was not declared. Should it be
static?
402:6: warning: symbol 'ieee80211_send_beacon_cb' was not declared. Should it be
static?
413:6: warning: symbol 'ieee80211_send_probe' was not declared. Should it be
static?
425:6: warning: symbol 'ieee80211_send_probe_requests' was not declared. Should
it be static?
436:6: warning: symbol 'ieee80211_softmac_scan_syncro' was not declared. Should
it be static?
574:6: warning: symbol 'ieee80211_softmac_scan_wq' was not declared. Should it
be static?
617:6: warning: symbol 'ieee80211_beacons_start' was not declared. Should it be
static?
629:6: warning: symbol 'ieee80211_beacons_stop' was not declared. Should it be
static?
661:6: warning: symbol 'ieee80211_softmac_stop_scan' was not declared. Should it
be static?
969:16: warning: symbol 'ieee80211_null_func' was not declared. Should it be
static?
995:6: warning: symbol 'ieee80211_resp_to_assoc_rq' was not declared. Should it
be static?
1006:6: warning: symbol 'ieee80211_resp_to_auth' was not declared. Should it be
static?
1017:6: warning: symbol 'ieee80211_resp_to_probe' was not declared. Should it be
static?
1166:6: warning: symbol 'ieee80211_associate_abort_cb' was not declared. Should
it be static?
1172:6: warning: symbol 'ieee80211_associate_step1' was not declared. Should it
be static?
1202:6: warning: symbol 'ieee80211_rtl_auth_challenge' was not declared. Should
it be static?
1237:6: warning: symbol 'ieee80211_associate_step2' was not declared. Should it
be static?
1259:6: warning: symbol 'ieee80211_associate_complete_wq' was not declared.
Should it be
static?
1280:6: warning: symbol 'ieee80211_associate_complete' was not declared. Should
it be static?
1294:6: warning: symbol 'ieee80211_associate_procedure_wq' was not declared.
Should it be static?
1453:5: warning: symbol 'auth_rq_parse' was not declared. Should it be static?
1510:5: warning: symbol 'assoc_rq_parse' was not declared. Should it be static?
1600:7: warning: symbol 'ieee80211_sta_ps_sleep' was not declared. Should it be
static?
2020:6: warning: symbol 'ieee80211_resume_tx' was not declared. Should it be
static?
2150:6: warning: symbol 'ieee80211_start_monitor_mode' was not declared. Should
it be static?
2161:6: warning: symbol 'ieee80211_start_ibss_wq' was not declared. Should it be
static?
2334:6: warning: symbol 'ieee80211_associate_retry_wq' was not declared. Should
it be static?
2626:6: warning: symbol 'ieee80211_wpa_assoc_frame' was not declared. Should it
be static?
1654:13: warning: symbol 'ieee80211_sta_ps' was not declared. Should it be
static?

Signed-off-by: Anmol Sarma m...@anmolsarma.in
---
 .../rtl8187se/ieee80211/ieee80211_softmac.c| 74 +++---
 1 file changed, 37 insertions(+), 37 deletions(-)

diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c 
b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
index 3af1bf9..c27392d 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
@@ -47,7 +47,7 @@ short ieee80211_is_shortslot(const struct ieee80211_network 
*net)
  * tag and the EXTENDED RATE MFIE tag if needed.
  * It encludes two bytes per tag for the tag itself and its len
  */
-unsigned int ieee80211_MFIE_rate_len(struct ieee80211_device *ieee)
+static unsigned int ieee80211_MFIE_rate_len(struct ieee80211_device *ieee)
 {
unsigned int rate_len = 0;
 
@@ -65,7 +65,7 @@ unsigned int ieee80211_MFIE_rate_len(struct ieee80211_device 
*ieee)
  * Then it updates the pointer so that
  * it points after the new MFIE tag added.
  */
-void ieee80211_MFIE_Brate(struct ieee80211_device *ieee, u8 **tag_p)
+static void ieee80211_MFIE_Brate(struct ieee80211_device *ieee, u8 **tag_p)
 {
u8 *tag = *tag_p;
 
@@ -82,7 +82,7 @@ void ieee80211_MFIE_Brate(struct ieee80211_device *ieee, u8 
**tag_p)
*tag_p = tag;
 }
 
-void ieee80211_MFIE_Grate(struct ieee80211_device *ieee, u8 **tag_p)
+static void ieee80211_MFIE_Grate(struct ieee80211_device *ieee, u8 **tag_p)
 {
u8 *tag = *tag_p;
 
@@ -106,7 +106,7 @@ void ieee80211_MFIE_Grate(struct ieee80211_device *ieee, u8 
**tag_p)
 }
 
 
-void ieee80211_WMM_Info(struct ieee80211_device *ieee, u8 

Re: [PATCH 3/3] Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

2014-01-09 Thread Greg KH
On Thu, Jan 09, 2014 at 04:41:07PM +0530, m...@anmolsarma.in wrote:
 From: Anmol Sarma m...@anmolsarma.in
 
 Fixes the following sparse warnings:
 50:14: warning: symbol 'ieee80211_MFIE_rate_len' was not declared. Should it 
 be
 static?
 68:6: warning: symbol 'ieee80211_MFIE_Brate' was not declared. Should it be
 static?

Please don't line-wrap error messages like this, it makes it quite
messy, don't you think?

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH 3/3] Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

2014-01-09 Thread Dan Carpenter
On Thu, Jan 09, 2014 at 04:41:07PM +0530, m...@anmolsarma.in wrote:
 From: Anmol Sarma m...@anmolsarma.in


Fix your email so this is in the email headers themselves.

 
 Fixes the following sparse warnings:
 50:14: warning: symbol 'ieee80211_MFIE_rate_len' was not declared. Should it 
 be
 static?
 68:6: warning: symbol 'ieee80211_MFIE_Brate' was not declared. Should it be
 static?

We don't need so many of these warnings just one or two is enough, we
get the idea.

regards,
dan carpenter


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel