Re: [PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933
On Mon, 10 Dec 2018 21:27:02 +
Jonathan Cameron wrote:
> On Sat, 8 Dec 2018 16:19:59 -0200
> Marcelo Schmitt wrote:
>
> > Add a devicetree documentation for the ad5933 and ad5934 impedance
> > converter, network analyzer.
> >
> > Signed-off-by: Marcelo Schmitt
> > Signed-off-by: Gabriel Capella
> > Co-Developed-by: Gabriel Capella
> Device tree binding patches need to also go to the DT maintainers and list
> for review.
>
> This looks fine to me but they are the specialists in these!
>
> +cc Rob, Mark and DT list.
Long enough I think. This will be in my tree in a fashion I can rebase for
a week or so anyway so please still feel free to comment.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
>
> Jonathan
> > ---
> > .../iio/impedance-analyzer/ad5933.txt | 26 +++
> > 1 file changed, 26 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> > b/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> > new file mode 100644
> > index ..5ff38728ff91
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> > @@ -0,0 +1,26 @@
> > +Analog Devices AD5933/AD5934 Impedance Converter, Network Analyzer
> > +
> > +https://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
> > +https://www.analog.com/media/en/technical-documentation/data-sheets/AD5934.pdf
> > +
> > +Required properties:
> > + - compatible : should be one of
> > + "adi,ad5933"
> > + "adi,ad5934"
> > + - reg : the I2C address.
> > + - vdd-supply : The regulator supply for DVDD, AVDD1 and AVDD2 when they
> > + are connected together.
> > +
> > +Optional properties:
> > +- clocks : external clock reference.
> > +- clock-names : must be "mclk" if clocks is set.
> > +
> > +Example for a I2C device node:
> > +
> > + impedance-analyzer@0d {
> > + compatible = "adi,adxl345";
> > + reg = <0x0d>;
> > + vdd-supply = <_supply>;
> > + clocks = <_clk>;
> > + clock-names = "mclk";
> > + };
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933
On Sat, 8 Dec 2018 16:19:59 -0200
Marcelo Schmitt wrote:
> Add a devicetree documentation for the ad5933 and ad5934 impedance
> converter, network analyzer.
>
> Signed-off-by: Marcelo Schmitt
> Signed-off-by: Gabriel Capella
> Co-Developed-by: Gabriel Capella
Device tree binding patches need to also go to the DT maintainers and list
for review.
This looks fine to me but they are the specialists in these!
+cc Rob, Mark and DT list.
Jonathan
> ---
> .../iio/impedance-analyzer/ad5933.txt | 26 +++
> 1 file changed, 26 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
>
> diff --git
> a/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> b/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> new file mode 100644
> index ..5ff38728ff91
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
> @@ -0,0 +1,26 @@
> +Analog Devices AD5933/AD5934 Impedance Converter, Network Analyzer
> +
> +https://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
> +https://www.analog.com/media/en/technical-documentation/data-sheets/AD5934.pdf
> +
> +Required properties:
> + - compatible : should be one of
> + "adi,ad5933"
> + "adi,ad5934"
> + - reg : the I2C address.
> + - vdd-supply : The regulator supply for DVDD, AVDD1 and AVDD2 when they
> + are connected together.
> +
> +Optional properties:
> +- clocks : external clock reference.
> +- clock-names : must be "mclk" if clocks is set.
> +
> +Example for a I2C device node:
> +
> + impedance-analyzer@0d {
> + compatible = "adi,adxl345";
> + reg = <0x0d>;
> + vdd-supply = <_supply>;
> + clocks = <_clk>;
> + clock-names = "mclk";
> + };
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933
Add a devicetree documentation for the ad5933 and ad5934 impedance
converter, network analyzer.
Signed-off-by: Marcelo Schmitt
Signed-off-by: Gabriel Capella
Co-Developed-by: Gabriel Capella
---
.../iio/impedance-analyzer/ad5933.txt | 26 +++
1 file changed, 26 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
diff --git
a/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
b/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
new file mode 100644
index ..5ff38728ff91
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
@@ -0,0 +1,26 @@
+Analog Devices AD5933/AD5934 Impedance Converter, Network Analyzer
+
+https://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
+https://www.analog.com/media/en/technical-documentation/data-sheets/AD5934.pdf
+
+Required properties:
+ - compatible : should be one of
+ "adi,ad5933"
+ "adi,ad5934"
+ - reg : the I2C address.
+ - vdd-supply : The regulator supply for DVDD, AVDD1 and AVDD2 when they
+ are connected together.
+
+Optional properties:
+- clocks : external clock reference.
+- clock-names : must be "mclk" if clocks is set.
+
+Example for a I2C device node:
+
+ impedance-analyzer@0d {
+ compatible = "adi,adxl345";
+ reg = <0x0d>;
+ vdd-supply = <_supply>;
+ clocks = <_clk>;
+ clock-names = "mclk";
+ };
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
