Re: [PATCH 3/3] staging: rtl8188eu: rename variable isCCKrate - style

2018-10-21 Thread Michael Straube 

On 10/21/18 2:26 PM, Joe Perches wrote:

It would be sensible to convert is_cck_rate from u8 to bool at the
same
time and remove the ternary ? true : false too.

As well, perhaps remove its apparently unnecessary initialization.




I've added a patch and resent the series. Thank you.

Michael
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] staging: rtl8188eu: rename variable isCCKrate - style

2018-10-21 Thread Joe Perches 
On Sat, 2018-10-20 at 13:08 +0200, Michael Straube wrote:
> Rename the variable isCCKrate to avoid CamelCase.
> isCCKrate -> is_cck_rate
[]
> diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c 
> b/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
[]
> @@ -71,19 +71,20 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct 
> odm_dm_struct *dm_odm,
>   s8 rx_pwr[4], rx_pwr_all = 0;
>   u8 EVM, PWDB_ALL = 0, PWDB_ALL_BT;
>   u8 RSSI, total_rssi = 0;
> - u8 isCCKrate = 0;
> + u8 is_cck_rate = 0;
>   u8 rf_rx_num = 0;
>   u8 cck_highpwr = 0;
>   u8 LNA_idx, VGA_idx;
>  
>   struct phy_status_rpt *pPhyStaRpt = (struct phy_status_rpt *)pPhyStatus;
>  
> - isCCKrate = ((pPktinfo->Rate >= DESC92C_RATE1M) && (pPktinfo->Rate <= 
> DESC92C_RATE11M)) ? true : false;
> + is_cck_rate = ((pPktinfo->Rate >= DESC92C_RATE1M) &&
> +(pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;

It would be sensible to convert is_cck_rate from u8 to bool at the
same
time and remove the ternary ? true : false too.

As well, perhaps remove its apparently unnecessary initialization.


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/3] staging: rtl8188eu: rename variable isCCKrate - style

2018-10-20 Thread Michael Straube 
Rename the variable isCCKrate to avoid CamelCase.
isCCKrate -> is_cck_rate

Signed-off-by: Michael Straube 
---
 drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 16 +---
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c 
b/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
index d7bdbb141b2b..5d72d7f6d05f 100644
--- a/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
+++ b/drivers/staging/rtl8188eu/hal/odm_hwconfig.c
@@ -71,19 +71,20 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct 
odm_dm_struct *dm_odm,
s8 rx_pwr[4], rx_pwr_all = 0;
u8 EVM, PWDB_ALL = 0, PWDB_ALL_BT;
u8 RSSI, total_rssi = 0;
-   u8 isCCKrate = 0;
+   u8 is_cck_rate = 0;
u8 rf_rx_num = 0;
u8 cck_highpwr = 0;
u8 LNA_idx, VGA_idx;
 
struct phy_status_rpt *pPhyStaRpt = (struct phy_status_rpt *)pPhyStatus;
 
-   isCCKrate = ((pPktinfo->Rate >= DESC92C_RATE1M) && (pPktinfo->Rate <= 
DESC92C_RATE11M)) ? true : false;
+   is_cck_rate = ((pPktinfo->Rate >= DESC92C_RATE1M) &&
+  (pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;
 
pPhyInfo->RxMIMOSignalQuality[RF_PATH_A] = -1;
pPhyInfo->RxMIMOSignalQuality[RF_PATH_B] = -1;
 
-   if (isCCKrate) {
+   if (is_cck_rate) {
u8 cck_agc_rpt;
 
dm_odm->PhyDbgInfo.NumQryPhyStatusCCK++;
@@ -234,7 +235,7 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct 
odm_dm_struct *dm_odm,
}
/* UI BSS List signal strength(in percentage), make it good looking, 
from 0~100. */
/* It is assigned to the BSS List in GetValueFromBeaconOrProbeRsp(). */
-   if (isCCKrate) {
+   if (is_cck_rate) {
pPhyInfo->SignalStrength = 
(u8)(odm_signal_scale_mapping(dm_odm, PWDB_ALL));/* PWDB_ALL; */
} else {
if (rf_rx_num != 0)
@@ -255,7 +256,7 @@ static void odm_Process_RSSIForDM(struct odm_dm_struct 
*dm_odm,
 {
s32 UndecoratedSmoothedPWDB, UndecoratedSmoothedCCK;
s32 UndecoratedSmoothedOFDM, RSSI_Ave;
-   u8 isCCKrate = 0;
+   u8 is_cck_rate = 0;
u8 RSSI_max, RSSI_min, i;
u32 OFDM_pkt = 0;
u32 Weighting = 0;
@@ -271,7 +272,8 @@ static void odm_Process_RSSIForDM(struct odm_dm_struct 
*dm_odm,
if ((!pPktinfo->bPacketMatchBSSID))
return;
 
-   isCCKrate = ((pPktinfo->Rate >= DESC92C_RATE1M) && (pPktinfo->Rate <= 
DESC92C_RATE11M)) ? true : false;
+   is_cck_rate = ((pPktinfo->Rate >= DESC92C_RATE1M) &&
+  (pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;
 
/* Smart Antenna Debug Message--  */
 
@@ -299,7 +301,7 @@ static void odm_Process_RSSIForDM(struct odm_dm_struct 
*dm_odm,
UndecoratedSmoothedPWDB = pEntry->rssi_stat.UndecoratedSmoothedPWDB;
 
if (pPktinfo->bPacketToSelf || pPktinfo->bPacketBeacon) {
-   if (!isCCKrate) { /* ofdm rate */
+   if (!is_cck_rate) { /* ofdm rate */
if (pPhyInfo->RxMIMOSignalStrength[RF_PATH_B] == 0) {
RSSI_Ave = 
pPhyInfo->RxMIMOSignalStrength[RF_PATH_A];
} else {
-- 
2.19.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel