Re: [PATCH 3/4] staging: imx-hdmi: clear all hotplug IRQs on bind

2014-04-13 Thread Russell King - ARM Linux 
On Fri, Apr 11, 2014 at 04:13:34PM +0200, Lucas Stach wrote:
 Makes sure we don't receive a stray IRQ on startup.
 
 Signed-off-by: Lucas Stach l.st...@pengutronix.de
 ---
  drivers/staging/imx-drm/imx-hdmi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/staging/imx-drm/imx-hdmi.c 
 b/drivers/staging/imx-drm/imx-hdmi.c
 index 22cfdfc5ef74..7d407e917786 100644
 --- a/drivers/staging/imx-drm/imx-hdmi.c
 +++ b/drivers/staging/imx-drm/imx-hdmi.c
 @@ -1705,7 +1705,7 @@ static int imx_hdmi_bind(struct device *dev, struct 
 device *master, void *data)
   hdmi_writeb(hdmi, hdmi-sink_detect_polarity, HDMI_PHY_POL0);
  
   /* Clear Hotplug interrupts */
 - hdmi_writeb(hdmi, hdmi-sink_detect_status, HDMI_IH_PHY_STAT0);
 + hdmi_writeb(hdmi, 0x3d, HDMI_IH_PHY_STAT0);

If we are only unmasking hdmi-sink_detect_status interrupts via a
write to HDMI_IH_MUTE_PHY_STAT0, then why do we need to clear these other
interrupts?  Please add additional explanation to the commit message
giving the reasoning for this change.

Thanks.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/4] staging: imx-hdmi: clear all hotplug IRQs on bind

2014-04-11 Thread Lucas Stach 
Makes sure we don't receive a stray IRQ on startup.

Signed-off-by: Lucas Stach l.st...@pengutronix.de
---
 drivers/staging/imx-drm/imx-hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/imx-drm/imx-hdmi.c 
b/drivers/staging/imx-drm/imx-hdmi.c
index 22cfdfc5ef74..7d407e917786 100644
--- a/drivers/staging/imx-drm/imx-hdmi.c
+++ b/drivers/staging/imx-drm/imx-hdmi.c
@@ -1705,7 +1705,7 @@ static int imx_hdmi_bind(struct device *dev, struct 
device *master, void *data)
hdmi_writeb(hdmi, hdmi-sink_detect_polarity, HDMI_PHY_POL0);
 
/* Clear Hotplug interrupts */
-   hdmi_writeb(hdmi, hdmi-sink_detect_status, HDMI_IH_PHY_STAT0);
+   hdmi_writeb(hdmi, 0x3d, HDMI_IH_PHY_STAT0);
 
ret = imx_hdmi_fb_registered(hdmi);
if (ret)
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel