[PATCH 3/5] staging: fsl-mc/dpio: Use __leXX types where needed

[Ioana Radulescu]

Structures that are mapped to hardware registers should explicitly
specify the expected endianness for fields larger than 1 byte.

Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
 drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 16 ++++++++--------
 drivers/staging/fsl-mc/bus/dpio/qbman-portal.h | 24 ++++++++++++------------
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c 
b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
index 7b75c93..377f4d9 100644
--- a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
+++ b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
@@ -830,7 +830,7 @@ int qbman_swp_release(struct qbman_swp *s, const struct 
qbman_release_desc *d,
 struct qbman_acquire_desc {
        u8 verb;
        u8 reserved;
-       u16 bpid;
+       __le16 bpid;
        u8 num;
        u8 reserved2[59];
 };
@@ -838,10 +838,10 @@ struct qbman_acquire_desc {
 struct qbman_acquire_rslt {
        u8 verb;
        u8 rslt;
-       u16 reserved;
+       __le16 reserved;
        u8 num;
        u8 reserved2[3];
-       u64 buf[7];
+       __le64 buf[7];
 };
 
 /**
@@ -904,7 +904,7 @@ int qbman_swp_acquire(struct qbman_swp *s, u16 bpid, u64 
*buffers,
 struct qbman_alt_fq_state_desc {
        u8 verb;
        u8 reserved[3];
-       u32 fqid;
+       __le32 fqid;
        u8 reserved2[56];
 };
 
@@ -953,11 +953,11 @@ int qbman_swp_alt_fq_state(struct qbman_swp *s, u32 fqid,
 struct qbman_cdan_ctrl_desc {
        u8 verb;
        u8 reserved;
-       u16 ch;
+       __le16 ch;
        u8 we;
        u8 ctrl;
-       u16 reserved2;
-       u64 cdan_ctx;
+       __le16 reserved2;
+       __le64 cdan_ctx;
        u8 reserved3[48];
 
 };
@@ -965,7 +965,7 @@ struct qbman_cdan_ctrl_desc {
 struct qbman_cdan_ctrl_rslt {
        u8 verb;
        u8 rslt;
-       u16 ch;
+       __le16 ch;
        u8 reserved[60];
 };
 
diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.h 
b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.h
index fb8b9d3..4488a44 100644
--- a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.h
+++ b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.h
@@ -32,8 +32,8 @@ struct qbman_pull_desc {
        u8 numf;
        u8 tok;
        u8 reserved;
-       u32 dq_src;
-       u64 rsp_addr;
+       __le32 dq_src;
+       __le64 rsp_addr;
        u64 rsp_addr_virt;
        u8 padding[40];
 };
@@ -70,17 +70,17 @@ enum qbman_pull_type_e {
 struct qbman_eq_desc {
        u8 verb;
        u8 dca;
-       u16 seqnum;
-       u16 orpid;
-       u16 reserved1;
-       u32 tgtid;
-       u32 tag;
-       u16 qdbin;
+       __le16 seqnum;
+       __le16 orpid;
+       __le16 reserved1;
+       __le32 tgtid;
+       __le32 tag;
+       __le16 qdbin;
        u8 qpri;
        u8 reserved[3];
        u8 wae;
        u8 rspid;
-       u64 rsp_addr;
+       __le64 rsp_addr;
        u8 fd[32];
 };
 
@@ -88,9 +88,9 @@ struct qbman_eq_desc {
 struct qbman_release_desc {
        u8 verb;
        u8 reserved;
-       u16 bpid;
-       u32 reserved2;
-       u64 buf[7];
+       __le16 bpid;
+       __le32 reserved2;
+       __le64 buf[7];
 };
 
 /* Management command result codes */
-- 
2.7.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel