Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

[Greg KH]

On Wed, Jan 17, 2018 at 03:56:19PM +, Bogdan Purcareata wrote:
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Tuesday, January 16, 2018 5:13 PM
> > To: Bogdan Purcareata <bogdan.purcare...@nxp.com>
> > Cc: Laurentiu Tudor <laurentiu.tu...@nxp.com>; Ruxandra Ioana Ciocoi 
> > Radulescu
> > <ruxandra.radule...@nxp.com>; de...@driverdev.osuosl.org; r...@kernel.org;
> > stuyo...@gmail.com; a...@arndb.de; marc.zyng...@arm.com; Roy Pledge
> > <roy.ple...@nxp.com>; Ioana Ciornei <ioana.cior...@nxp.com>; linux-
> > ker...@vger.kernel.org; Horia Geantă <horia.gea...@nxp.com>; Nipun Gupta
> > <nipun.gu...@nxp.com>; t...@linutronix.de; linux-arm-
> > ker...@lists.infradead.org; ja...@lakedaemon.net
> > Subject: Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers
> > 
> > On Tue, Jan 16, 2018 at 03:19:05PM +0200, Bogdan Purcareata wrote:
> > > diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h b/drivers/staging/fsl-
> > mc/bus/dpbp-cmd.h
> > > index 5904836..1ac8ec6 100644
> > > --- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> > > +++ b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> > > @@ -1,33 +1,8 @@
> > > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> > 
> > Hm, I don't think you want to do that.  How can a Linux driver subsytem
> > that wraps calls to the kernel's driver core (which are GPL-only), be
> > accessed by BSD-3 code?
> 
> For this particular file, the original license was dual GPL/BSD. The
> patch removes the license text and adds an equivalent SPDX tag.

Argh, I picked the wrong file. Ment to pick the fsl-mc-bus.c file, which
you also marked with a dual license, despite it not having that before.
Sorry for that confusion.

> > If I didn't know any better, I would think you were trying to create a
> > "GPL Condom" here :)
> > 
> > Anyway, why all of the BSD-3 stuff here?  That makes no sense for kernel
> > code at all, and this is a relicensing of the file, have you gotten
> > legal approval of everyone that has modified the file while it was under
> > the GPL-v2 only text to be able to change it to BSD-3 as well?
> 
> Previous to this patch, the files under drivers/staging/fsl-mc/ use a 
> combination of GPL-2.0 and (GPL-2.0+ / BSD-3-Clause) licenses (expressed by 
> the full license text). 
> 
> The original intent was to have an uniform dual license for all files. Before 
> making this change, I have consulted the other current contributors, but 
> based on your feedback, we think it's best to keep the current licenses.

Thank you.

Also you can have a few free '\n' characters for your email editor :)

> > Careful, this is a _VERY_ tricky thing to do right.  I need a
> > signed-off-by on this type of patch from your legal council to ensure
> > that they know exactly what you are doing, and have reviewed it
> > properly, before I can take it.
> > 
> > Hint, stick to the existing license in the files, it makes more sense,
> > you are not going to be taking this code out of Linux and putting it
> > anywhere.
> 
> I will send a v2 keeping the existing license for each file - removing the 
> full license text and adding a SPDX tag. This way there will be no change 
> from a legal standpoint.

That's great, thanks.

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

[Bogdan Purcareata]

> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, January 16, 2018 5:13 PM
> To: Bogdan Purcareata <bogdan.purcare...@nxp.com>
> Cc: Laurentiu Tudor <laurentiu.tu...@nxp.com>; Ruxandra Ioana Ciocoi Radulescu
> <ruxandra.radule...@nxp.com>; de...@driverdev.osuosl.org; r...@kernel.org;
> stuyo...@gmail.com; a...@arndb.de; marc.zyng...@arm.com; Roy Pledge
> <roy.ple...@nxp.com>; Ioana Ciornei <ioana.cior...@nxp.com>; linux-
> ker...@vger.kernel.org; Horia Geantă <horia.gea...@nxp.com>; Nipun Gupta
> <nipun.gu...@nxp.com>; t...@linutronix.de; linux-arm-
> ker...@lists.infradead.org; ja...@lakedaemon.net
> Subject: Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers
> 
> On Tue, Jan 16, 2018 at 03:19:05PM +0200, Bogdan Purcareata wrote:
> > diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h b/drivers/staging/fsl-
> mc/bus/dpbp-cmd.h
> > index 5904836..1ac8ec6 100644
> > --- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> > +++ b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> > @@ -1,33 +1,8 @@
> > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> 
> Hm, I don't think you want to do that.  How can a Linux driver subsytem
> that wraps calls to the kernel's driver core (which are GPL-only), be
> accessed by BSD-3 code?

For this particular file, the original license was dual GPL/BSD. The patch 
removes the license text and adds an equivalent SPDX tag.

> If I didn't know any better, I would think you were trying to create a
> "GPL Condom" here :)
> 
> Anyway, why all of the BSD-3 stuff here?  That makes no sense for kernel
> code at all, and this is a relicensing of the file, have you gotten
> legal approval of everyone that has modified the file while it was under
> the GPL-v2 only text to be able to change it to BSD-3 as well?

Previous to this patch, the files under drivers/staging/fsl-mc/ use a 
combination of GPL-2.0 and (GPL-2.0+ / BSD-3-Clause) licenses (expressed by the 
full license text). 

The original intent was to have an uniform dual license for all files. Before 
making this change, I have consulted the other current contributors, but based 
on your feedback, we think it's best to keep the current licenses.

> Careful, this is a _VERY_ tricky thing to do right.  I need a
> signed-off-by on this type of patch from your legal council to ensure
> that they know exactly what you are doing, and have reviewed it
> properly, before I can take it.
> 
> Hint, stick to the existing license in the files, it makes more sense,
> you are not going to be taking this code out of Linux and putting it
> anywhere.

I will send a v2 keeping the existing license for each file - removing the full 
license text and adding a SPDX tag. This way there will be no change from a 
legal standpoint.

Thank you for the feedback!

Bogdan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

[Greg KH]

On Tue, Jan 16, 2018 at 03:19:05PM +0200, Bogdan Purcareata wrote:
> diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h 
> b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> index 5904836..1ac8ec6 100644
> --- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> +++ b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> @@ -1,33 +1,8 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */

Hm, I don't think you want to do that.  How can a Linux driver subsytem
that wraps calls to the kernel's driver core (which are GPL-only), be
accessed by BSD-3 code?

If I didn't know any better, I would think you were trying to create a
"GPL Condom" here :)

Anyway, why all of the BSD-3 stuff here?  That makes no sense for kernel
code at all, and this is a relicensing of the file, have you gotten
legal approval of everyone that has modified the file while it was under
the GPL-v2 only text to be able to change it to BSD-3 as well?

Careful, this is a _VERY_ tricky thing to do right.  I need a
signed-off-by on this type of patch from your legal council to ensure
that they know exactly what you are doing, and have reviewed it
properly, before I can take it.

Hint, stick to the existing license in the files, it makes more sense,
you are not going to be taking this code out of Linux and putting it
anywhere.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

[Bogdan Purcareata]

The fsl-mc bus and dpio driver files use a combination of GPL-2.0 and
GPL-2.0+ OR BSD-3-Clause licenses. Update to latter for all files. Add SPDX
tags and delete the full license text. Update copyright information.

Signed-off-by: Bogdan Purcareata 
Reviewed-by: Laurentiu Tudor 
---
 drivers/staging/fsl-mc/Kconfig |  1 +
 drivers/staging/fsl-mc/Makefile|  1 +
 drivers/staging/fsl-mc/bus/Kconfig |  3 +-
 drivers/staging/fsl-mc/bus/Makefile|  3 +-
 drivers/staging/fsl-mc/bus/dpbp-cmd.h  | 29 ++-
 drivers/staging/fsl-mc/bus/dpbp.c  | 29 ++-
 drivers/staging/fsl-mc/bus/dpcon-cmd.h | 29 ++-
 drivers/staging/fsl-mc/bus/dpcon.c | 33 +++---
 drivers/staging/fsl-mc/bus/dpio/Makefile   |  1 +
 drivers/staging/fsl-mc/bus/dpio/dpio-cmd.h | 30 ++--
 drivers/staging/fsl-mc/bus/dpio/dpio-driver.c  | 29 ++-
 drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 29 ++-
 drivers/staging/fsl-mc/bus/dpio/dpio.c | 30 ++--
 drivers/staging/fsl-mc/bus/dpio/dpio.h | 30 ++--
 drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 29 ++-
 drivers/staging/fsl-mc/bus/dpio/qbman-portal.h | 29 ++-
 drivers/staging/fsl-mc/bus/dpmcp.c | 29 ++-
 drivers/staging/fsl-mc/bus/dprc-driver.c   |  5 ++--
 drivers/staging/fsl-mc/bus/dprc.c  | 29 ++-
 drivers/staging/fsl-mc/bus/fsl-mc-allocator.c  |  5 ++--
 drivers/staging/fsl-mc/bus/fsl-mc-bus.c|  5 ++--
 drivers/staging/fsl-mc/bus/fsl-mc-msi.c|  5 ++--
 drivers/staging/fsl-mc/bus/fsl-mc-private.h|  5 ++--
 .../staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c |  5 ++--
 drivers/staging/fsl-mc/bus/mc-io.c | 29 ++-
 drivers/staging/fsl-mc/bus/mc-sys.c| 29 ++-
 drivers/staging/fsl-mc/include/dpaa2-fd.h  | 29 ++-
 drivers/staging/fsl-mc/include/dpaa2-global.h  | 29 ++-
 drivers/staging/fsl-mc/include/dpaa2-io.h  | 29 ++-
 drivers/staging/fsl-mc/include/dpbp.h  | 30 ++--
 drivers/staging/fsl-mc/include/dpcon.h | 33 +++---
 drivers/staging/fsl-mc/include/mc.h|  5 ++--
 32 files changed, 63 insertions(+), 573 deletions(-)

diff --git a/drivers/staging/fsl-mc/Kconfig b/drivers/staging/fsl-mc/Kconfig
index 32df07b..d4bab69 100644
--- a/drivers/staging/fsl-mc/Kconfig
+++ b/drivers/staging/fsl-mc/Kconfig
@@ -1 +1,2 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
 source "drivers/staging/fsl-mc/bus/Kconfig"
diff --git a/drivers/staging/fsl-mc/Makefile b/drivers/staging/fsl-mc/Makefile
index 9c6a001..d717b41 100644
--- a/drivers/staging/fsl-mc/Makefile
+++ b/drivers/staging/fsl-mc/Makefile
@@ -1,2 +1,3 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
 # Freescale Management Complex (MC) bus drivers
 obj-$(CONFIG_FSL_MC_BUS)   += bus/
diff --git a/drivers/staging/fsl-mc/bus/Kconfig 
b/drivers/staging/fsl-mc/bus/Kconfig
index 504c987..9adb2a6 100644
--- a/drivers/staging/fsl-mc/bus/Kconfig
+++ b/drivers/staging/fsl-mc/bus/Kconfig
@@ -1,10 +1,9 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
 #
 # DPAA2 fsl-mc bus
 #
 # Copyright (C) 2014-2016 Freescale Semiconductor, Inc.
 #
-# This file is released under the GPLv2
-#
 
 config FSL_MC_BUS
bool "QorIQ DPAA2 fsl-mc bus driver"
diff --git a/drivers/staging/fsl-mc/bus/Makefile 
b/drivers/staging/fsl-mc/bus/Makefile
index 6df407e..cdf319f 100644
--- a/drivers/staging/fsl-mc/bus/Makefile
+++ b/drivers/staging/fsl-mc/bus/Makefile
@@ -1,10 +1,9 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
 #
 # Freescale Management Complex (MC) bus drivers
 #
 # Copyright (C) 2014 Freescale Semiconductor, Inc.
 #
-# This file is released under the GPLv2
-#
 obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
 
 mc-bus-driver-objs := fsl-mc-bus.o \
diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h 
b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
index 5904836..1ac8ec6 100644
--- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
+++ b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
@@ -1,33 +1,8 @@
+/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
 /*
  * Copyright 2013-2016 Freescale Semiconductor Inc.
+ * Copyright 2016-2017 NXP
  *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are met:
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must