Re: [PATCH 31/35] staging: lustre: obdclass: add export for lprocfs_stats_alloc_one()

[Greg Kroah-Hartman]

On Thu, Nov 10, 2016 at 12:31:01PM -0500, James Simmons wrote:
> From: Chennaiah Palla 
> 
> When compiling the kernel without optimization, when using GCOV,
> the lprocfs_stats_alloc_one() symbol is not properly exported to
> other modules and causes the ptlrpc module to fail loading with
> an unknown symbol. Added EXPORT_SYMBOL(lprocfs_stats_alloc_one)
> so that this works properly.

No, let's fix this properly.  Please get rid of lprocfs_stats_lock(), or
if you _really_ need it, move it to a .c file.  Having it in a .h file
is just a mess, as this proves.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 31/35] staging: lustre: obdclass: add export for lprocfs_stats_alloc_one()

[James Simmons]

From: Chennaiah Palla 

When compiling the kernel without optimization, when using GCOV,
the lprocfs_stats_alloc_one() symbol is not properly exported to
other modules and causes the ptlrpc module to fail loading with
an unknown symbol. Added EXPORT_SYMBOL(lprocfs_stats_alloc_one)
so that this works properly.

Signed-off-by: Chennaiah Palla 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7515
Seagate-bug-id: MRP-3188
Reviewed-on: http://review.whamcloud.com/17443
Reviewed-by: Andreas Dilger 
Reviewed-by: James Simmons 
Reviewed-by: Oleg Drokin 
Signed-off-by: James Simmons 
---
 .../lustre/lustre/obdclass/lprocfs_status.c|1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c 
b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 8a2f02f..749 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -1052,6 +1052,7 @@ int lprocfs_stats_alloc_one(struct lprocfs_stats *stats, 
unsigned int cpuid)
}
return rc;
 }
+EXPORT_SYMBOL(lprocfs_stats_alloc_one);
 
 struct lprocfs_stats *lprocfs_alloc_stats(unsigned int num,
  enum lprocfs_stats_flags flags)
-- 
1.7.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel