Re: [PATCH 4/8] staging: gasket: core: device register debug log cleanups

[Greg Kroah-Hartman]

On Thu, Aug 02, 2018 at 01:42:41AM -0700, Todd Poynor wrote:
> From: Todd Poynor 
> 
> At device/driver registration time, convert a not-very-informative
> info message to a more informative dbeug message, drop some not overly
> helpful debug messages.
> 
> Signed-off-by: Todd Poynor 
> ---
>  drivers/staging/gasket/gasket_core.c | 7 ++-
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/gasket/gasket_core.c 
> b/drivers/staging/gasket/gasket_core.c
> index 2160c2de78e77..36c077fffc41c 100644
> --- a/drivers/staging/gasket/gasket_core.c
> +++ b/drivers/staging/gasket/gasket_core.c
> @@ -1736,7 +1736,8 @@ int gasket_register_device(const struct 
> gasket_driver_desc *driver_desc)
>   int desc_idx = -1;
>   struct gasket_internal_desc *internal;
>  
> - pr_info("Initializing Gasket framework device\n");
> + pr_debug("gasket: Loading %s driver version %s\n", driver_desc->name,

Again, pr_fmt is your friend :)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 4/8] staging: gasket: core: device register debug log cleanups

[Todd Poynor]

From: Todd Poynor 

At device/driver registration time, convert a not-very-informative
info message to a more informative dbeug message, drop some not overly
helpful debug messages.

Signed-off-by: Todd Poynor 
---
 drivers/staging/gasket/gasket_core.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/gasket/gasket_core.c 
b/drivers/staging/gasket/gasket_core.c
index 2160c2de78e77..36c077fffc41c 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -1736,7 +1736,8 @@ int gasket_register_device(const struct 
gasket_driver_desc *driver_desc)
int desc_idx = -1;
struct gasket_internal_desc *internal;
 
-   pr_info("Initializing Gasket framework device\n");
+   pr_debug("gasket: Loading %s driver version %s\n", driver_desc->name,
+driver_desc->driver_version);
/* Check for duplicates and find a free slot. */
mutex_lock(_mutex);
 
@@ -1765,8 +1766,6 @@ int gasket_register_device(const struct 
gasket_driver_desc *driver_desc)
return -EBUSY;
}
 
-   /* Internal structure setup. */
-   pr_debug("Performing initial internal structure setup.\n");
internal = _descs[desc_idx];
mutex_init(>mutex);
memset(internal->devs, 0, sizeof(struct gasket_dev *) * GASKET_DEV_MAX);
@@ -1789,7 +1788,6 @@ int gasket_register_device(const struct 
gasket_driver_desc *driver_desc)
 * Not using pci_register_driver() (without underscores), as it
 * depends on KBUILD_MODNAME, and this is a shared file.
 */
-   pr_debug("Registering PCI driver.\n");
ret = __pci_register_driver(>pci, driver_desc->module,
driver_desc->name);
if (ret) {
@@ -1797,7 +1795,6 @@ int gasket_register_device(const struct 
gasket_driver_desc *driver_desc)
goto fail1;
}
 
-   pr_debug("Registering char driver.\n");
ret = register_chrdev_region(MKDEV(driver_desc->major,
   driver_desc->minor), GASKET_DEV_MAX,
 driver_desc->name);
-- 
2.18.0.597.ga71716f1ad-goog

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel