Re: [PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE_OOK value

2017-12-13 Thread Dan Carpenter 
On Wed, Dec 13, 2017 at 03:21:53PM +0100, Valentin Vidic wrote:
> Reading from the spec, allowed values for modulation scheme
> after the shift are:
> 
>   00 FSK
>   01 OOK
>   10 - 11 reserved
> 
> Signed-off-by: Valentin Vidic 
> ---
>  drivers/staging/pi433/rf69_registers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/pi433/rf69_registers.h 
> b/drivers/staging/pi433/rf69_registers.h
> index 33fd91518bb0..981b57d7cc0b 100644
> --- a/drivers/staging/pi433/rf69_registers.h
> +++ b/drivers/staging/pi433/rf69_registers.h
> @@ -130,7 +130,7 @@
>  #define  DATAMODUL_MODE_CONTINUOUS_NOSYNC0x60
>  
>  #define  DATAMODUL_MODULATION_TYPE_FSK   0x00 /* default */
> -#define  DATAMODUL_MODULATION_TYPE_OOK   0x08
> +#define  DATAMODUL_MODULATION_TYPE_OOK   0x01

Look how DATAMODUL_MODULATION_TYPE_OOK is used (in linux-next).  We
removed the shift.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE_OOK value

2017-12-13 Thread Valentin Vidic 
Reading from the spec, allowed values for modulation scheme
after the shift are:

  00 FSK
  01 OOK
  10 - 11 reserved

Signed-off-by: Valentin Vidic 
---
 drivers/staging/pi433/rf69_registers.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/pi433/rf69_registers.h 
b/drivers/staging/pi433/rf69_registers.h
index 33fd91518bb0..981b57d7cc0b 100644
--- a/drivers/staging/pi433/rf69_registers.h
+++ b/drivers/staging/pi433/rf69_registers.h
@@ -130,7 +130,7 @@
 #define  DATAMODUL_MODE_CONTINUOUS_NOSYNC  0x60
 
 #define  DATAMODUL_MODULATION_TYPE_FSK 0x00 /* default */
-#define  DATAMODUL_MODULATION_TYPE_OOK 0x08
+#define  DATAMODUL_MODULATION_TYPE_OOK 0x01
 
 #define  DATAMODUL_MODULATION_SHAPE_NONE   0x00 /* default */
 #define  DATAMODUL_MODULATION_SHAPE_1_00x01
-- 
2.15.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel