Re: [PATCH 6/6] staging: comedi: addi_apci_2032: remove use of devpriv->s_EeParameters

[Chase Southwood]

Hartley,

Ah geez...my brain got all tangled looking at old git commits for
other addi-data drivers.  I apologize for this silly mistake.  I'll
fix that title and send a new version of the patchset tomorrow.

Thanks,
Chase

On Mon, Apr 28, 2014 at 12:59 PM, Hartley Sweeten
 wrote:
> On Saturday, April 26, 2014 6:39 PM, Chase Southwood wrote:
>> This driver no longer reads the eeprom to find the board specific data,
>> all the necessary data is in the boardinfo. Use the boardinfo directly
>> instead of passing through devpriv->s_EeParameters.
>>
>> Signed-off-by: Chase Southwood 
>> Cc: Ian Abbott 
>> Cc: H Hartley Sweeten 
>
> Chase,
>
> The subject does not match the patch.
>
> Regards,
> Hartley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 6/6] staging: comedi: addi_apci_2032: remove use of devpriv->s_EeParameters

[Hartley Sweeten]

On Saturday, April 26, 2014 6:39 PM, Chase Southwood wrote:
> This driver no longer reads the eeprom to find the board specific data,
> all the necessary data is in the boardinfo. Use the boardinfo directly
> instead of passing through devpriv->s_EeParameters.
>
> Signed-off-by: Chase Southwood 
> Cc: Ian Abbott 
> Cc: H Hartley Sweeten 

Chase,

The subject does not match the patch.

Regards,
Hartley
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 6/6] staging: comedi: addi_apci_2032: remove use of devpriv->s_EeParameters

[Chase Southwood]

This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv->s_EeParameters.

Signed-off-by: Chase Southwood 
Cc: Ian Abbott 
Cc: H Hartley Sweeten 
---
Ian and Hartley,

The auto_attach() function is starting to look much better now.  My next 
patchset
will be geared towards only allocating subdevices which are actually used.

Thanks,
Chase

 drivers/staging/comedi/drivers/addi_apci_1564.c | 27 +
 1 file changed, 5 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c 
b/drivers/staging/comedi/drivers/addi_apci_1564.c
index d5be8d3..b34ae34 100644
--- a/drivers/staging/comedi/drivers/addi_apci_1564.c
+++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
@@ -65,22 +65,6 @@ static int apci1564_auto_attach(struct comedi_device *dev,
dev->iobase = pci_resource_start(pcidev, 2);
devpriv->i_IobaseAmcc = pci_resource_start(pcidev, 1);
 
-   /* Initialize parameters that can be overridden in EEPROM */
-   devpriv->s_EeParameters.i_NbrAiChannel = this_board->i_NbrAiChannel;
-   devpriv->s_EeParameters.i_NbrAoChannel = this_board->i_NbrAoChannel;
-   devpriv->s_EeParameters.i_AiMaxdata = this_board->i_AiMaxdata;
-   devpriv->s_EeParameters.i_AoMaxdata = this_board->i_AoMaxdata;
-   devpriv->s_EeParameters.i_NbrDiChannel = this_board->i_NbrDiChannel;
-   devpriv->s_EeParameters.i_NbrDoChannel = this_board->i_NbrDoChannel;
-   devpriv->s_EeParameters.i_DoMaxdata = this_board->i_DoMaxdata;
-   devpriv->s_EeParameters.i_Timer = this_board->i_Timer;
-   devpriv->s_EeParameters.ui_MinAcquisitiontimeNs =
-   this_board->ui_MinAcquisitiontimeNs;
-   devpriv->s_EeParameters.ui_MinDelaytimeNs =
-   this_board->ui_MinDelaytimeNs;
-
-   /* ## */
-
if (pcidev->irq > 0) {
ret = request_irq(pcidev->irq, v_ADDI_Interrupt, IRQF_SHARED,
  dev->board_name, dev);
@@ -114,14 +98,13 @@ static int apci1564_auto_attach(struct comedi_device *dev,
 
/*  Allocate and Initialise DO Subdevice Structures */
s = &dev->subdevices[3];
-   if (devpriv->s_EeParameters.i_NbrDoChannel) {
+   if (this_board->i_NbrDoChannel) {
s->type = COMEDI_SUBD_DO;
s->subdev_flags =
SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
-   s->n_chan = devpriv->s_EeParameters.i_NbrDoChannel;
-   s->maxdata = devpriv->s_EeParameters.i_DoMaxdata;
-   s->len_chanlist =
-   devpriv->s_EeParameters.i_NbrDoChannel;
+   s->n_chan = this_board->i_NbrDoChannel;
+   s->maxdata = this_board->i_DoMaxdata;
+   s->len_chanlist = this_board->i_NbrDoChannel;
s->range_table = &range_digital;
 
/* insn_config - for digital output memory */
@@ -135,7 +118,7 @@ static int apci1564_auto_attach(struct comedi_device *dev,
 
/*  Allocate and Initialise Timer Subdevice Structures */
s = &dev->subdevices[4];
-   if (devpriv->s_EeParameters.i_Timer) {
+   if (this_board->i_Timer) {
s->type = COMEDI_SUBD_TIMER;
s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = 1;
-- 
1.9.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel