[PATCH V2 2/4] Staging:rtl8192e Fix Comparison to False is error prone

[Janani Sankara Babu]

This patch removes comparison to False and boolean in the code
which can be written as !var

Signed-off-by: Janani Sankara Babu <janani...@gmail.com>
---
changelog
v2 : remove comparison to 0 , replacing with !var
v1 : remove comparison to false

 drivers/staging/rtl8192e/rtl819x_BAProc.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c 
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index c466a5e7..f194705 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -257,8 +257,8 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct 
sk_buff *skb)
        pBaStartSeqCtrl = (union sequence_control *)(req + 7);

        RT_TRACE(COMP_DBG, "====>rx ADDBAREQ from : %pM\n", dst);
-       if (ieee->current_network.qos_data.active == 0  ||
-           (ieee->pHTInfo->bCurrentHTSupport == false) ||
+       if (!ieee->current_network.qos_data.active ||
+           !ieee->pHTInfo->bCurrentHTSupport ||
            (ieee->pHTInfo->IOTAction & HT_IOT_ACT_REJECT_ADDBA_REQ)) {
                rc = ADDBA_STATUS_REFUSED;
                netdev_warn(ieee->dev,
@@ -340,9 +340,9 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct 
sk_buff *skb)
        pBaTimeoutVal = (u16 *)(tag + 7);

        RT_TRACE(COMP_DBG, "====>rx ADDBARSP from : %pM\n", dst);
-       if (ieee->current_network.qos_data.active == 0  ||
-           ieee->pHTInfo->bCurrentHTSupport == false ||
-           ieee->pHTInfo->bCurrentAMPDUEnable == false) {
+       if (!ieee->current_network.qos_data.active ||
+           !ieee->pHTInfo->bCurrentHTSupport ||
+           !ieee->pHTInfo->bCurrentAMPDUEnable) {
                netdev_warn(ieee->dev,
                            "reject to ADDBA_RSP as some capability is not 
ready(%d, %d, %d)\n",
                            ieee->current_network.qos_data.active,
@@ -369,7 +369,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct 
sk_buff *skb)
                netdev_dbg(ieee->dev, "%s(): ADDBA response already admitted\n",
                           __func__);
                return -1;
-       } else if ((pPendingBA->bValid == false) ||
+       } else if (!pPendingBA->bValid ||
                   (*pDialogToken != pPendingBA->DialogToken)) {
                netdev_warn(ieee->dev,
                            "%s(): ADDBA Rsp. BA invalid, DELBA!\n",
@@ -431,8 +431,8 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct 
sk_buff *skb)
                return -1;
        }

-       if (ieee->current_network.qos_data.active == 0  ||
-               ieee->pHTInfo->bCurrentHTSupport == false) {
+       if (!ieee->current_network.qos_data.active ||
+               !ieee->pHTInfo->bCurrentHTSupport) {
                netdev_warn(ieee->dev,
                            "received DELBA while QOS or HT is not 
supported(%d, %d)\n",
                            ieee->current_network. qos_data.active,
--
1.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel