Re: [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread 
On Sat, Jul 25, 2020 at 07:21:24PM +0200, Greg KH wrote:
> On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote:
> > clear below issues reported by checkpatch.pl:
> > 
> > CHECK: Using comparison to true is error prone
> 
> Again, you did more than just this in the patch :(

do you mean by reducing line lengths??




___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread Greg KH 
On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote:
> clear below issues reported by checkpatch.pl:
> 
> CHECK: Using comparison to true is error prone

Again, you did more than just this in the patch :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread John Oldman 
clear below issues reported by checkpatch.pl:

CHECK: Using comparison to true is error prone

Signed-off-by: John Oldman 
---
v1- First attempt: removed comparison to true.
v2- Removed unneccessary parentheses around 'pregistrypriv->ht_enable, missed 
in v1.
v3- Corrected the 'odd' subject line; moved the || and && to the end of the 
line.

 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c 
b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index ca98274ae390..46fad71197b6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
}

/* HT Cap. */
-   if (((pregistrypriv->wireless_mode_11_5N) || 
(pregistrypriv->wireless_mode_11_24N))
-   && (pregistrypriv->ht_enable == true)) {
+   if (((pregistrypriv->wireless_mode & WIRELESS_11_5N) ||
+(pregistrypriv->wireless_mode & WIRELESS_11_24N)) &&
+pregistrypriv->ht_enable) {
/* todo: */
}

--
2.17.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel