Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Dan Carpenter
On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote:
 Cc: Forest Bond for...@alittletooquiet.net
 Signed-off-by: Bjørn Mork bj...@mork.no
 ---

The changlog is missing.  Why does this patch help?

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Bjørn Mork
Dan Carpenter dan.carpen...@oracle.com writes:

 On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote:
 Cc: Forest Bond for...@alittletooquiet.net
 Signed-off-by: Bjørn Mork bj...@mork.no
 ---

 The changlog is missing.

Yes, right.  Sorry about that.

  Why does this patch help?

It ensures that addr_assign_type is set to the same value as the parent
device the dev_addr is copied from.  The initial reason was that I found
it strange to see NET_ADDR_PERM on a vlan device which had inherited a
random address from its parent.

But I haven't verified whether that the parent device actually can have
an addr_assign_type != NET_ADDR_PERM for every driver included. 


Bjørn

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel