Re: [PATCH resend] staging:xgifb:remove unused code
On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- > drivers/staging/xgifb/vb_setmode.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/xgifb/vb_setmode.c > b/drivers/staging/xgifb/vb_setmode.c > index 50c8ea4..71bb9ca 100644 > --- a/drivers/staging/xgifb/vb_setmode.c > +++ b/drivers/staging/xgifb/vb_setmode.c > @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex, > tempax |= 0x40; > > xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax); > - data = xgifb_reg_get(pVBInfo->P3d4, 0x07); But this did something with the hardware, are you sure this doesn't break anything? Lots of hardware works with the sequence of: write something read something to make sure the write worked. Did you test this? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH resend] staging:xgifb:remove unused code
On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- The subject should have been [Patch v2] not resend. regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH resend] staging:xgifb:remove unused code
The variable data is assigned but never used in rest code. Signed-off-by: Ding Xiang --- drivers/staging/xgifb/vb_setmode.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index 50c8ea4..71bb9ca 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex, tempax |= 0x40; xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax); - data = xgifb_reg_get(pVBInfo->P3d4, 0x07); tempax = 0; if (tempbx & 0x04) -- 1.7.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel