Re: [PATCH v2] staging: greybus: audio_module: remove redundant OOM message

[Viresh Kumar]

On Tue, Dec 6, 2016 at 7:39 PM, Srikant Ritolia  wrote:
> All kmalloc-based functions print enough information on failure
>
> Signed-off-by: Srikant Ritolia 
> ---
> Changes in v2:
>   - Added driver name in the subject for better readability.

Acked-by: Viresh Kumar 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging: greybus: audio_module: remove redundant OOM message

[Johan Hovold]

On Tue, Dec 06, 2016 at 07:39:36PM +0530, Srikant Ritolia wrote:
> All kmalloc-based functions print enough information on failure
> 
> Signed-off-by: Srikant Ritolia 

Acked-by: Johan Hovold 

> ---
> Changes in v2:
>   - Added driver name in the subject for better readability.
> 
>  drivers/staging/greybus/audio_module.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_module.c 
> b/drivers/staging/greybus/audio_module.c
> index ae1c0fa..213251f 100644
> --- a/drivers/staging/greybus/audio_module.c
> +++ b/drivers/staging/greybus/audio_module.c
> @@ -207,10 +207,8 @@ static int gb_audio_add_data_connection(struct 
> gbaudio_module_info *gbmodule,
>   struct gbaudio_data_connection *dai;
>  
>   dai = devm_kzalloc(gbmodule->dev, sizeof(*dai), GFP_KERNEL);
> - if (!dai) {
> - dev_err(gbmodule->dev, "DAI Malloc failure\n");
> + if (!dai)
>   return -ENOMEM;
> - }
>  
>   connection = gb_connection_create_offloaded(bundle,
>   le16_to_cpu(cport_desc->id),

Thanks,
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: greybus: audio_module: remove redundant OOM message

[Srikant Ritolia]

All kmalloc-based functions print enough information on failure

Signed-off-by: Srikant Ritolia 
---
Changes in v2:
  - Added driver name in the subject for better readability.

 drivers/staging/greybus/audio_module.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/audio_module.c 
b/drivers/staging/greybus/audio_module.c
index ae1c0fa..213251f 100644
--- a/drivers/staging/greybus/audio_module.c
+++ b/drivers/staging/greybus/audio_module.c
@@ -207,10 +207,8 @@ static int gb_audio_add_data_connection(struct 
gbaudio_module_info *gbmodule,
struct gbaudio_data_connection *dai;
 
dai = devm_kzalloc(gbmodule->dev, sizeof(*dai), GFP_KERNEL);
-   if (!dai) {
-   dev_err(gbmodule->dev, "DAI Malloc failure\n");
+   if (!dai)
return -ENOMEM;
-   }
 
connection = gb_connection_create_offloaded(bundle,
le16_to_cpu(cport_desc->id),
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel