Re: [PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements
On Tue, Nov 17, 2015 at 10:28:17PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, November 17, 2015 5:18 PM > > To: Romer, Benjamin M > > Cc: *S-Par-Maintainer; driverdev-devel@linuxdriverproject.org > > Subject: Re: [PATCH v2 0/7] staging: unisys: visorinput fixes and > > enhancements > > > > On Mon, Nov 16, 2015 at 03:22:10PM -0500, Benjamin Romer wrote: > > > This patch series fixes visorinput to remove the dependency on FB and > > > add dependency to INPUT, cleans up some formatting issues found with > > > checkpatch.pl, and adds the capability to change screen resolutions > > > without breaking mouse functionality. > > > > > > This is a resubmission of the series. > > > > You changed nothing based on the previous discussion, not exactly a good > > way to get a patch series accepted :( > > We relocated a devdata_put() in "[PATCH v2 1/7]" at the recommendation > of Dan Carpenter. I guess I was mistaken that I had convinced you in our > previous email discussion about the need for the lock. :-( I have the short-term memory of a squirrel, if someone can't see in the patch itself why it is working correctly, you haven't convinced anyone :) Please be descriptive in the changelog about _why_ you are doing something, so that everyone understands, not the least being yourself in 8 years when you get a bug report asking why you did something in a specific commit (a real example of what happened to me earlier today.) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, November 17, 2015 5:18 PM > To: Romer, Benjamin M > Cc: *S-Par-Maintainer; driverdev-devel@linuxdriverproject.org > Subject: Re: [PATCH v2 0/7] staging: unisys: visorinput fixes and > enhancements > > On Mon, Nov 16, 2015 at 03:22:10PM -0500, Benjamin Romer wrote: > > This patch series fixes visorinput to remove the dependency on FB and > > add dependency to INPUT, cleans up some formatting issues found with > > checkpatch.pl, and adds the capability to change screen resolutions > > without breaking mouse functionality. > > > > This is a resubmission of the series. > > You changed nothing based on the previous discussion, not exactly a good > way to get a patch series accepted :( We relocated a devdata_put() in "[PATCH v2 1/7]" at the recommendation of Dan Carpenter. I guess I was mistaken that I had convinced you in our previous email discussion about the need for the lock. :-( > > Please split out the bugfix so that I can take that now, and make the > other changes as requested before resending. Ok. > > thanks, > > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements
On Mon, Nov 16, 2015 at 03:22:10PM -0500, Benjamin Romer wrote: > This patch series fixes visorinput to remove the dependency on FB and > add dependency to INPUT, cleans up some formatting issues found with > checkpatch.pl, and adds the capability to change screen resolutions > without breaking mouse functionality. > > This is a resubmission of the series. You changed nothing based on the previous discussion, not exactly a good way to get a patch series accepted :( Please split out the bugfix so that I can take that now, and make the other changes as requested before resending. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements
This patch series fixes visorinput to remove the dependency on FB and add dependency to INPUT, cleans up some formatting issues found with checkpatch.pl, and adds the capability to change screen resolutions without breaking mouse functionality. This is a resubmission of the series. Tim Sell (7): staging: unisys: visorinput: use kref ref-counting for device data struct staging: unisys: visorinput: remove need for 'depends on FB' staging: unisys: visorinput: ensure proper locking wrt creation & ints staging: unisys: visorinput: respond to resolution changes on-the-fly staging: unisys: visorinput: sanity check resolution changes staging: unisys: visorinput: add useful dev_dbg() and dev_info() messages staging: unisys: visorinput: add INPUT to dependent driver list drivers/staging/unisys/visorinput/Kconfig | 2 +- drivers/staging/unisys/visorinput/visorinput.c | 209 + 2 files changed, 183 insertions(+), 28 deletions(-) -- 2.5.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
