Re: [PATCH v2 03/13] staging: iio: ad2s1200: Reverse Christmas tree ordering

[Jonathan Cameron]

On Fri, 20 Apr 2018 21:29:08 +0200
David Veenstra  wrote:

> Reorders the variable declarations to prefer a reverse Christmas tree
> order to improve readability.
> 
> Signed-off-by: David Veenstra 
Applied,

Thanks,

Jonathan

> ---
>  drivers/staging/iio/resolver/ad2s1200.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/resolver/ad2s1200.c 
> b/drivers/staging/iio/resolver/ad2s1200.c
> index ffcdf4e8eb92..b6c3a3c8f7fe 100644
> --- a/drivers/staging/iio/resolver/ad2s1200.c
> +++ b/drivers/staging/iio/resolver/ad2s1200.c
> @@ -46,9 +46,9 @@ static int ad2s1200_read_raw(struct iio_dev *indio_dev,
>int *val2,
>long m)
>  {
> + struct ad2s1200_state *st = iio_priv(indio_dev);
>   int ret = 0;
>   s16 vel;
> - struct ad2s1200_state *st = iio_priv(indio_dev);
>  
>   mutex_lock(&st->lock);
>   gpio_set_value(st->sample, 0);
> @@ -101,10 +101,10 @@ static const struct iio_info ad2s1200_info = {
>  
>  static int ad2s1200_probe(struct spi_device *spi)
>  {
> + unsigned short *pins = spi->dev.platform_data;
>   struct ad2s1200_state *st;
>   struct iio_dev *indio_dev;
>   int pn, ret = 0;
> - unsigned short *pins = spi->dev.platform_data;
>  
>   for (pn = 0; pn < AD2S1200_PN; pn++) {
>   ret = devm_gpio_request_one(&spi->dev, pins[pn], GPIOF_DIR_OUT,

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 03/13] staging: iio: ad2s1200: Reverse Christmas tree ordering

[David Veenstra]

Reorders the variable declarations to prefer a reverse Christmas tree
order to improve readability.

Signed-off-by: David Veenstra 
---
 drivers/staging/iio/resolver/ad2s1200.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/resolver/ad2s1200.c 
b/drivers/staging/iio/resolver/ad2s1200.c
index ffcdf4e8eb92..b6c3a3c8f7fe 100644
--- a/drivers/staging/iio/resolver/ad2s1200.c
+++ b/drivers/staging/iio/resolver/ad2s1200.c
@@ -46,9 +46,9 @@ static int ad2s1200_read_raw(struct iio_dev *indio_dev,
 int *val2,
 long m)
 {
+   struct ad2s1200_state *st = iio_priv(indio_dev);
int ret = 0;
s16 vel;
-   struct ad2s1200_state *st = iio_priv(indio_dev);
 
mutex_lock(&st->lock);
gpio_set_value(st->sample, 0);
@@ -101,10 +101,10 @@ static const struct iio_info ad2s1200_info = {
 
 static int ad2s1200_probe(struct spi_device *spi)
 {
+   unsigned short *pins = spi->dev.platform_data;
struct ad2s1200_state *st;
struct iio_dev *indio_dev;
int pn, ret = 0;
-   unsigned short *pins = spi->dev.platform_data;
 
for (pn = 0; pn < AD2S1200_PN; pn++) {
ret = devm_gpio_request_one(&spi->dev, pins[pn], GPIOF_DIR_OUT,
-- 
2.16.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel