Re: [PATCH v3] staging: typec: Fix endianness warning discovered by sparse

[Guenter Roeck]

On Fri, Jul 07, 2017 at 10:24:32AM +1000, Thomas Gardner wrote:
> The below warning is resolved by removing the cpu_to_le32() call. This
> call was redundant; vdm_run_state_machine() ensures that SVDM responses
> have the correct endianness before sending.
> 
> typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base 
> types)
> typec/tcpm.c:1019:49:expected unsigned int [unsigned] [usertype] 
> typec/tcpm.c:1019:49:got restricted __le32 [usertype] 
> 
> Signed-off-by: Thomas Gardner 

Reviewed-by: Guenter Roeck 

> ---
>  drivers/staging/typec/tcpm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
> index 20eb4ebcf8c3..2195c80235a1 100644
> --- a/drivers/staging/typec/tcpm.c
> +++ b/drivers/staging/typec/tcpm.c
> @@ -1015,8 +1015,7 @@ static int tcpm_pd_svdm(struct tcpm_port *port, const 
> __le32 *payload, int cnt,
>   if (port->data_role == TYPEC_DEVICE &&
>   port->nr_snk_vdo) {
>   for (i = 0; i <  port->nr_snk_vdo; i++)
> - response[i + 1]
> - = cpu_to_le32(port->snk_vdo[i]);
> + response[i + 1] = port->snk_vdo[i];
>   rlen = port->nr_snk_vdo + 1;
>   }
>   break;
> -- 
> 2.13.2
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3] staging: typec: Fix endianness warning discovered by sparse

[Thomas Gardner]

The below warning is resolved by removing the cpu_to_le32() call. This
call was redundant; vdm_run_state_machine() ensures that SVDM responses
have the correct endianness before sending.

typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base 
types)
typec/tcpm.c:1019:49:expected unsigned int [unsigned] [usertype] 
typec/tcpm.c:1019:49:got restricted __le32 [usertype] 

Signed-off-by: Thomas Gardner 
---
 drivers/staging/typec/tcpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 20eb4ebcf8c3..2195c80235a1 100644
--- a/drivers/staging/typec/tcpm.c
+++ b/drivers/staging/typec/tcpm.c
@@ -1015,8 +1015,7 @@ static int tcpm_pd_svdm(struct tcpm_port *port, const 
__le32 *payload, int cnt,
if (port->data_role == TYPEC_DEVICE &&
port->nr_snk_vdo) {
for (i = 0; i <  port->nr_snk_vdo; i++)
-   response[i + 1]
-   = cpu_to_le32(port->snk_vdo[i]);
+   response[i + 1] = port->snk_vdo[i];
rlen = port->nr_snk_vdo + 1;
}
break;
-- 
2.13.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel