Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
On Tue, Jun 26, 2018 at 11:56:40AM +0800, Greg Kroah-Hartman wrote: > On Mon, Jun 25, 2018 at 08:50:26PM +0100, John Whitmore wrote: > > On Mon, Jun 25, 2018 at 02:05:04PM +0100, Justin Skists wrote: > > > > > > > On 25 June 2018 at 13:36 John Whitmore wrote: > > > > > > > > > > > > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote: > > > > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore > > > > > wrote: > > > > > > Replaced memory initialising loop with memset, as suggested by Andy > > > > > > Shevchenko > > > > > > > > > > > > > > > > Suggested-by ? > > > > > > > > > > > > > Em, not sure how to respond, it certainly wasn't my idea. I was just > > > > making > > > > coding style changes, badly. ;) > > > > > > Suggested-by is a tag for patches, to give credit. For example: > > > > > > https://elixir.bootlin.com/linux/v4.18-rc1/source/Documentation/process/submitting-patches.rst > > > > > > See section "13) Using Reported-by:, Tested-by:, Reviewed-by:, > > > Suggested-by: and Fixes:" > > > > > > Hope that helps, > > > Justin. > > > > Oops... that helps thank you. I have to re-read that document, it obvioiusly > > didn't all sink in :( > > I've dropped this patch, can you fix it up and resend? > > thanks, > > greg k-h Yes I'll resend this patch, sorry about that error jwhitmore ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
On Mon, Jun 25, 2018 at 08:50:26PM +0100, John Whitmore wrote: > On Mon, Jun 25, 2018 at 02:05:04PM +0100, Justin Skists wrote: > > > > > On 25 June 2018 at 13:36 John Whitmore wrote: > > > > > > > > > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote: > > > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore > > > > wrote: > > > > > Replaced memory initialising loop with memset, as suggested by Andy > > > > > Shevchenko > > > > > > > > > > > > > Suggested-by ? > > > > > > > > > > Em, not sure how to respond, it certainly wasn't my idea. I was just > > > making > > > coding style changes, badly. ;) > > > > Suggested-by is a tag for patches, to give credit. For example: > > > > https://elixir.bootlin.com/linux/v4.18-rc1/source/Documentation/process/submitting-patches.rst > > > > See section "13) Using Reported-by:, Tested-by:, Reviewed-by:, > > Suggested-by: and Fixes:" > > > > Hope that helps, > > Justin. > > Oops... that helps thank you. I have to re-read that document, it obvioiusly > didn't all sink in :( I've dropped this patch, can you fix it up and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
On Mon, Jun 25, 2018 at 02:05:04PM +0100, Justin Skists wrote: > > > On 25 June 2018 at 13:36 John Whitmore wrote: > > > > > > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote: > > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore > > > wrote: > > > > Replaced memory initialising loop with memset, as suggested by Andy > > > > Shevchenko > > > > > > > > > > Suggested-by ? > > > > > > > Em, not sure how to respond, it certainly wasn't my idea. I was just making > > coding style changes, badly. ;) > > Suggested-by is a tag for patches, to give credit. For example: > > https://elixir.bootlin.com/linux/v4.18-rc1/source/Documentation/process/submitting-patches.rst > > See section "13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: > and Fixes:" > > Hope that helps, > Justin. Oops... that helps thank you. I have to re-read that document, it obvioiusly didn't all sink in :( thanks again. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
> On 25 June 2018 at 13:36 John Whitmore wrote: > > > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote: > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore > > wrote: > > > Replaced memory initialising loop with memset, as suggested by Andy > > > Shevchenko > > > > > > > Suggested-by ? > > > > Em, not sure how to respond, it certainly wasn't my idea. I was just making > coding style changes, badly. ;) Suggested-by is a tag for patches, to give credit. For example: https://elixir.bootlin.com/linux/v4.18-rc1/source/Documentation/process/submitting-patches.rst See section "13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:" Hope that helps, Justin. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote: > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore > wrote: > > Replaced memory initialising loop with memset, as suggested by Andy > > Shevchenko > > > > Suggested-by ? > Em, not sure how to respond, it certainly wasn't my idea. I was just making coding style changes, badly. ;) John ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore wrote:
> Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
>
Suggested-by ?
> Signed-off-by: John Whitmore
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index 4bfadb49c363..ccb7bdf5ad5d 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> @@ -742,8 +742,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device
> *ieee, u8 *posRT2RTAgg,
> */
> static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
> {
> - u8 i;
> -
> if (!pOperateMCS) {
> IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null
> in HT_PickMCSRate()\n");
> return false;
> @@ -756,8 +754,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee,
> u8 *pOperateMCS)
> //legacy rate routine handled at selectedrate
>
> //no MCS rate
> - for (i = 0; i <= 15; i++)
> - pOperateMCS[i] = 0;
> + memset(pOperateMCS, 0, 16);
> break;
>
> case IEEE_N_24G://assume CCK rate ok
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
Sorry having difficulty getting the full v3 patch set sent using git send-email. Only one seems to be going out. Sorry about the noise. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 4bfadb49c363..ccb7bdf5ad5d 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
@@ -742,8 +742,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device
*ieee, u8 *posRT2RTAgg,
*/
static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
{
- u8 i;
-
if (!pOperateMCS) {
IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null in
HT_PickMCSRate()\n");
return false;
@@ -756,8 +754,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8
*pOperateMCS)
//legacy rate routine handled at selectedrate
//no MCS rate
- for (i = 0; i <= 15; i++)
- pOperateMCS[i] = 0;
+ memset(pOperateMCS, 0, 16);
break;
case IEEE_N_24G://assume CCK rate ok
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 4bfadb49c363..ccb7bdf5ad5d 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
@@ -742,8 +742,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device
*ieee, u8 *posRT2RTAgg,
*/
static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
{
- u8 i;
-
if (!pOperateMCS) {
IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null in
HT_PickMCSRate()\n");
return false;
@@ -756,8 +754,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8
*pOperateMCS)
//legacy rate routine handled at selectedrate
//no MCS rate
- for (i = 0; i <= 15; i++)
- pOperateMCS[i] = 0;
+ memset(pOperateMCS, 0, 16);
break;
case IEEE_N_24G://assume CCK rate ok
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
