Re: [PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver
Hi Sakari, Thanks for the review. I will take this in account when preparing the v7, all your comments bellow look reasonable to me. --- Cheers, Rui On Thu 02 Aug 2018 at 14:00, Sakari Ailus wrote: Hi Rui, On Tue, May 22, 2018 at 03:52:39PM +0100, Rui Miguel Silva wrote: Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7-csi.txt| 44 ++ .../bindings/media/imx7-mipi-csi2.txt | 82 +++ 2 files changed, 126 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7-csi.txt create mode 100644 Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt diff --git a/Documentation/devicetree/bindings/media/imx7-csi.txt b/Documentation/devicetree/bindings/media/imx7-csi.txt new file mode 100644 index ..aab4f5d72390 --- /dev/null +++ b/Documentation/devicetree/bindings/media/imx7-csi.txt @@ -0,0 +1,44 @@ +Freescale i.MX7 CMOS Sensor Interface += + +csi node + + +This is device node for the CMOS Sensor Interface (CSI) which enables the chip +to connect directly to external CMOS image sensors. + +Required properties: + +- compatible: "fsl,imx7-csi"; +- reg : base address and length of the register set for the device; +- interrupts: should contain CSI interrupt; +- clocks: list of clock specifiers, see + Documentation/devicetree/bindings/clock/clock-bindings.txt for details; +- clock-names : must contain "axi", "mclk" and "dcic" entries, matching + entries in the clock property; + +The device node should contain one 'port' child node with one child 'endpoint' "should" or "shall"? +node, according to the bindings defined in Documentation/devicetree/bindings/ +media/video-interfaces.txt. In the following example a remote endpoint is a I wouldn't split the path as it breaks copy-paste; up to you. +video multiplexer. + +example: + +csi: csi@3071 { +#address-cells = <1>; +#size-cells = <0>; + +compatible = "fsl,imx7-csi"; +reg = <0x3071 0x1>; +interrupts = IRQ_TYPE_LEVEL_HIGH>; +clocks = < IMX7D_CLK_DUMMY>, +< IMX7D_CSI_MCLK_ROOT_CLK>, +< IMX7D_CLK_DUMMY>; +clock-names = "axi", "mclk", "dcic"; + +port { +csi_from_csi_mux: endpoint { +remote-endpoint = <_mux_to_csi>; +}; +}; +}; diff --git a/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt new file mode 100644 index ..7c5f20863724 --- /dev/null +++ b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt @@ -0,0 +1,82 @@ +Freescale i.MX7 Mipi CSI2 += + +mipi_csi2 node +-- + +This is the device node for the MIPI CSI-2 receiver core in i.MX7 SoC. It is +compatible with previous version of Samsung D-phy. + +Required properties: + +- compatible: "fsl,imx7-mipi-csi2"; +- reg : base address and length of the register set for the device; +- interrupts: should contain MIPI CSIS interrupt; +- clocks: list of clock specifiers, see + Documentation/devicetree/bindings/clock/clock-bindings.txt for details; +- clock-names : must contain "pclk", "wrap" and "phy" entries, matching + entries in the clock property; +- power-domains : a phandle to the power domain, see + Documentation/devicetree/bindings/power/power_domain.txt for details. +- reset-names : should include following entry "mrst"; +- resets: a list of phandle, should contain reset entry of + reset-names; +- phy-supply: from the generic phy bindings, a phandle to a regulator that + provides power to MIPI CSIS core; + +Optional properties: + +- clock-frequency : The IP's main (system bus) clock frequency in Hz, default + value when this property is not specified is 166 MHz; +- fsl,csis-hs-settle : differential receiver (HS-RX) settle time; + +port node +- + +- reg : (required) can take the values 0 or 1, where 0 is the + related sink port and port 1 should be the source one; Should and is -> shall? I think you should also elaborate whether or not the port (as well as the endpoint) nodes themselves are mandatory. + +endpoint node +- + +- data-lanes: (required) an array specifying active physical MIPI-CSI2 + data input lanes and their mapping to logical lanes; the +
Re: [PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver
Hi Rui, On Tue, May 22, 2018 at 03:52:39PM +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/imx7-csi.txt| 44 ++ > .../bindings/media/imx7-mipi-csi2.txt | 82 +++ > 2 files changed, 126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/imx7-csi.txt > create mode 100644 Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt > > diff --git a/Documentation/devicetree/bindings/media/imx7-csi.txt > b/Documentation/devicetree/bindings/media/imx7-csi.txt > new file mode 100644 > index ..aab4f5d72390 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/imx7-csi.txt > @@ -0,0 +1,44 @@ > +Freescale i.MX7 CMOS Sensor Interface > += > + > +csi node > + > + > +This is device node for the CMOS Sensor Interface (CSI) which enables the > chip > +to connect directly to external CMOS image sensors. > + > +Required properties: > + > +- compatible: "fsl,imx7-csi"; > +- reg : base address and length of the register set for the device; > +- interrupts: should contain CSI interrupt; > +- clocks: list of clock specifiers, see > +Documentation/devicetree/bindings/clock/clock-bindings.txt for > details; > +- clock-names : must contain "axi", "mclk" and "dcic" entries, matching > + entries in the clock property; > + > +The device node should contain one 'port' child node with one child > 'endpoint' "should" or "shall"? > +node, according to the bindings defined in Documentation/devicetree/bindings/ > +media/video-interfaces.txt. In the following example a remote endpoint is a I wouldn't split the path as it breaks copy-paste; up to you. > +video multiplexer. > + > +example: > + > +csi: csi@3071 { > +#address-cells = <1>; > +#size-cells = <0>; > + > +compatible = "fsl,imx7-csi"; > +reg = <0x3071 0x1>; > +interrupts = ; > +clocks = < IMX7D_CLK_DUMMY>, > +< IMX7D_CSI_MCLK_ROOT_CLK>, > +< IMX7D_CLK_DUMMY>; > +clock-names = "axi", "mclk", "dcic"; > + > +port { > +csi_from_csi_mux: endpoint { > +remote-endpoint = <_mux_to_csi>; > +}; > +}; > +}; > diff --git a/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt > b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt > new file mode 100644 > index ..7c5f20863724 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt > @@ -0,0 +1,82 @@ > +Freescale i.MX7 Mipi CSI2 > += > + > +mipi_csi2 node > +-- > + > +This is the device node for the MIPI CSI-2 receiver core in i.MX7 SoC. It is > +compatible with previous version of Samsung D-phy. > + > +Required properties: > + > +- compatible: "fsl,imx7-mipi-csi2"; > +- reg : base address and length of the register set for the device; > +- interrupts: should contain MIPI CSIS interrupt; > +- clocks: list of clock specifiers, see > +Documentation/devicetree/bindings/clock/clock-bindings.txt for > details; > +- clock-names : must contain "pclk", "wrap" and "phy" entries, matching > + entries in the clock property; > +- power-domains : a phandle to the power domain, see > + Documentation/devicetree/bindings/power/power_domain.txt for > details. > +- reset-names : should include following entry "mrst"; > +- resets: a list of phandle, should contain reset entry of > + reset-names; > +- phy-supply: from the generic phy bindings, a phandle to a regulator > that > + provides power to MIPI CSIS core; > + > +Optional properties: > + > +- clock-frequency : The IP's main (system bus) clock frequency in Hz, default > + value when this property is not specified is 166 MHz; > +- fsl,csis-hs-settle : differential receiver (HS-RX) settle time; > + > +port node > +- > + > +- reg : (required) can take the values 0 or 1, where 0 is > the > + related sink port and port 1 should be the source one; Should and is -> shall? I think you should also elaborate whether or not the port (as well as the endpoint) nodes themselves are mandatory. > + > +endpoint node > +- > + > +- data-lanes: (required) an array specifying active physical MIPI-CSI2 > + data input lanes and their mapping to logical lanes;
Re: [PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver
On Tue, May 22, 2018 at 03:52:39PM +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva> --- > .../devicetree/bindings/media/imx7-csi.txt| 44 ++ > .../bindings/media/imx7-mipi-csi2.txt | 82 +++ > 2 files changed, 126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/imx7-csi.txt > create mode 100644 Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt Reviewed-by: Rob Herring ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver
Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva--- .../devicetree/bindings/media/imx7-csi.txt| 44 ++ .../bindings/media/imx7-mipi-csi2.txt | 82 +++ 2 files changed, 126 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7-csi.txt create mode 100644 Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt diff --git a/Documentation/devicetree/bindings/media/imx7-csi.txt b/Documentation/devicetree/bindings/media/imx7-csi.txt new file mode 100644 index ..aab4f5d72390 --- /dev/null +++ b/Documentation/devicetree/bindings/media/imx7-csi.txt @@ -0,0 +1,44 @@ +Freescale i.MX7 CMOS Sensor Interface += + +csi node + + +This is device node for the CMOS Sensor Interface (CSI) which enables the chip +to connect directly to external CMOS image sensors. + +Required properties: + +- compatible: "fsl,imx7-csi"; +- reg : base address and length of the register set for the device; +- interrupts: should contain CSI interrupt; +- clocks: list of clock specifiers, see +Documentation/devicetree/bindings/clock/clock-bindings.txt for details; +- clock-names : must contain "axi", "mclk" and "dcic" entries, matching + entries in the clock property; + +The device node should contain one 'port' child node with one child 'endpoint' +node, according to the bindings defined in Documentation/devicetree/bindings/ +media/video-interfaces.txt. In the following example a remote endpoint is a +video multiplexer. + +example: + +csi: csi@3071 { +#address-cells = <1>; +#size-cells = <0>; + +compatible = "fsl,imx7-csi"; +reg = <0x3071 0x1>; +interrupts = ; +clocks = < IMX7D_CLK_DUMMY>, +< IMX7D_CSI_MCLK_ROOT_CLK>, +< IMX7D_CLK_DUMMY>; +clock-names = "axi", "mclk", "dcic"; + +port { +csi_from_csi_mux: endpoint { +remote-endpoint = <_mux_to_csi>; +}; +}; +}; diff --git a/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt new file mode 100644 index ..7c5f20863724 --- /dev/null +++ b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt @@ -0,0 +1,82 @@ +Freescale i.MX7 Mipi CSI2 += + +mipi_csi2 node +-- + +This is the device node for the MIPI CSI-2 receiver core in i.MX7 SoC. It is +compatible with previous version of Samsung D-phy. + +Required properties: + +- compatible: "fsl,imx7-mipi-csi2"; +- reg : base address and length of the register set for the device; +- interrupts: should contain MIPI CSIS interrupt; +- clocks: list of clock specifiers, see +Documentation/devicetree/bindings/clock/clock-bindings.txt for details; +- clock-names : must contain "pclk", "wrap" and "phy" entries, matching + entries in the clock property; +- power-domains : a phandle to the power domain, see + Documentation/devicetree/bindings/power/power_domain.txt for details. +- reset-names : should include following entry "mrst"; +- resets: a list of phandle, should contain reset entry of + reset-names; +- phy-supply: from the generic phy bindings, a phandle to a regulator that + provides power to MIPI CSIS core; + +Optional properties: + +- clock-frequency : The IP's main (system bus) clock frequency in Hz, default + value when this property is not specified is 166 MHz; +- fsl,csis-hs-settle : differential receiver (HS-RX) settle time; + +port node +- + +- reg: (required) can take the values 0 or 1, where 0 is the + related sink port and port 1 should be the source one; + +endpoint node +- + +- data-lanes: (required) an array specifying active physical MIPI-CSI2 + data input lanes and their mapping to logical lanes; the + array's content is unused, only its length is meaningful; + +example: + +mipi_csi: mipi-csi@3075 { +#address-cells = <1>; +#size-cells = <0>; + +compatible = "fsl,imx7-mipi-csi2"; +reg = <0x3075 0x1>; +interrupts = ; +clocks = < IMX7D_IPG_ROOT_CLK>, +< IMX7D_MIPI_CSI_ROOT_CLK>, +< IMX7D_MIPI_DPHY_ROOT_CLK>; +